Re: Review Request: Remember|Forget instead of OK|Cancel in the highscore dialog.
|
View:
New views
7 Messages
—
Rating Filter:
Alert me
|
 |
|
|
|
Re: Review Request: Remember|Forget instead of OK|Cancel in the highscore dialog.
by Bugzilla from jtamate@gmail.com
::
Rate this Message:
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/947/ ----------------------------------------------------------- (Updated 2009-07-30 18:13:26.351374) Review request for KDE Games and usability. Changes ------- New version, tested with killbots, kollision and ktron. Pressing Remember does as before except that: * deletes the lowest highscore * changes the button to close * deletes the congratulations (I'm not sure about this). Pressing Enter in the textedit behaves as pressing Remember, except that the dialog is not closed. Pressing Forget: * deletes the newest highscore * changes the button to close * deletes the congratulations (I'm sure about this). Summary ------- Use the more descriptive verbs Remember and Forget (this highscore) instead of OK|Cancel. Diffs (updated) ----- /trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.h 1003061 /trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.cpp 1003061 Diff: http://reviewboard.kde.org/r/947/diff Testing ------- The dialog works as before. Thanks, Jaime _______________________________________________ kde-usability mailing list kde-usability@... https://mail.kde.org/mailman/listinfo/kde-usability |
|
|
Re: Review Request: Remember|Forget instead of OK|Cancel in the highscore dialog.
by Albert Astals Cid-2
::
Rate this Message:
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/947/#review1862 ----------------------------------------------------------- Why delete the lowest highscore on remember? d->lastHighPosition=i; is missing two spaces Also i don't understand the "show the previous label" part, can you explain it? Wouldn't you need a loop there to move all them up and not just one? - Albert On 2009-07-30 18:13:26, Jaime Torres wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/947/ > ----------------------------------------------------------- > > (Updated 2009-07-30 18:13:26) > > > Review request for KDE Games and usability. > > > Summary > ------- > > Use the more descriptive verbs Remember and Forget (this highscore) instead of OK|Cancel. > > > Diffs > ----- > > /trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.h 1003061 > /trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.cpp 1003061 > > Diff: http://reviewboard.kde.org/r/947/diff > > > Testing > ------- > > The dialog works as before. > > > Thanks, > > Jaime > > _______________________________________________ kde-usability mailing list kde-usability@... https://mail.kde.org/mailman/listinfo/kde-usability |
|
|
Re: Review Request: Remember|Forget instead of OK|Cancel in the highscore dialog.
by Bugzilla from jtamate@gmail.com
::
Rate this Message:
> On 2009-07-30 21:44:02, Albert Astals Cid wrote: > > Why delete the lowest highscore on remember? > > > > d->lastHighPosition=i; is missing two spaces > > > > Also i don't understand the "show the previous label" part, can you explain it? Wouldn't you need a loop there to move all them up and not just one? I delete the lowest highscore on remember (as oposed to do it in addScore) because it is there when you know that the new highscore will be remembered, and it can store only 10 highscores, so the lowest one will dissapear. Spaces, I will fix them. "show the previous label"... Probably it is not needed (I think they are repainted in the aboutToShow method). I'll try without this. - Jaime ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/947/#review1862 ----------------------------------------------------------- On 2009-07-30 18:13:26, Jaime Torres wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/947/ > ----------------------------------------------------------- > > (Updated 2009-07-30 18:13:26) > > > Review request for KDE Games and usability. > > > Summary > ------- > > Use the more descriptive verbs Remember and Forget (this highscore) instead of OK|Cancel. > > > Diffs > ----- > > /trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.h 1003061 > /trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.cpp 1003061 > > Diff: http://reviewboard.kde.org/r/947/diff > > > Testing > ------- > > The dialog works as before. > > > Thanks, > > Jaime > > _______________________________________________ kde-usability mailing list kde-usability@... https://mail.kde.org/mailman/listinfo/kde-usability |
|
|
Re: Review Request: Remember|Forget instead of OK|Cancel in the highscore dialog.
by Bugzilla from jtamate@gmail.com
::
Rate this Message:
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/947/ ----------------------------------------------------------- (Updated 2009-07-31 19:11:52.407426) Review request for KDE Games and usability. Changes ------- Removed a tiny memory leak (in the QStackWidget). Added two spaces. Removed the label stuff in the forget slot (it is painted in the aboutToShow). Summary ------- Use the more descriptive verbs Remember and Forget (this highscore) instead of OK|Cancel. Diffs (updated) ----- /trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.h 1003061 /trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.cpp 1003061 Diff: http://reviewboard.kde.org/r/947/diff Testing ------- The dialog works as before. Thanks, Jaime _______________________________________________ kde-usability mailing list kde-usability@... https://mail.kde.org/mailman/listinfo/kde-usability |
|
|
Re: Review Request: Remember|Forget instead of OK|Cancel in the highscore dialog.
by Albert Astals Cid-2
::
Rate this Message:
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/947/#review1910 ----------------------------------------------------------- Ship it! Seems ok, commit it to trunk branch please. - Albert On 2009-07-31 19:11:52, Jaime Torres wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/947/ > ----------------------------------------------------------- > > (Updated 2009-07-31 19:11:52) > > > Review request for KDE Games and usability. > > > Summary > ------- > > Use the more descriptive verbs Remember and Forget (this highscore) instead of OK|Cancel. > > > Diffs > ----- > > /trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.h 1003061 > /trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.cpp 1003061 > > Diff: http://reviewboard.kde.org/r/947/diff > > > Testing > ------- > > The dialog works as before. > > > Thanks, > > Jaime > > _______________________________________________ kde-usability mailing list kde-usability@... https://mail.kde.org/mailman/listinfo/kde-usability |
|
|
Re: Review Request: Remember|Forget instead of OK|Cancel in the highscore dialog.
by Bugzilla from jtamate@gmail.com
::
Rate this Message:
> On 2009-08-05 21:44:13, Albert Astals Cid wrote: > > Seems ok, commit it to trunk branch please. Shipped as r1007925 in trunk. - Jaime ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/947/#review1910 ----------------------------------------------------------- On 2009-07-31 19:11:52, Jaime Torres wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/947/ > ----------------------------------------------------------- > > (Updated 2009-07-31 19:11:52) > > > Review request for KDE Games and usability. > > > Summary > ------- > > Use the more descriptive verbs Remember and Forget (this highscore) instead of OK|Cancel. > > > Diffs > ----- > > /trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.h 1003061 > /trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.cpp 1003061 > > Diff: http://reviewboard.kde.org/r/947/diff > > > Testing > ------- > > The dialog works as before. > > > Thanks, > > Jaime > > _______________________________________________ kde-usability mailing list kde-usability@... https://mail.kde.org/mailman/listinfo/kde-usability |
| Free embeddable forum powered by Nabble | Forum Help |
