« Return to Thread: Review Request: The "Copy Input To" submenu should use combo boxes instead of check boxes

Re: Review Request: The "Copy Input To" submenu should use combo boxes instead of check boxes

by Kurt Hindenburg-4 :: Rate this Message:

| View in Thread

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104202/

Ship it!

UI looks fine

The only thing that stood out was:
_copyToAllTabsAction = copyInputToAllTabsAction;
I see where we use it later; perhaps use the _copy instead of the copy?  and/or add comment.

- Kurt


On March 9th, 2012, 5:02 a.m., Jekyll Wu wrote:

Review request for Konsole.
By Jekyll Wu.

Updated March 9, 2012, 5:02 a.m.

Description

The existing UI is misleading: the three check boxes imply that you can enable any of them independently, but actually you can only enable one of them at any time. So the three choices should be shown using combo boxes instead of check boxes.

The code is basically stolen from dolphin. Again, I'm always not that confident with UI changes, so please check the code for any stupid or unnecessary code.

Testing

Seems fine.

Diffs

  • desktop/sessionui.rc (0dd1b66)
  • src/SessionController.h (46714c0)
  • src/SessionController.cpp (f437d9b)

View Diff

Screenshots

before after

_______________________________________________
konsole-devel mailing list
konsole-devel@...
https://mail.kde.org/mailman/listinfo/konsole-devel

 « Return to Thread: Review Request: The "Copy Input To" submenu should use combo boxes instead of check boxes