« Return to Thread: Review Request: add deco API versioning support

Re: Review Request: add deco API versioning support

by Martin Gräßlin :: Rate this Message:

| View in Thread

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104978/

On May 17th, 2012, 8:24 p.m., Martin Gräßlin wrote:

It would break my setup as Aurorae is not yet adjusted ;-) and we probably should also update all the decorations in kde-artwork.

On May 17th, 2012, 8:29 p.m., Thomas Lübking wrote:

Nope, ideally you get a nice "use the macro" hint but no break.
Christoph and Craig would crucify me otherwise :-)

But yes, we should update the shipped decos.
I have however no kde-artwork checkout ... ;-)
I will add the macros to kde-artwork

- Martin


On May 17th, 2012, 8:13 p.m., Thomas Lübking wrote:

Review request for kwin and Martin Gräßlin.
By Thomas Lübking.

Updated May 17, 2012, 8:13 p.m.

Description

summarized - there's only one simple version and it has to match exactly (cause we use this to break ABI)

Testing

oxygen load, bespin told me to use the macro, i faked a wrong version exporting the function by hand and kwin fell back to oxygen telling me my (ahead) version is wrong.
Bugs: 299141

Diffs

  • kwin/clients/oxygen/oxygenfactory.cpp (827aa59)
  • kwin/libkdecorations/kdecoration.h (442d0a1)
  • kwin/libkdecorations/kdecoration_plugins_p.h (3da3f2e)
  • kwin/libkdecorations/kdecoration_plugins_p.cpp (26e01bf)

View Diff


_______________________________________________
kwin mailing list
kwin@...
https://mail.kde.org/mailman/listinfo/kwin

 « Return to Thread: Review Request: add deco API versioning support