|
workspace/kio/kio_activities.cpp
(Diff revision 1)
|
public: |
|
|
215 |
kio->listEntry(createUDSEntryForUrl(QUrl::fromPercentEncoding(it[1].toString().toAscii())), false); |
This looks like a very ugly workaround, to me.
Does it[1].uri() return a QUrl, or a QString?
If a QString, then the problem is passing it to the QUrl constructor. QUrl in Qt4 is broken in that respect. (Fixed in Qt5).
Use KUrl instead, or use QUrl::fromEncoded(it[1].uri().toLatin1()). I'd prefer KUrl though, to keep this code readable and make it a one-char fix ;)
- David
On June 18th, 2012, 6:09 a.m., Xuetian Weng wrote:
|
Review request for KDE Runtime and Ivan Čukić.
By Xuetian Weng.
Updated June 18, 2012, 6:09 a.m.
Description
The query result for the Uri is already encoded to PercentEncoding, thus url.url() will not get the correct url.
Not sure this should always handled in this case, or soprano itself (uri()) should be fixed.
|
Testing
Works here for utf8 file name.
|
Diffs
- workspace/kio/kio_activities.cpp (8ef1f7b)
View Diff
|
