« Return to Thread: Review Request: kjs: Implement standard String.trim, also non-standard trimLeft & trimRight

Re: Review Request: kjs: Implement standard String.trim, also non-standard trimLeft & trimRight

by Commit Hook-2 :: Rate this Message:

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104857/

This review has been submitted with commit 5605129a9e8024d47eee92a4b8110cfe0742ddbc by Bernd Buschinski to branch KDE/4.8.

- Commit

On May 4th, 2012, 5:40 p.m., Bernd Buschinski wrote:

Review request for kdelibs.

By Bernd Buschinski.

Updated May 4, 2012, 5:40 p.m.

Description

kjs: Implement standard String.trim, also non-standard trimLeft & trimRight

As trimLeft&trimRight are very similar and easy to implement in trim, and all modern browser support it as well, I also added it.

depends on https://git.reviewboard.kde.org/r/104855/

Testing

ecma Strimg.trim tests

Diffs

kjs/string_object.h (e890d52)
kjs/string_object.cpp (170e2f7)

View Diff

« Return to Thread: Review Request: kjs: Implement standard String.trim, also non-standard trimLeft & trimRight