Re: Review Request: qgpgmecryptoconfig.cpp:744: warning: suggest explicit braces to avoid ambiguous 'else'

View: New views
1 Messages — Rating Filter:   Alert me  

Parent Message unknown Re: Review Request: qgpgmecryptoconfig.cpp:744: warning: suggest explicit braces to avoid ambiguous 'else'

by Bugzilla from christophpfister@gmail.com :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2147/#review3058
-----------------------------------------------------------


this patch doesn't belong to the group 'kaffeine'

- Christoph


On 2009-11-12 17:55:03, Guy Maurel wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2147/
> -----------------------------------------------------------
>
> (Updated 2009-11-12 17:55:03)
>
>
> Review request for kaffeine.
>
>
> Summary
> -------
>
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs
> reports:
> /.../kdepim/libkleo/backends/qgpgme/qgpgmecryptoconfig.cpp:744: warning: suggest explicit braces to avoid ambiguous 'else'
>
> at
> QGpgMECryptoConfigEntry::resetToDefault(
>
> my proposal: complete with some more parentheses
> see: qgpgmecryptoconfig-gm-58.diff
>
>
> Diffs
> -----
>
>   /trunk/KDE/kdepim/libkleo/backends/qgpgme/qgpgmecryptoconfig.cpp 1046400
>
> Diff: http://reviewboard.kde.org/r/2147/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guy
>
>


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
kaffeine-user mailing list
kaffeine-user@...
https://lists.sourceforge.net/lists/listinfo/kaffeine-user