« Return to Thread: Several Small Code Fixes

Re: Several Small Code Fixes

by Matthias Schmidt-14 :: Rate this Message:

Reply to Author | View in Thread

I suggest I create a couple of tickets, one per type
- XSS
- Nullpointer
- etc.

Dave wrote:

> It depends. If there are only a dozen or so fixes, then one "roll-up"
> issue report with a patch might be OK. We need to be able to review
> each change before we commit.
>
> - Dave
>
>
> On Sun, May 17, 2009 at 3:11 PM, Matthias Schmidt
> <matthias.schmidt@...> wrote:
>> Hi all,
>>
>>
>> While building a custom version of Roller for our client, I went through
>> Roller's source code using FindBugs and I have several fixes to commit.
>> Those are spread all over the source files, mostly smaller fixes like
>> some misspelling that lead to NPEs and so on.
>>
>> I think it would be way too time-consuming to create a ticket for each
>> fix. Would it be okay for you guys if I create one ticket for all those
>> findbugs suggestions (one to rule them all)?
>>
>>
>> Thanks,
>> Matt
>>
>>
>>


 « Return to Thread: Several Small Code Fixes