« Return to Thread: Some development questions
Re: Some development questions
by Nicolas Boullis
::
Rate this Message:
Hi,
On Wed, Sep 10, 2008 at 08:31:49AM +0000, Christian Gmeiner wrote:
>
> Fine... more stuff is coming...
I just did some more merges.
Note that the patches are not rejected, I just have not had time yet to
review them (especially
http://freehg.org/u/austriancoder/em8300-cgmeiner/rev/452d407a9ddc which
is non-trivial).
> > 3) Here are (roughly) the rules I try to follow to be compatible with a
> > broad range of kernel versions:
> > - whenever possible, don't use kernel versions at all (think
> > CONFIG_*)
> > - if it is necessary to support several different API, whenever
> > possible, use the more recent one in the code and use a macro as
> > a wrapper for older kernels
> > - when 2 API overlap and must be supported, use the more recent one
> > as early as possible
> > http://freehg.org/u/austriancoder/em8300-cgmeiner/rev/8073355cea68
> > does not follow there rules; I'll rewrite it.
>
> I am waiting for your solution to be commited.
Done: http://dxr3.sourceforge.net/hg/em8300-nboullis/rev/74b8fc170464
> > By the way, I don't know what /usr/src/linux/scripts/checkpatch.pl
> > really is, but I think there's no way the em8300 drivers can be merged
> > into the kernel until our adv717x and bt865 drivers are merged with the
> > corresponding drivers in the kernel... :-/
>
> As I have a lot of free time at the moment I will look in this topic.
> Maybe I will start
> an other development repository, where I will have working code only
> for the current
> development release. If the adv717x and bt865 driver in the kernel are ready, we
I don't think the adv7170, adv7175 and bt865 drivers in the kernel are
featurefull enough for use with H+/DXR3 boards... I fear the features
have to be merged, which will be somewhat non-trivial.
> should kick our interface (ioctls, etc) and switch to v4l2 as it has
> support for video output devices.
That'd be nice, but compatibility also matters. People don't wan't to
throw their old code. (Look at the dxr3 plugin for dvr that never
switched to ALSA...)
> Also I think the em9010 stuff should go into an own module.
I agree. By the way, I found a datasheet for the em9010 that tells that
it's an i2c chip. The current code does not address it in an
i2c-compatible way, so I think one should check if it works when
adressed in an i2c-compatible way, and then switch to using i2c
functions.
> To be honest, I have started some work on v4l2 and em8300 already. But
> I have some
> other stuff on my todo:
>
> * register macros
> * cleanup i2c code
> * better way to load fw
> * coding style fixes
> * adv717x and bt865 modlues
>
> I hope you can do merges of my tree more often.
Does it really matter? If your repository is more advanced and
better-maintained than mine, yours naturally becomes the "central"
repository.
Cheers,
Nicolas
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Dxr3-devel mailing list
Dxr3-devel@...
https://lists.sourceforge.net/lists/listinfo/dxr3-devel
On Wed, Sep 10, 2008 at 08:31:49AM +0000, Christian Gmeiner wrote:
>
> Fine... more stuff is coming...
I just did some more merges.
Note that the patches are not rejected, I just have not had time yet to
review them (especially
http://freehg.org/u/austriancoder/em8300-cgmeiner/rev/452d407a9ddc which
is non-trivial).
> > 3) Here are (roughly) the rules I try to follow to be compatible with a
> > broad range of kernel versions:
> > - whenever possible, don't use kernel versions at all (think
> > CONFIG_*)
> > - if it is necessary to support several different API, whenever
> > possible, use the more recent one in the code and use a macro as
> > a wrapper for older kernels
> > - when 2 API overlap and must be supported, use the more recent one
> > as early as possible
> > http://freehg.org/u/austriancoder/em8300-cgmeiner/rev/8073355cea68
> > does not follow there rules; I'll rewrite it.
>
> I am waiting for your solution to be commited.
Done: http://dxr3.sourceforge.net/hg/em8300-nboullis/rev/74b8fc170464
> > By the way, I don't know what /usr/src/linux/scripts/checkpatch.pl
> > really is, but I think there's no way the em8300 drivers can be merged
> > into the kernel until our adv717x and bt865 drivers are merged with the
> > corresponding drivers in the kernel... :-/
>
> As I have a lot of free time at the moment I will look in this topic.
> Maybe I will start
> an other development repository, where I will have working code only
> for the current
> development release. If the adv717x and bt865 driver in the kernel are ready, we
I don't think the adv7170, adv7175 and bt865 drivers in the kernel are
featurefull enough for use with H+/DXR3 boards... I fear the features
have to be merged, which will be somewhat non-trivial.
> should kick our interface (ioctls, etc) and switch to v4l2 as it has
> support for video output devices.
That'd be nice, but compatibility also matters. People don't wan't to
throw their old code. (Look at the dxr3 plugin for dvr that never
switched to ALSA...)
> Also I think the em9010 stuff should go into an own module.
I agree. By the way, I found a datasheet for the em9010 that tells that
it's an i2c chip. The current code does not address it in an
i2c-compatible way, so I think one should check if it works when
adressed in an i2c-compatible way, and then switch to using i2c
functions.
> To be honest, I have started some work on v4l2 and em8300 already. But
> I have some
> other stuff on my todo:
>
> * register macros
> * cleanup i2c code
> * better way to load fw
> * coding style fixes
> * adv717x and bt865 modlues
>
> I hope you can do merges of my tree more often.
Does it really matter? If your repository is more advanced and
better-maintained than mine, yours naturally becomes the "central"
repository.
Cheers,
Nicolas
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Dxr3-devel mailing list
Dxr3-devel@...
https://lists.sourceforge.net/lists/listinfo/dxr3-devel
« Return to Thread: Some development questions
| Free embeddable forum powered by Nabble | Forum Help |
