« Return to Thread: Some development questions

Re: Some development questions

by Nicolas Boullis :: Rate this Message:

Reply to Author | View in Thread

Hi Christian,

On Fri, Sep 12, 2008 at 02:14:56AM +0200, Nicolas Boullis wrote:

> Hi,
>
> On Wed, Sep 10, 2008 at 08:31:49AM +0000, Christian Gmeiner wrote:
> >
> > Fine... more stuff is coming...
>
> I just did some more merges.
> Note that the patches are not rejected, I just have not had time yet to
> review them (especially
> http://freehg.org/u/austriancoder/em8300-cgmeiner/rev/452d407a9ddc which
> is non-trivial).

I just had a more thorough look at 452d407a9ddc and I fal to understand
why you do all this stuff around the pci_set_master call (check for
PCI_COMMAND_MASTER both before and after).
As far as U can see, most drivers that use pci_set_master don't do such
things (although at least drivers/ide/setup-pci.c and
drivers/media/video/ivtv/ivtv-driver.c do).
Do you have any explanation?


Cheers,

Nicolas

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Dxr3-devel mailing list
Dxr3-devel@...
https://lists.sourceforge.net/lists/listinfo/dxr3-devel

 « Return to Thread: Some development questions