« Return to Thread: Some development questions

Re: Some development questions

by Christian Gmeiner-4 :: Rate this Message:

Hi Nicolas,

2008/9/14 Nicolas Boullis <nboullis@...>:

> Hi Christian,
>
> On Fri, Sep 12, 2008 at 02:14:56AM +0200, Nicolas Boullis wrote:
>> Hi,
>>
>> On Wed, Sep 10, 2008 at 08:31:49AM +0000, Christian Gmeiner wrote:
>> >
>> > Fine... more stuff is coming...
>>
>> I just did some more merges.
>> Note that the patches are not rejected, I just have not had time yet to
>> review them (especially
>> http://freehg.org/u/austriancoder/em8300-cgmeiner/rev/452d407a9ddc which
>> is non-trivial).
>
> I just had a more thorough look at 452d407a9ddc and I fal to understand
> why you do all this stuff around the pci_set_master call (check for
> PCI_COMMAND_MASTER both before and after).
> As far as U can see, most drivers that use pci_set_master don't do such
> things (although at least drivers/ide/setup-pci.c and
> drivers/media/video/ivtv/ivtv-driver.c do).
> Do you have any explanation?
>

If you want I will explain it to you, but I think my linux driver
programming book is too old :( I
had a quick look at drivers/pci/pci.c and found out, that all those
check, if our device supports
busmastering are not needed, as pci_set_master does all the hard work.
So.. I have ordered
a fresh book.

So please change the whole block to:

static int em8300_pci_setup(struct pci_dev *dev)
{
struct em8300_s *em = pci_get_drvdata(dev);
unsigned char revision;
int rc = 0;
u16 cmd;

rc = pci_enable_device(dev);
if (rc < 0) {
printk(KERN_ERR "em8300: Unable to enable PCI device\n");
return rc;
}

pci_set_master(dev);

em->adr = pci_resource_start(dev, 0);
em->memsize = pci_resource_len(dev, 0);

pci_read_config_byte(dev, PCI_CLASS_REVISION, &revision);
em->pci_revision = revision;

return 0;
}

I am sorry for this trouble, but I have learned much from it and hope
such situations will
never happen again, as I will have a look at the sources of the kernel
if I am not sure.

By the way... which kernel version do we support?

thanks
--
Christian Gmeiner, B.Sc.

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Dxr3-devel mailing list
Dxr3-devel@...
https://lists.sourceforge.net/lists/listinfo/dxr3-devel

« Return to Thread: Some development questions