Re: Spam Buttons - email resend not working properly

>
>>>>I'm trying to implement spam buttons v1.0-1.4 with SQ 1.45, using
>>>>initially the bounce feature.
>>>>
>>>>Basically, the message is bounced out, but to the original recipient
>>>> (ie
>>>>me) and not to the address specified.  I searched the mailing list and
>>>>someone reported the same problem but no solution to it since June.
>>>
>>>Yah, as I remember, he got it to "work" by uncommenting the lines
>>>starting at around line 190 of bounce_send.php.  You might want to try
>>>that.  However, I can see no reason why that would fix it, and think
>>>that that's just triggering something else that is the real problem.
>>>I'd love to track this down, but we were unsuccessful on that thread.
>>>
>>
>>
>> I tried that and uncommenting those lines fixes both the problem with
>> correctly boucing to the right address, and also the problem of not
>> overriding the smtp address as below.
>
> OMG, you are joking.  I wonder if it's a Sendmail thing.... it sees the
> message ID or similar and overrides the changes made by the plugin.  I
> am really baffled.  Can you insert this in bounce_send.php at line 301:
>
> sm_print_r($hdr_s);
>
> For reference, line 302 should look like:
>   $deliver->preWriteToStream($hdr_s);
>
> And run the plugin with the original code in place (lines commented OUT)
> as well as with your changes, put the results in a file and diff (-u)
> them and send the results?
>
>>>>So I tried to use the attachment option instead.  The message is sent
>>>> to
>>>>the correct owner, but it's not using the specified mailer.
>>>
>>>Meaning what?  You wanted to use sendmail but it used smtp?  The
>>>override SMTP address isn't being used?  Odd....
>>
>> It would not take the override email address or server.  Using sendmail
>> the message should (at least) be sent to the new address.  That wasn't
>> happening.  Or if not using sendmail, the message should go to the
>> defined
>> smtp server address.  Neither would work, and only the defaults used in
>> the main config were used.
>
> You seem to be equating "using sendmail" with using the bounce
> functionality, but I'm not sure.  However:
>
>> This is probably related to the problem above (it seems) as uncommenting
>> the lines make both problems to be fixed.  Now a message is sent out to
>> the correct address using the defined smtp server address.
>
> Now this I am very suspicious of.  If using the send-by-attachment
> functionality, the bounce_send.php file isn't even included, so
> uncommenting some lines there should not make a difference.  Maybe
> instead, the deliverMessage() function isn't correctly finding the
> overridden values.  You can try to insert the override code in that
> function at about line 1080 of functions.php, after the global statements:
>
>    global $spam_report_email_method, $spam_report_smtpServerAddress,
>           $spam_report_smtpPort, $spam_report_useSendmail,
>           $spam_report_smtp_auth_mech, $spam_report_use_smtp_tls,
>           $smtpServerAddress, $smtpPort, $useSendmail, $smtp_auth_mech,
>           $use_smtp_tls, $sb_debug;
>    include_once(SM_PATH . 'plugins/spam_buttons/config.php');
>
>
>    // take care of overrides for SMTP server
>    //
>    if (!empty($spam_report_smtpServerAddress))
>       $smtpServerAddress = $spam_report_smtpServerAddress;
>    if (!empty($spam_report_smtpPort))
>       $smtpPort = $spam_report_smtpPort;
>    if ($spam_report_useSendmail !== '')
>       $useSendmail = $spam_report_useSendmail;
>    if (!empty($spam_report_smtp_auth_mech))
>       $smtp_auth_mech = $spam_report_smtp_auth_mech;
>    if (!empty($spam_report_use_smtp_tls))
>       $use_smtp_tls = $spam_report_use_smtp_tls;
>
>
>
>> I'll help to get it fixed as much as possible...
>
> Thank you.
>
>
>>>>Relevant config.php entries:
>>>>
>>>>$sb_debug = 1;
>>>>$is_spam_resend_destination = 'spam';
>>>>$is_not_spam_resend_destination = '';
>>>>$spam_report_email_method = 'attachment';
>>>>$is_spam_subject_prefix = 'SPAM';
>>>>$is_not_spam_subject_prefix = 'HAM';
>>>>$spam_report_smtpServerAddress = 'different.server.xxx';
>>>>$spam_report_smtpPort = '25';
>>>>$spam_report_useSendmail = 'true';
>>>>$spam_report_smtp_auth_mech = '';
>>>>$spam_report_use_smtp_tls = '';
>>>>
>>>>
>>>>BTW, I am using sendmail...
>>>
>>>As in $useSendmail is turned on in your main config I take it, or your
>>>MTA *is* sendmail (sorry to hear that ;) )
>>
>>
>> Both.  Turned on in main config but also MTA *is* sendmail - I'm sorry
>> about it to... :)
>>