Re: WIP Note Directory Watcher Patch (was Watch for Changes Patch)

> Ops,
>
> Sorry :)
>
> Everaldo
>
> On Mon, Apr 27, 2009 at 12:04 PM, Sandy Armstrong
> <sanfordarmstrong@...> wrote:
>> I think Mike said he's work on that this week.  :-)
>>
>> Sandy
>>
>> On Mon, Apr 27, 2009 at 7:47 AM, Everaldo Canuto <ecanuto@...> wrote:
>>> Hey Mike,
>>>
>>> Any chance to get it working for deleted and new notes? How hard is to
>>> support delete/new ?
>>>
>>> Everaldo.
>>>
>>> On Mon, Apr 27, 2009 at 11:18 AM, Sandy Armstrong
>>> <sanfordarmstrong@...> wrote:
>>>> On Sun, Apr 26, 2009 at 12:36 PM, Michael Fletcher
>>>> <m.fletcher@...> wrote:
>>>>> This is an updated version of the Note Directory Watcher Patch.  This
>>>>> version is now useful.
>>>>>
>>>>> It can detect changes to notes in ~/.tomboy.  It CANNOT detect new
>>>>> notes or notes that have been deleted.  I will finish that tonight or
>>>>> next week.
>>>>
>>>> Nice work, Mike.  I've got some comments for you:
>>>>
>>>> * When updating a note, just use Note.LoadForeignNoteXml, and pass in
>>>> the complete file contents.  It is *probably* best to pass in
>>>> ChangeType.OtherDataChanged
>>>> * Recommend using NoteManager.FindByUri instead of doing your own loop
>>>> (it does the same thing, but could be optimized in the future).
>>>> * I'm curious about the 5 second delay.  What's the point?  To ensure
>>>> that Tomboy "wins" if a note queued to be saved also has its note file
>>>> edited?
>>>> * Shouldn't you filter on *.note?  Or are you watching all files
>>>> because of that tmp file stuff that happens when a note is saved?
>>>> * Please use the Logger class instead of Console.WriteLine
>>>> * Some coding standards stuff, like needing spaces between methods and
>>>> open parens, needing to put opening brace of method on its own line,
>>>> etc
>>>>
>>>> Will have to try it out soon.  :-)
>>>>
>>>> Sandy
>>>> _______________________________________________
>>>> Tomboy-list mailing list
>>>> Tomboy-list@...
>>>> http://lists.beatniksoftware.com/listinfo.cgi/tomboy-list-beatniksoftware.com
>>>>
>>>
>>
>
>