« Return to Thread: WSS support now full-featured; testers needed
Re: WSS support now full-featured; testers needed
by Nicolas Boullis
::
Rate this Message:
Hi,
On Sat, Oct 25, 2008 at 11:54:43AM +0300, Ville Skyttä wrote:
>
> I (finally!) got around to testing this after applying some changesets from
> the main repository to get it to compile. catting 7 and 8 to encoder/wss
> appears to work as expected, my TV does adjust the picture.
That's already good news! ;-)
> The results of this were not too good for me with a 16:9 TV with VDR, neither
> when VDR set to 4:3 nor 16:9 mode. It's quite hard to explain exactly what
> was wrong, there are a lot of settings involved (TV settings, VDR settings,
^^^^^^^^^^^
Does this mean that your TV settings change the behavior? I would have
thought that that WSS thing would override the TV settings.
Out of curiosity, what king of things can you configure on your TV?
> vdr-dxr3 settings, what the script does internally, what vdr-dxr3 does
> internally) so I won't even try at the moment because I can't remeber the
> exact problems that occurred with various settings and testing everything
> again would take hours... But anyway changing the script so that it never
> writes anything to tv_aspectratio (i.e. only writes to encoder/wss) and
> applying the attached patch to the vdr-dxr3 sources (latest on vdr-dxr3-0-2
> branch in CVS) makes things work well here.
Hmmm... that really sounds strange. There might be something I badly
misunderstood about WSS...
What is your tv_aspectratio set to? 16:9?
My understanding was that everything was expected to be fine with an
unpatched vdr-dxr3 plugin with vdr set to 4:3 and WSS disabled in the
plugin.
> I do get a bit annoyed when watching 4:3 video shown as plain 4:3 with black
> bars on the sides of the screen though, it's been a long time since I've seen
> that :).
Hmmm... Here I'm not sure I understand you correctly... Does this mean
you like broken aspect ratio: 4:3 images stretched horizontally to 16:9?
> Note to self: maybe the "force letterbox" setting of vdr-dxr3
> should be changed into a persistent config entry instead of just a menu
> toggle.
>
> Based on this (little) experience, I find the script approach a bit
> cumbersome - couldn't the driver just do the WSS thing itself if the script
> is not enabled by the module option, and outsource everything to the script
> if it is enabled?
I don't think it would be a good idea to use WSS by default on cards
with ADV7170 chips, for 2 reasons:
1) it would mean that with default configuration, cards with ADV7170
behave very differently from other cards;
2) not all TV sets understand WSS (mine does not); if it were used by
default, then aspect ratios would appear broken for users of such TV
sets.
With my code:
1) by default, everything works the same for all cards (like in main
branch);
2) one can choose his/her output aspect ratio and have black bars when
needed (better than in main branch that only supports black bars for
16:9 -> 4:3);
3) those with the needed hardware can use a specific configuration
(either WSS, or any other special setup) and let their TV do the
required scaling for a better image quality;
4) those who like distorted images can use a script that always
displays fullscreen, even with no support from the player.
As for doing this in userspace vs kernelspace, I think that most people
feel it easier to hack their own script for special needs than to hack
the module code. I think that people would be especially willing to have
some special setup if AFD could be used.
For example, if the image is 4:3 with shoot and protect 14:9 centre:
- most users with a 4:3 TV set will want to see the full image
- some users with a 16:9 TV set will want to see the full image, with
big black borders on the sides
- some users with a 16:9 TV set will want to see the image cropped to
14:9 with small black borders on the side
- some users with a 16:9 TV set may want to see the image cropped to
16:9, no matter if they loose some valuable parts of the image
- some users with a 16:9 TV set may want to see the image cropped to
16:9 and slightly distorted to display fullscreen
- some users with a 16:9 TV set may want to see the full image
distorted to display fullscreen
- anything else I could not imagine...
I don't think I can write a reasonnable list of possible setups that
would fit everyone's needs. That's why I thought that using a userspace
script was the besto solution.
Cheers,
Nicolas
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Dxr3-devel mailing list
Dxr3-devel@...
https://lists.sourceforge.net/lists/listinfo/dxr3-devel
On Sat, Oct 25, 2008 at 11:54:43AM +0300, Ville Skyttä wrote:
>
> I (finally!) got around to testing this after applying some changesets from
> the main repository to get it to compile. catting 7 and 8 to encoder/wss
> appears to work as expected, my TV does adjust the picture.
That's already good news! ;-)
> The results of this were not too good for me with a 16:9 TV with VDR, neither
> when VDR set to 4:3 nor 16:9 mode. It's quite hard to explain exactly what
> was wrong, there are a lot of settings involved (TV settings, VDR settings,
^^^^^^^^^^^
Does this mean that your TV settings change the behavior? I would have
thought that that WSS thing would override the TV settings.
Out of curiosity, what king of things can you configure on your TV?
> vdr-dxr3 settings, what the script does internally, what vdr-dxr3 does
> internally) so I won't even try at the moment because I can't remeber the
> exact problems that occurred with various settings and testing everything
> again would take hours... But anyway changing the script so that it never
> writes anything to tv_aspectratio (i.e. only writes to encoder/wss) and
> applying the attached patch to the vdr-dxr3 sources (latest on vdr-dxr3-0-2
> branch in CVS) makes things work well here.
Hmmm... that really sounds strange. There might be something I badly
misunderstood about WSS...
What is your tv_aspectratio set to? 16:9?
My understanding was that everything was expected to be fine with an
unpatched vdr-dxr3 plugin with vdr set to 4:3 and WSS disabled in the
plugin.
> I do get a bit annoyed when watching 4:3 video shown as plain 4:3 with black
> bars on the sides of the screen though, it's been a long time since I've seen
> that :).
Hmmm... Here I'm not sure I understand you correctly... Does this mean
you like broken aspect ratio: 4:3 images stretched horizontally to 16:9?
> Note to self: maybe the "force letterbox" setting of vdr-dxr3
> should be changed into a persistent config entry instead of just a menu
> toggle.
>
> Based on this (little) experience, I find the script approach a bit
> cumbersome - couldn't the driver just do the WSS thing itself if the script
> is not enabled by the module option, and outsource everything to the script
> if it is enabled?
I don't think it would be a good idea to use WSS by default on cards
with ADV7170 chips, for 2 reasons:
1) it would mean that with default configuration, cards with ADV7170
behave very differently from other cards;
2) not all TV sets understand WSS (mine does not); if it were used by
default, then aspect ratios would appear broken for users of such TV
sets.
With my code:
1) by default, everything works the same for all cards (like in main
branch);
2) one can choose his/her output aspect ratio and have black bars when
needed (better than in main branch that only supports black bars for
16:9 -> 4:3);
3) those with the needed hardware can use a specific configuration
(either WSS, or any other special setup) and let their TV do the
required scaling for a better image quality;
4) those who like distorted images can use a script that always
displays fullscreen, even with no support from the player.
As for doing this in userspace vs kernelspace, I think that most people
feel it easier to hack their own script for special needs than to hack
the module code. I think that people would be especially willing to have
some special setup if AFD could be used.
For example, if the image is 4:3 with shoot and protect 14:9 centre:
- most users with a 4:3 TV set will want to see the full image
- some users with a 16:9 TV set will want to see the full image, with
big black borders on the sides
- some users with a 16:9 TV set will want to see the image cropped to
14:9 with small black borders on the side
- some users with a 16:9 TV set may want to see the image cropped to
16:9, no matter if they loose some valuable parts of the image
- some users with a 16:9 TV set may want to see the image cropped to
16:9 and slightly distorted to display fullscreen
- some users with a 16:9 TV set may want to see the full image
distorted to display fullscreen
- anything else I could not imagine...
I don't think I can write a reasonnable list of possible setups that
would fit everyone's needs. That's why I thought that using a userspace
script was the besto solution.
Cheers,
Nicolas
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Dxr3-devel mailing list
Dxr3-devel@...
https://lists.sourceforge.net/lists/listinfo/dxr3-devel
« Return to Thread: WSS support now full-featured; testers needed
| Free embeddable forum powered by Nabble | Forum Help |
