« Return to Thread: WSS support now full-featured; testers needed
Re: WSS support now full-featured; testers needed
by Ville Skyttä
::
Rate this Message:
On Sunday 26 October 2008, Nicolas Boullis wrote:
> Does this mean that your TV settings change the behavior?
Well, yes and no.
> I would have
> thought that that WSS thing would override the TV settings.
It does to some extent. See below.
> Out of curiosity, what king of things can you configure on your TV?
The aspect ratio button toggles between "Panasonic Auto", 16:9, 14:9, "Just",
4:3, "Zoom1", "Zoom2" and "Zoom3".
IIRC "Panasonic Auto" tries to autodetect black borders around the image and
get rid of them by cropping or something when needed, 16:9 is full screen,
14:9 and 4:3 add grey bars on the sides of the image, "Just" does something
where 16:9 is displayed as is, and 4:3 is stretched to full screen so that
the stretch increases towards sides of the picture, and there's not much (if
any) at all stretching at the center. The Zoom* do some zooming but I have
never found them useful at all so I've ignored them.
WSS affects all of these modes. Some mode specific properties do stay in
effect though, such as zoom levels with Zoom* or grey bars on the sides of
the picture with 14:9 and 4:3.
> > vdr-dxr3 settings, what the script does internally, what vdr-dxr3 does
> > internally) so I won't even try at the moment because I can't remeber the
> > exact problems that occurred with various settings and testing everything
> > again would take hours... But anyway changing the script so that it
> > never writes anything to tv_aspectratio (i.e. only writes to encoder/wss)
> > and applying the attached patch to the vdr-dxr3 sources (latest on
> > vdr-dxr3-0-2 branch in CVS) makes things work well here.
>
> Hmmm... that really sounds strange. There might be something I badly
> misunderstood about WSS...
> What is your tv_aspectratio set to? 16:9?
Yes.
> My understanding was that everything was expected to be fine with an
> unpatched vdr-dxr3 plugin with vdr set to 4:3 and WSS disabled in the
> plugin.
The changes I made to vdr-dxr3 should not affect anything if VDR is set to
4:3. Before the changes, when VDR was set to 16:9, the plugin always set the
aspect to 4:3 when cDxr3Interface::SetAspectRatio was called, no matter what
the requested aspect ratio was - I don't see how that would ever be the
desired behavior. When VDR was set to 4:3, the driver was always asked to
set 16:9 or 4:3 according to what was passed to SetAspectRatio. Now it does
that no matter if VDR is set to 16:9 or 4:3 which I think makes sense. (I
haven't had WSS enabled in the dxr3 plugin in a while nor the WSS patch
applied to the drivers, so that's not a factor in these tests.)
If things Just Work with VDR configured to 4:3 mode on 16:9 setups too, that's
fine, but IMO it needs to Just Work also if VDR is configured to 16:9 mode.
I'd find it very odd if I had to configure VDR "wrong" for a 16:9 setup to
get it to work correctly...
> > I do get a bit annoyed when watching 4:3 video shown as plain 4:3 with
> > black bars on the sides of the screen though, it's been a long time since
> > I've seen that :).
>
> Hmmm... Here I'm not sure I understand you correctly... Does this mean
> you like broken aspect ratio: 4:3 images stretched horizontally to 16:9?
No, I mean that in my current setup which I described in my previous mail,
there's no stretching at all, and nothing's broken. 16:9 is full screen, 4:3
is a unstretched 4:3 area in the middle of the screen, with black bars on
left and right. But the 4:3 box is a bit annoying (or maybe "unfamiliar"
describes it better), I had got used to it being stretched to full screen
with (IIRC) the "Just" mode which did a decent job with no WSS present by
stretching 4:3 more from the sides and not at all from the center so that the
result was full width picture.
By the way, the old vdr-dxr3 WSS patch only set WSS for 16:9; for 4:3 it
turned WSS off. I don't know if it's better or worse than setting 4:3 WSS,
but I thought I'd mention it.
There are so many moving piecese that I don't know where to start... and even
some inconsistency which does not help at all but here's something. All of
these have the vdr-dxr3 patch I posted applied. For all these results I
consider 16:9 correct if it's full screen, and 4:3 correct if it's shown in a
4:3 box at the center, with thick black bars at left and right
(the "stretched" things below are relative to these assumptions). TV is set
to 16:9 all the time.
VDR set to 16:9, tv_aspect 16:9, script sets only WSS:
Consistent results, both 16:9 and 4:3 work correctly
VDR set to 4:3, tv_aspect 4:3, script sets only WSS:
Consistent results, 4:3 stretched to full screen, 16:9 has black bars at top
and bottom (I assume this would be desired with a 4:3 TV)
I thought I'd list here different things that happen with VDR set to 4:3 or
16:9 when the script sets both aspect and WSS, but they vary so wildly and I
don't find any consistent pattern (except that the picture is almost always
wrong in some way) that it makes no sense. Maybe there's some kind of a race
condition when both aspect and wss are set rapidly one after another that
makes things go south? Or maybe the dxr3 plugin when storing the internal
state of the aspect "remembers" it wrong sometimes and things start failing
from there?
I'm too confused to be able to say anything more or continue testing at this
point.
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Dxr3-devel mailing list
Dxr3-devel@...
https://lists.sourceforge.net/lists/listinfo/dxr3-devel
> Does this mean that your TV settings change the behavior?
Well, yes and no.
> I would have
> thought that that WSS thing would override the TV settings.
It does to some extent. See below.
> Out of curiosity, what king of things can you configure on your TV?
The aspect ratio button toggles between "Panasonic Auto", 16:9, 14:9, "Just",
4:3, "Zoom1", "Zoom2" and "Zoom3".
IIRC "Panasonic Auto" tries to autodetect black borders around the image and
get rid of them by cropping or something when needed, 16:9 is full screen,
14:9 and 4:3 add grey bars on the sides of the image, "Just" does something
where 16:9 is displayed as is, and 4:3 is stretched to full screen so that
the stretch increases towards sides of the picture, and there's not much (if
any) at all stretching at the center. The Zoom* do some zooming but I have
never found them useful at all so I've ignored them.
WSS affects all of these modes. Some mode specific properties do stay in
effect though, such as zoom levels with Zoom* or grey bars on the sides of
the picture with 14:9 and 4:3.
> > vdr-dxr3 settings, what the script does internally, what vdr-dxr3 does
> > internally) so I won't even try at the moment because I can't remeber the
> > exact problems that occurred with various settings and testing everything
> > again would take hours... But anyway changing the script so that it
> > never writes anything to tv_aspectratio (i.e. only writes to encoder/wss)
> > and applying the attached patch to the vdr-dxr3 sources (latest on
> > vdr-dxr3-0-2 branch in CVS) makes things work well here.
>
> Hmmm... that really sounds strange. There might be something I badly
> misunderstood about WSS...
> What is your tv_aspectratio set to? 16:9?
Yes.
> My understanding was that everything was expected to be fine with an
> unpatched vdr-dxr3 plugin with vdr set to 4:3 and WSS disabled in the
> plugin.
The changes I made to vdr-dxr3 should not affect anything if VDR is set to
4:3. Before the changes, when VDR was set to 16:9, the plugin always set the
aspect to 4:3 when cDxr3Interface::SetAspectRatio was called, no matter what
the requested aspect ratio was - I don't see how that would ever be the
desired behavior. When VDR was set to 4:3, the driver was always asked to
set 16:9 or 4:3 according to what was passed to SetAspectRatio. Now it does
that no matter if VDR is set to 16:9 or 4:3 which I think makes sense. (I
haven't had WSS enabled in the dxr3 plugin in a while nor the WSS patch
applied to the drivers, so that's not a factor in these tests.)
If things Just Work with VDR configured to 4:3 mode on 16:9 setups too, that's
fine, but IMO it needs to Just Work also if VDR is configured to 16:9 mode.
I'd find it very odd if I had to configure VDR "wrong" for a 16:9 setup to
get it to work correctly...
> > I do get a bit annoyed when watching 4:3 video shown as plain 4:3 with
> > black bars on the sides of the screen though, it's been a long time since
> > I've seen that :).
>
> Hmmm... Here I'm not sure I understand you correctly... Does this mean
> you like broken aspect ratio: 4:3 images stretched horizontally to 16:9?
No, I mean that in my current setup which I described in my previous mail,
there's no stretching at all, and nothing's broken. 16:9 is full screen, 4:3
is a unstretched 4:3 area in the middle of the screen, with black bars on
left and right. But the 4:3 box is a bit annoying (or maybe "unfamiliar"
describes it better), I had got used to it being stretched to full screen
with (IIRC) the "Just" mode which did a decent job with no WSS present by
stretching 4:3 more from the sides and not at all from the center so that the
result was full width picture.
By the way, the old vdr-dxr3 WSS patch only set WSS for 16:9; for 4:3 it
turned WSS off. I don't know if it's better or worse than setting 4:3 WSS,
but I thought I'd mention it.
There are so many moving piecese that I don't know where to start... and even
some inconsistency which does not help at all but here's something. All of
these have the vdr-dxr3 patch I posted applied. For all these results I
consider 16:9 correct if it's full screen, and 4:3 correct if it's shown in a
4:3 box at the center, with thick black bars at left and right
(the "stretched" things below are relative to these assumptions). TV is set
to 16:9 all the time.
VDR set to 16:9, tv_aspect 16:9, script sets only WSS:
Consistent results, both 16:9 and 4:3 work correctly
VDR set to 4:3, tv_aspect 4:3, script sets only WSS:
Consistent results, 4:3 stretched to full screen, 16:9 has black bars at top
and bottom (I assume this would be desired with a 4:3 TV)
I thought I'd list here different things that happen with VDR set to 4:3 or
16:9 when the script sets both aspect and WSS, but they vary so wildly and I
don't find any consistent pattern (except that the picture is almost always
wrong in some way) that it makes no sense. Maybe there's some kind of a race
condition when both aspect and wss are set rapidly one after another that
makes things go south? Or maybe the dxr3 plugin when storing the internal
state of the aspect "remembers" it wrong sometimes and things start failing
from there?
I'm too confused to be able to say anything more or continue testing at this
point.
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Dxr3-devel mailing list
Dxr3-devel@...
https://lists.sourceforge.net/lists/listinfo/dxr3-devel
« Return to Thread: WSS support now full-featured; testers needed
| Free embeddable forum powered by Nabble | Forum Help |
