I checked the codes of ConfirmMessageTag, its main purpose is to import Dojo js file and some styles for showing Dojo box.
1. When dojo is not installed, I do not think the confirm box could work. For the showConfirmMessage function uses some Dojo components.
2. The name seems not conformable with its function. I agree that we should change it to be more valid.
Ivan
2009/6/30 Jarek Gawor
<jgawor@...>
Hi,
While debugging the console testsuites I realized that the admin
console was no longer prompting when uninstalling a given module (or
stopping or restarting). I tracked down the problem to
ConfirmMessageTag.java where it was pointing to wrong locations for
Dojo resources. Now, I have a few of questions about this
ConfirmMessageTag that I'm hoping somebody will be able to answer:
1) Is it necessary for ConfirmMessageTag to use Dojo? Or at least can
we make it so that it still works (displays prompts) when Dojo is not
installed?
2) The ConfirmMessageTag injects a <style/> element into the page body
(within <body/>). But from what I can tell (and I checked this with
jslint) the <style/> elements only should appear within the <head/>
element. Things seems to work the way they are now but I'm wondering
if we should change this to be more valid.
Jarek
--
Ivan
