Re: best place to discuss oxygen style?

View: New views
3 Messages — Rating Filter:   Alert me  

Parent Message unknown Re: best place to discuss oxygen style?

by Matthew Woehlke-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Nuno Pinheiro wrote:

> Aaron J. Seigo wrote:
>> Matthew Woehlke wrote:
>>> I notice that the options for menu highlight type and checkboxes using
>>> 'x' instead of check (which were previously hidden) have disappeared. I
>>> don't know if this was by intent, or private mods I never committed,
>>> but in either case, I'd like to get them back into oxygen.cpp (and in
>>> trunk, if they weren't previously), with GUI configuration (since we
>>> are not in string freeze ATM).
>
> sure completely ok thing i personally heaven prefer the x dough the v grew on
> me
:-)

>> these seem to be aesthetic issues; i'd discuss them with Pinheiro first
>> and then go ahead and do the coding work as long as he's Ok with the
>> results. as non-default options, i'd expect the only concern would be
>> that they blend well with the rest of the theme elements.
>
> yeah im prety sure there was a mock for that check box, think you have that
> one mathew...

Not only a mock, the code is still there; the way the options are read
got changed without me noticing until I started poking around. So /I/
have my 'x's back, but there is no UI for them. Thus, that is the next task.

For those following along, attached is a screenshot of the current .ui I
have made; for bonus points you can see the checkbox 'x's :-).

--
Matthew
Please do not quote my e-mail address unobfuscated in message bodies.
--
.sig hazy, try again later.


______________________________________________________________________________
kde-artists@... |  https://mail.kde.org/mailman/listinfo/kde-artists

style-config-ui2.jpeg (26K) Download Attachment

Re: best place to discuss oxygen style?

by Bugzilla from nuno@oxygen-icons.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

A Sexta, 31 de Julho de 2009 20:03:30 Matthew Woehlke você escreveu:

> Nuno Pinheiro wrote:
> > Aaron J. Seigo wrote:
> >> Matthew Woehlke wrote:
> >>> I notice that the options for menu highlight type and checkboxes using
> >>> 'x' instead of check (which were previously hidden) have disappeared. I
> >>> don't know if this was by intent, or private mods I never committed,
> >>> but in either case, I'd like to get them back into oxygen.cpp (and in
> >>> trunk, if they weren't previously), with GUI configuration (since we
> >>> are not in string freeze ATM).
> >
> > sure completely ok thing i personally heaven prefer the x dough the v
> > grew on me
> >
> :-)
> :
> >> these seem to be aesthetic issues; i'd discuss them with Pinheiro first
> >> and then go ahead and do the coding work as long as he's Ok with the
> >> results. as non-default options, i'd expect the only concern would be
> >> that they blend well with the rest of the theme elements.
> >
> > yeah im prety sure there was a mock for that check box, think you have
> > that one mathew...
>
> Not only a mock, the code is still there; the way the options are read
> got changed without me noticing until I started poking around. So /I/
> have my 'x's back, but there is no UI for them. Thus, that is the next
> task.
>
> For those following along, attached is a screenshot of the current .ui I
> have made; for bonus points you can see the checkbox 'x's :-).
>
> --
> Matthew
> Please do not quote my e-mail address unobfuscated in message bodies.

From my POV. ship it

--
Oxygen coordinator  
______________________________________________________________________________
kde-artists@... |  https://mail.kde.org/mailman/listinfo/kde-artists

Re: best place to discuss oxygen style?

by Matthew Woehlke-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Nuno Pinheiro wrote:
> A Sexta, 31 de Julho de 2009 20:03:30 Matthew Woehlke voc� escreveu:
>> For those following along, attached is a screenshot of the current .ui I
>> have made; for bonus points you can see the checkbox 'x's :-).
>
> From my POV. ship it

Thanks. Making the code use the .ui turned out to be less painful than I
was afraid it might be. The review request, in case you want to take a
look (probably not, it's C++ ;-) ), is here:
http://reviewboard.kde.org/r/1196/

--
Matthew
Please do not quote my e-mail address unobfuscated in message bodies.
--
.sig hazy, try again later.

______________________________________________________________________________
kde-artists@... |  https://mail.kde.org/mailman/listinfo/kde-artists