Re: crypt32.dll: Initialize provider pointer to null before calling CryptAcquireContextW()

[Juan Lang-4]

Hi Paul,

I imagine this is to avoid checking prov if CryptAcquireContextW
fails.  In that case, wouldn't it be better to check the return value
of CryptAcquireContextW?
--Juan

[Paul Chitescu]

On Wednesday 04 November 2009 11:45:38 pm Juan Lang wrote:
> Hi Paul,
>
> I imagine this is to avoid checking prov if CryptAcquireContextW
> fails.  In that case, wouldn't it be better to check the return value
> of CryptAcquireContextW?
> --Juan

Checking the return value of CryptAcquireContextW() is also possible but I
took the path of minimal change in the source.

Besides, I consider passing pointers to uninitialized variables a bad
programming practice.

Paul

[Juan Lang-4]

> Checking the return value of CryptAcquireContextW() is also possible but I
> took the path of minimal change in the source.

The change I suggest would be small too.

> Besides, I consider passing pointers to uninitialized variables a bad
> programming practice.

Not when they're out pointers.
--Juan