« Return to Thread: devutils -- A child with id 'debug' already exists
Re: devutils -- A child with id 'debug' already exists
by Max Bowsher-5
::
Rate this Message:
Martijn Dashorst wrote:
> On Sun, May 31, 2009 at 10:48 AM, Max Bowsher <maxb@...> wrote:
>> DevUtilsPage is modifying the component hierarchy in onBeforeRender,
>> which is not allowed IIUC.
>
> You're remembering it wrong: in yea old days you weren't allowed to
> modify component hierarchy in onAttach(). modifying component
> hierarchy in onbeforerender is perfectly allowed, and the only option
> to modify the hierarchy once a page has been rendered.
Ah, ok. Thanks for the clarification. However, it must still be wrong to
do things in onBeforeRender() which are just basic setting up of the
component tree to match the markup, and make no sense to redo every
render, so I think my previous patch is still correct.
Max.
> On Sun, May 31, 2009 at 10:48 AM, Max Bowsher <maxb@...> wrote:
>> DevUtilsPage is modifying the component hierarchy in onBeforeRender,
>> which is not allowed IIUC.
>
> You're remembering it wrong: in yea old days you weren't allowed to
> modify component hierarchy in onAttach(). modifying component
> hierarchy in onbeforerender is perfectly allowed, and the only option
> to modify the hierarchy once a page has been rendered.
Ah, ok. Thanks for the clarification. However, it must still be wrong to
do things in onBeforeRender() which are just basic setting up of the
component tree to match the markup, and make no sense to redo every
render, so I think my previous patch is still correct.
Max.
signature.asc (204 bytes) « Return to Thread: devutils -- A child with id 'debug' already exists
| Free embeddable forum powered by Nabble | Forum Help |
