« Return to Thread: financial summary in khomeview kde4 version

Re: financial summary in khomeview kde4 version

by Bugzilla from asoliverez@gmail.com :: Rate this Message:

Reply to Author | View in Thread



On Wed, Jul 1, 2009 at 5:05 PM, Cristian Oneţ <onet.cristian@...> wrote:
Hi,

This is about the porting to kde4, kmymoney CVS is not involved :).

As you know the "Financial summary" page in khomeview is messed up. First I
taught that maybe a write was not properly called on the KHTML part but after
a bit of investigating I came to conclude that in fact the KHTML part can't
handle calls to write with so small bits of html data. So attached is a patch
that buffers the html into a QString and calls write once.
According to the api this approach would improve the speed of the part:
"Writes another part of the HTML code to the widget.
 You may call this function many times in sequence. But remember: The fewer
calls you make, the faster the widget will be."

What do you think? Should we go this way or try to investigate what changed
under the hood of the KHTML part?

Since the implementation of the KHTMLPart::write method did not change between
3.5 and 4.2 than the problem must be in the underlying document or tokenizer
who knows...

--
Regards,

Cristian Oneţ

------------------------------------------------------------------------------

 
Since the KHtmlPart recommendation is to avoid calling the write method so many times, I think it is a good solution to set a QString first and then call the write method once. However, we should try to make the KHTML developers aware of this bug. Can you log it in Bugzilla, or should I?

Thanks!

Regards,
Alvaro

------------------------------------------------------------------------------

_______________________________________________
KMyMoney2-developer mailing list
KMyMoney2-developer@...
https://lists.sourceforge.net/lists/listinfo/kmymoney2-developer

 « Return to Thread: financial summary in khomeview kde4 version