Re: i2c changes in 2.6.15+
On Thu, 2006-01-26 at 19:53 +0100, Nicolas Boullis wrote:
> On Thu, Jan 26, 2006 at 08:55:22AM +0200, Ville Skyttä wrote:
> >
> > With this patch, EM8300_I2C_FORCE_OLD_API does not seem to do anything
> > any more, so modules/Makefile could be tweaked accordingly.
>
> You're quite right. A patch would be welcome. (Me? Lazy? ;-) )
Well, I don't even know what the NEW API exactly stands for, but in any
case I think it would suffice to just adjust the commentary so that it
no longer advertises values != NEW having any effect (and mention that
in ChangeLog too). No need to purge the Makefile logic as it may come
in handy later again. Maybe just something like the attached patch?
[em8300-i2c-Makefile.patch]
Index: Makefile
===================================================================
RCS file: /cvsroot/dxr3/em8300/modules/Makefile,v
retrieving revision 1.72
diff -u -U1 -r1.72 Makefile
--- Makefile 25 Jan 2006 22:00:40 -0000 1.72
+++ Makefile 26 Jan 2006 20:01:15 -0000
@@ -26,3 +26,3 @@
# Moreover, if the API of the modules is not properly guessed, you can
-# force it by setting EM8300_I2C_FORCE_API to OLD or NEW. (That is
+# force it by setting EM8300_I2C_FORCE_API to NEW. (That is
# especially for using 2.8.x modules with 2.4.x kernels.)