Re: kern/140251: [ata] [patch] add UDMA5 support to Intel SCH

[tharada]

The following reply was made to PR kern/140251; it has been noted by GNATS.

From: Tomokazu HARADA <tharada@...>
To: bug-followup@...
Cc: tharada@...
Subject: Re: kern/140251: [ata] [patch] add UDMA5 support to Intel SCH
Date: Wed, 04 Nov 2009 20:39:29 +0900 (JST)

 Previous patch is broken. Needs additional patch
 
 --- ata-intel.c- 2009-11-04 00:38:25.000000000 +0900
 +++ ata-intel.c 2009-11-04 20:36:01.000000000 +0900
 @@ -394,14 +394,17 @@
      if (!error) {
  if (mode >= ATA_UDMA0) {
     tim |= (0x1 << 31);
 +    tim &= ~(0x7 << 16);
     tim |= ((mode & ATA_MODE_MASK) << 16);
  }
  else if (mode >= ATA_WDMA0) {
     tim &= ~(0x1 << 31);
 +    tim &= ~(0x3 << 8);
     tim |= ((mode & ATA_MODE_MASK) << 8);
  }
  else if (mode >= ATA_PIO0) {
 -    tim |= (mode - ATA_PIO0);
 +    tim &= ~(0x7);
 +    tim |= (mode & 0x7);
  }
 
  pci_write_config(gparent, dtim, tim, 4);
 
 -----
 Tomokazu HARADA
_______________________________________________
freebsd-bugs@... mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscribe@..."