Re: kernel32/tests: add more tests for Formatmessage{A,W} (try 2)

[Paul Vriens-2]

On 10/29/2009 01:09 AM, Louis Lenders wrote:
> changes:
>
> -fixed typo in ok-call
> -removed FormatMessageW-tests (W behaves same as A)
> -removed useless test for GetLastError in case FormatMessageA succeeds
>
>

Hi Louis,

These new tests introduce some test failures on several platforms:

http://test.winehq.org/data/tests/kernel32:format_msg.html

On Win9x/WinMe it seems like just another last error.

There seems to be an issue with a particular test when run on a Windows
box with no English locale (or something different about the locale):

http://test.winehq.org/data/1be99033b1892aa59589e7997f4c5a0ce77e2b42/2000_w2k-sp4-fr/kernel32:format_msg.html

On Vista/Win7/W2K8 there are also different last errors but some are not
yet defined in our headers:

15100 : ERROR_MUI_FILE_NOT_FOUND
15105 : ERROR_MUI_FILE_NOT_LOADED

Could you have a look?

--
Cheers,

Paul.

[Nicolas Le Cam]

2009/10/30 Paul Vriens <paul.vriens.wine@...>:

> On 10/29/2009 01:09 AM, Louis Lenders wrote:
>>
>> changes:
>>
>> -fixed typo in ok-call
>> -removed FormatMessageW-tests (W behaves same as A)
>> -removed useless test for GetLastError in case FormatMessageA succeeds
>>
>>
>
> Hi Louis,
>
> These new tests introduce some test failures on several platforms:
>
> http://test.winehq.org/data/tests/kernel32:format_msg.html
>
> On Win9x/WinMe it seems like just another last error.
>
> There seems to be an issue with a particular test when run on a Windows box
> with no English locale (or something different about the locale):
>
> http://test.winehq.org/data/1be99033b1892aa59589e7997f4c5a0ce77e2b42/2000_w2k-sp4-fr/kernel32:format_msg.html
>
> On Vista/Win7/W2K8 there are also different last errors but some are not yet
> defined in our headers:
>
> 15100 : ERROR_MUI_FILE_NOT_FOUND
> 15105 : ERROR_MUI_FILE_NOT_LOADED
>
> Could you have a look?
>
> --
> Cheers,
>
> Paul.
>
>
>

w2k-sp4-fr has French locale. I didn't have time to investigate right
now but if you need more tests just ask.


--
Nicolas Le Cam

[Louis. Lenders]

Hi Louis,

These new tests introduce some test failures on several platforms:

http://test.winehq.org/data/tests/kernel32:format_msg.html

On Win9x/WinMe it seems like just another last error.

There seems to be an issue with a particular test when run on a Windows
box with no English locale (or something different about the locale):

http://test.winehq.org/data/1be99033b1892aa59589e7997f4c5a0ce77e2b42/2000_w2k-sp4-fr/kernel32:format_msg.html

On Vista/Win7/W2K8 there are also different last errors but some are not
yet defined in our headers:

15100 : ERROR_MUI_FILE_NOT_FOUND
15105 : ERROR_MUI_FILE_NOT_LOADED

Could you have a look?



I'll have a look , but probably not today, but in weekend. Regards