Re: koffice/krita/ui/tool

On Saturday 7. November 2009 13.33.05 Boudewijn Rempt wrote:
> SVN commit 1046077 by rempt:
>
> Add color picker and pan mode to freehand tools
>
> The freehand tools now have the following extra features:
>
>  * press space: start pan mode. Pan mode takes until mouse release,
>    it's not necessar to keep space pressed (though it doesn't hurt
>    either).

Can this use the koffice-wide pan tool, temporary activated?

This would have as a direct benefit that it would work for all usage in krita
and in koffice and also have the same interaction everywhere.

I gave a patch to enkithan for flake some time ago to do something like this,
I can send it when I am back home, in a week or so.
--
Thomas Zander
_______________________________________________
koffice-devel mailing list
koffice-devel@...
https://mail.kde.org/mailman/listinfo/koffice-devel

On Saturday 7. November 2009 20.43.47 Thomas Zander wrote:
> I gave a patch to enkithan for flake some time ago to do something like
> this, I can send it when I am back home, in a week or so.

Actually realized I exported the patch and threw it in my homedir, so for
the impatient ;)

the interaction is different, I guess it will not be hard to change it to be
better. I really have no opinion on how it should be have. (other than the
wish of it being the same everywhere in koffice)

--
Thomas Zander

[0001-Make-pressing-space-temporarily-switch-to-the-pan-to.patch]

---

From 0b3b9d525a2410634580a1a7329f5354a6aa4d86 Mon Sep 17 00:00:00 2001
From: Thomas Zander <zander@...>
Date: Fri, 11 Sep 2009 16:29:35 +0200
Subject: [PATCH] Make pressing space temporarily switch to the pan tool

---
 libs/flake/KoToolManager.cpp |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/libs/flake/KoToolManager.cpp b/libs/flake/KoToolManager.cpp
index 6582a2a..17caf15 100644
--- a/libs/flake/KoToolManager.cpp
+++ b/libs/flake/KoToolManager.cpp
@@ -678,8 +678,12 @@ void KoToolManager::switchToolByShortcut(QKeyEvent *event)
         if (th->shortcut().contains(item)) {
             event->accept();
             switchTool(th->id(), false);
+            return;
         }
     }
+    if (event->key() == Qt::Key_Space && event->modifiers() == 0) {
+        switchTool(KoPanTool_ID, true);
+    }
 }
 
 QString KoToolManager::preferredToolForSelection(const QList<KoShape*> &shapes)
--
1.6.0.4

---

_______________________________________________
koffice-devel mailing list
koffice-devel@...
https://mail.kde.org/mailman/listinfo/koffice-devel

On Saturday 07 November 2009, Thomas Zander wrote:

> On Saturday 7. November 2009 20.43.47 Thomas Zander wrote:
> > I gave a patch to enkithan for flake some time ago to do something like
> > this, I can send it when I am back home, in a week or so.
>
> Actually realized I exported the patch and threw it in my homedir, so for
> the impatient ;)
>
> the interaction is different, I guess it will not be hard to change it to
>  be better. I really have no opinion on how it should be have. (other than
>  the wish of it being the same everywhere in koffice)

I'm not sure how easy it would be -- nor am I really sure that every tool
should have the same pan interaction.

For the freehand paint tool, the interaction is rather subtle: you can press
space, then click and start panning, while the option widget doesn't change,
and as soon as you release the mouse, you can paint. Or you can keep the
spacebar down, like in Photoshop, and keep panning with many short strokes.

--
Boudewijn Rempt | http://www.valdyas.org
_______________________________________________
koffice-devel mailing list
koffice-devel@...
https://mail.kde.org/mailman/listinfo/koffice-devel

On Saturday 7. November 2009 21.15.59 Boudewijn Rempt wrote:

> On Saturday 07 November 2009, Thomas Zander wrote:
> > On Saturday 7. November 2009 20.43.47 Thomas Zander wrote:
> > > I gave a patch to enkithan for flake some time ago to do something
> > > like this, I can send it when I am back home, in a week or so.
> >
> > Actually realized I exported the patch and threw it in my homedir, so
> > for the impatient ;)
> >
> > the interaction is different, I guess it will not be hard to change it
> > to be better. I really have no opinion on how it should be have. (other
> > than the wish of it being the same everywhere in koffice)
>
> I'm not sure how easy it would be -- nor am I really sure that every tool
> should have the same pan interaction.
>
> For the freehand paint tool, the interaction is rather subtle: you can
> press space, then click and start panning, while the option widget
> doesn't change, and as soon as you release the mouse, you can paint. Or
> you can keep the spacebar down, like in Photoshop, and keep panning

with
> many short strokes.

The pan interaction as you describe it is the only reason for the existence
of the 'temporary' feature in activating a shape.
If it doesn't work right now, we should be able to make it work. :)

All the hard work of this interaction you describe can be done in the pan
tool, so in principle that should work.
--
Thomas Zander
_______________________________________________
koffice-devel mailing list
koffice-devel@...
https://mail.kde.org/mailman/listinfo/koffice-devel