Re: lib/42273 (SHA512_CTX struct not properly aligned)

[Joerg Sonnenberger-2]

Synopsis: SHA512_CTX struct not properly aligned

State-Changed-From-To: open->analyzed
State-Changed-By: joerg@...
State-Changed-When: Fri, 06 Nov 2009 20:44:55 +0000
State-Changed-Why:
A fix was commited to HEAD. Needs further testing, pullups and a regression
test.

[Martin Husemann]

On Fri, Nov 06, 2009 at 08:44:56PM +0000, joerg@... wrote:
> A fix was commited to HEAD. Needs further testing, pullups and a regression
> test.

You didn't fix the identical problem in the other SHA*_Final() functions.

Martin

[Martin Husemann]

The following reply was made to PR lib/42273; it has been noted by GNATS.

From: Martin Husemann <martin@...>
To: gnats-bugs@...
Cc: joerg@..., netbsd-bugs@..., gnats-admin@...,
        jon@...
Subject: Re: lib/42273 (SHA512_CTX struct not properly aligned)
Date: Sat, 7 Nov 2009 20:59:09 +0100

 On Fri, Nov 06, 2009 at 08:44:56PM +0000, joerg@... wrote:
 > A fix was commited to HEAD. Needs further testing, pullups and a regression
 > test.
 
 You didn't fix the identical problem in the other SHA*_Final() functions.
 
 Martin
 

[Jon Buller]

joerg@... wrote:

> A fix was commited to HEAD. Needs further testing, pullups and a regression
> test.

I have finally(!) been able to get the old, slow, sparc system to
rebuild and
test this.  Both download-vulnerability-list (which runs pkg_admin which
uses
SHA512_Final in a core causing way) and the test program included in the PR
both produce valid results now.  Thanks Joerg!

Jon