Re: method for Crypt_GPG to sign and encrypt file in one pass

View: New views
2 Messages — Rating Filter:   Alert me  

Parent Message unknown Re: method for Crypt_GPG to sign and encrypt file in one pass

by Michael Gauthier :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Thu, 2009-11-12 at 12:32 +0000, Ken Guest wrote:

> hi Mike,
> patch attached for signing and encrypting a file in one pass with
> Crypt_GPG - something that's required here immediately so I
> went ahead and added it to a local install of the package. Didn't
> really have the time to file a feature request or anything like that.
>
> Thought you might want to look over it and perhaps incorporate it into
> the public version of Crypt_GPG.
>
>
Ken,

I cleaned up and applied your patch in changeset 290586. See:

http://svn.php.net/viewvc/pear/packages/Crypt_GPG/trunk/Crypt/GPG.php?r1=290586&r2=290585&pathrev=290586&diff_format=u

The biggest change I made was the method name. I chose encryptAndSign()
instead of signAndEncrypt() because it matches the GnuPG APIs of other
languages better.

The change will be in the next public release of Crypt_GPG, which will
happen after I write new tests for the new features in trunk.

Regards,


Mike


--
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php


Re: method for Crypt_GPG to sign and encrypt file in one pass

by Ken Guest :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Looks good - mine was an urgently required hack :(

k.

On Thu, Nov 12, 2009 at 3:38 PM, Michael Gauthier <mike@...> wrote:

> On Thu, 2009-11-12 at 12:32 +0000, Ken Guest wrote:
>> hi Mike,
>> patch attached for signing and encrypting a file in one pass with
>> Crypt_GPG - something that's required here immediately so I
>> went ahead and added it to a local install of the package. Didn't
>> really have the time to file a feature request or anything like that.
>>
>> Thought you might want to look over it and perhaps incorporate it into
>> the public version of Crypt_GPG.
>>
>>
> Ken,
>
> I cleaned up and applied your patch in changeset 290586. See:
>
> http://svn.php.net/viewvc/pear/packages/Crypt_GPG/trunk/Crypt/GPG.php?r1=290586&r2=290585&pathrev=290586&diff_format=u
>
> The biggest change I made was the method name. I chose encryptAndSign()
> instead of signAndEncrypt() because it matches the GnuPG APIs of other
> languages better.
>
> The change will be in the next public release of Crypt_GPG, which will
> happen after I write new tests for the new features in trunk.
>
> Regards,
>
>
> Mike
>
>



--
http://blogs.linux.ie/kenguest/

--
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php