« Return to Thread: osync_xmlformat_validate() in format plugins

Re: osync_xmlformat_validate() in format plugins

by Daniel Gollub :: Rate this Message:

On Wednesday 09 July 2008 20:21:55 Bjoern Ricks wrote:
> Now there is only the additional test coding left for me to close ticket
> #753.

Nice!

Tip: if you change the CMAKE_BUILD_TYPE to Profiling then you will get code
coverage results. Just run the coverage.sh script in the tests directory. Or
run make Experimental and check http://opensync.org/testing for the coverage
results for your tests and file you want to test.

Let me know if you have further question on this ....

See some additional comments on your code....

> --
> /Bjoern Ricks
>
> Index: opensync/opensync-xmlformat.h
> ===================================================================
> --- opensync/opensync-xmlformat.h (Revision 3426)
> +++ opensync/opensync-xmlformat.h (Arbeitskopie)
> @@ -24,6 +24,7 @@
> OPENSYNC_BEGIN_DECLS
>
> #include "xmlformat/opensync_xmlformat.h"
> +#include "xmlformat/opensync_xmlformat_schema.h"
> #include "xmlformat/opensync_xmlfield.h"
> #include "xmlformat/opensync_xmlfieldlist.h"
>
> Index: opensync/xmlformat/opensync_xmlformat.c
> ===================================================================
> --- opensync/xmlformat/opensync_xmlformat.c (Revision 3426)
> +++ opensync/xmlformat/opensync_xmlformat.c (Arbeitskopie)
> @@ -97,6 +97,7 @@
> * @param path The individual schema path. If NULL the default
> OPENSYNC_SCHEMASDIR is used. * @return TRUE if xmlformat valid else FALSE
> */
> +/*
> osync_bool _osync_xmlformat_validate(OSyncXMLFormat *xmlformat, const char
> *path) {
> osync_assert(xmlformat);
> @@ -111,7 +112,7 @@
> g_free(schemafilepath);
>
> return res;
> -}
> +} */

Deadcode ... just remove it.

[...]

>
> /**
> Index: opensync/xmlformat/opensync_xmlformat_schema.c
> ===================================================================
> --- opensync/xmlformat/opensync_xmlformat_schema.c (Revision 0)
> +++ opensync/xmlformat/opensync_xmlformat_schema.c (Revision 0)
> @@ -0,0 +1,198 @@
> +/*
> + * libopensync - A synchronization framework
> + * Copyright (C) 2006 NetNix Finland Ltd <netnix@...>

It's your code - isn't it? I guess thats just copy&paste mistake...
(Or did you got already offered contracting work? Hire Bjoern! ;))

> + *
> + * This library is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2.1 of the License, or (at your option) any later version.
> + *
> + * This library is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + * Lesser General Public License for more details.
> + *
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with this library; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307
> USA + *
> + * Author: Bjoern Ricks <bjoern.ricks@...>
> + *
> + */

-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
_______________________________________________
Opensync-devel mailing list
Opensync-devel@...
https://lists.sourceforge.net/lists/listinfo/opensync-devel

« Return to Thread: osync_xmlformat_validate() in format plugins