« Return to Thread: Re: pidgin: b05f9366: Password reenter prompt only for account...

Re: pidgin: b05f9366: Password reenter prompt only for account...

by Paul Aurich-4 :: Rate this Message:

Reply (Restricted by the Administrator) | Reply to Author | View in Thread

And sulabh@... spoke on 07/03/2009 04:50 AM, saying:

> -----------------------------------------------------------------
> Revision: b05f93669b412dc123c17699c1c394cb2f30673d
> Ancestor: 1d57dde9d15fd79af85e8a28d21680c4a1b6be2b
> Author: sulabh@...
> Date: 2009-07-03T11:43:15
> Branch: im.pidgin.pidgin
> URL: http://d.pidgin.im/viewmtn/revision/info/b05f93669b412dc123c17699c1c394cb2f30673d
>
> Modified files:
>         libpurple/protocols/yahoo/yahoo.c
>
> ChangeLog:
>
> Password reenter prompt only for accounts where password storing is enabled. More consistent with other accounts.
> Fix #9603
>
>
>
> ------------------------------------------------------------------------
>
> ============================================================
> --- libpurple/protocols/yahoo/yahoo.c 601388d98bb68f64ef08e3e4886829206a703f5a
> +++ libpurple/protocols/yahoo/yahoo.c 8e8e0865c37c599ef73597cf0e872a9030379cfa
> @@ -1792,7 +1792,8 @@ static void yahoo_auth16_stage1_cb(Purpl
>   case 1212:
>   /* Password incorrect */
>   /* Set password to NULL. Avoids account locking. Brings dialog to enter password if clicked on Re-enable account */
> - purple_account_set_password(purple_connection_get_account(gc), NULL);
> + if (purple_account_get_remember_password(purple_connection_get_account(gc)))
> + purple_account_set_password(purple_connection_get_account(gc), NULL);
>   error_reason = g_strdup(_("Incorrect Password"));
>   error = PURPLE_CONNECTION_ERROR_AUTHENTICATION_FAILED;
>   break;

This is, I believe, the opposite of what other protocols do. Certainly both
 XMPP and AIM/ICQ have the purple_account_get_remember_password() check
inverted.

~Paul

_______________________________________________
Devel mailing list
Devel@...
http://pidgin.im/cgi-bin/mailman/listinfo/devel

 « Return to Thread: Re: pidgin: b05f9366: Password reenter prompt only for account...