Re: pkg/42278 (print/acroread8 PLIST problems (file-check test))

[Thomas Klausner-3]

Synopsis: print/acroread8 PLIST problems (file-check test)

Responsible-Changed-From-To: pkg-manager->tez
Responsible-Changed-By: wiz@...
Responsible-Changed-When: Sat, 07 Nov 2009 08:13:57 +0000
Responsible-Changed-Why:
Over to updater.

[tez-8]

Please try this patch and see if it resolves your issue (the missing
filenames are in PLIST.Linux already, so this should cause them to be
included.)

Index: Makefile
===================================================================
RCS file: /usr/cvs/pkgsrc/print/acroread8/Makefile,v
retrieving revision 1.9
diff -w -u -b -r1.9 Makefile
--- Makefile    4 Nov 2009 23:37:53 -0000       1.9
+++ Makefile    9 Nov 2009 13:11:36 -0000
@@ -37,6 +37,7 @@
 .if ${EMUL_PLATFORM} == "linux-i386"
 DISTNAME=      AdobeReader_enu-8.1.7-1.i486
 PLATFORM=      intellinux
+PLIST_SRC+=    PLIST.Linux
 .elif ${EMUL_PLATFORM} == "solaris-sparc"
 DISTNAME=      AdobeReader_enu-8.1.7-1.sparc
 PLATFORM=      sparcsolaris

[tez-8]

The following reply was made to PR pkg/42278; it has been noted by GNATS.

From: Tim Zingelman <tez@...>
To: gnats-bugs@...
Cc: pkg-manager@..., pkgsrc-bugs@..., gnats-admin@...,
        kre@...
Subject: Re: pkg/42278 (print/acroread8 PLIST problems (file-check test))
Date: Mon, 9 Nov 2009 07:13:33 -0600

 Please try this patch and see if it resolves your issue (the missing
 filenames are in PLIST.Linux already, so this should cause them to be
 included.)
 
 Index: Makefile
 ===================================================================
 RCS file: /usr/cvs/pkgsrc/print/acroread8/Makefile,v
 retrieving revision 1.9
 diff -w -u -b -r1.9 Makefile
 --- Makefile    4 Nov 2009 23:37:53 -0000       1.9
 +++ Makefile    9 Nov 2009 13:11:36 -0000
 @@ -37,6 +37,7 @@
  .if ${EMUL_PLATFORM} == "linux-i386"
  DISTNAME=      AdobeReader_enu-8.1.7-1.i486
  PLATFORM=      intellinux
 +PLIST_SRC+=    PLIST.Linux
  .elif ${EMUL_PLATFORM} == "solaris-sparc"
  DISTNAME=      AdobeReader_enu-8.1.7-1.sparc
  PLATFORM=      sparcsolaris
 

[asau-2]

Synopsis: print/acroread8 PLIST problems (file-check test)

State-Changed-From-To: open->feedback
State-Changed-By: asau@...
State-Changed-When: Mon, 09 Nov 2009 14:24:27 +0000
State-Changed-Why:
Question was asked.

[Robert Elz]

    Date:        Mon, 9 Nov 2009 07:13:33 -0600
    From:        Tim Zingelman <tez@...>
    Message-ID:  <f66ce35c0911090513t69dbfefewade74d55fb81708f@...>

  | Please try this patch and see if it resolves your issue (the missing
  | filenames are in PLIST.Linux already, so this should cause them to be
  | included.)

Thanks, it does, but unfortunately, setting PLIST_SRC (even with +=)
caused the default value for it to be ignored... so the effect was to
invert the set of PLIST problems - all the errors from before went away,
but every other file was now missing from the PLIST.

The patch below seems to work though, but I'm not sure if this is the
best way to do it.

kre

Index: Makefile
===================================================================
RCS file: /cvsroot/NetBSD/pkgsrc/print/acroread8/Makefile,v
retrieving revision 1.9
diff -u -r1.9 Makefile
--- Makefile 4 Nov 2009 23:37:53 -0000 1.9
+++ Makefile 9 Nov 2009 14:46:08 -0000
@@ -32,11 +32,14 @@
 EMUL_MODULES.linux= compat cups gtk2 locale
 EMUL_REQD= suse>=10.0
 
+PLIST_SRC=             ${PLIST_SRC_DFLT}
+
 .include "../../mk/bsd.prefs.mk"
 
 .if ${EMUL_PLATFORM} == "linux-i386"
 DISTNAME= AdobeReader_enu-8.1.7-1.i486
 PLATFORM= intellinux
+PLIST_SRC+= PLIST.Linux
 .elif ${EMUL_PLATFORM} == "solaris-sparc"
 DISTNAME= AdobeReader_enu-8.1.7-1.sparc
 PLATFORM= sparcsolaris

[Robert Elz]

The following reply was made to PR pkg/42278; it has been noted by GNATS.

From: Robert Elz <kre@...>
To: Tim Zingelman <tez@...>
Cc: gnats-bugs@..., pkg-manager@..., pkgsrc-bugs@...,
        gnats-admin@...
Subject: Re: pkg/42278 (print/acroread8 PLIST problems (file-check test))
Date: Mon, 09 Nov 2009 21:50:02 +0700

     Date:        Mon, 9 Nov 2009 07:13:33 -0600
     From:        Tim Zingelman <tez@...>
     Message-ID:  <f66ce35c0911090513t69dbfefewade74d55fb81708f@...>
 
   | Please try this patch and see if it resolves your issue (the missing
   | filenames are in PLIST.Linux already, so this should cause them to be
   | included.)
 
 Thanks, it does, but unfortunately, setting PLIST_SRC (even with +=)
 caused the default value for it to be ignored... so the effect was to
 invert the set of PLIST problems - all the errors from before went away,
 but every other file was now missing from the PLIST.
 
 The patch below seems to work though, but I'm not sure if this is the
 best way to do it.
 
 kre
 
 Index: Makefile
 ===================================================================
 RCS file: /cvsroot/NetBSD/pkgsrc/print/acroread8/Makefile,v
 retrieving revision 1.9
 diff -u -r1.9 Makefile
 --- Makefile 4 Nov 2009 23:37:53 -0000 1.9
 +++ Makefile 9 Nov 2009 14:46:08 -0000
 @@ -32,11 +32,14 @@
  EMUL_MODULES.linux= compat cups gtk2 locale
  EMUL_REQD= suse>=10.0
 
 +PLIST_SRC=             ${PLIST_SRC_DFLT}
 +
  .include "../../mk/bsd.prefs.mk"
 
  .if ${EMUL_PLATFORM} == "linux-i386"
  DISTNAME= AdobeReader_enu-8.1.7-1.i486
  PLATFORM= intellinux
 +PLIST_SRC+= PLIST.Linux
  .elif ${EMUL_PLATFORM} == "solaris-sparc"
  DISTNAME= AdobeReader_enu-8.1.7-1.sparc
  PLATFORM= sparcsolaris
 
 

[tez-8]

On Mon, Nov 9, 2009 at 8:55 AM, Robert Elz <kre@...> wrote:

>  The patch below seems to work though, but I'm not sure if this is the
>  best way to do it.

I have committed a similar fix.  Please reply if this resolves your
issue.  Thank you for the report.

 - Tim

[tez-8]

The following reply was made to PR pkg/42278; it has been noted by GNATS.

From: Tim Zingelman <tez@...>
To: gnats-bugs@...
Cc: gnats-admin@..., pkgsrc-bugs@..., kre@...
Subject: Re: pkg/42278 (print/acroread8 PLIST problems (file-check test))
Date: Mon, 9 Nov 2009 13:18:31 -0600

 On Mon, Nov 9, 2009 at 8:55 AM, Robert Elz <kre@...> wrote:
 
 > =A0The patch below seems to work though, but I'm not sure if this is the
 > =A0best way to do it.
 
 I have committed a similar fix.  Please reply if this resolves your
 issue.  Thank you for the report.
 
  - Tim
 

[Robert Elz]

    Date:        Mon, 9 Nov 2009 13:18:31 -0600
    From:        Tim Zingelman <tez@...>
    Message-ID:  <f66ce35c0911091118u5f3c5022y87a81c7fee80083d@...>

  | I have committed a similar fix.  Please reply if this resolves your
  | issue.

Yes, that way works as well.   Thanks.

kre

[Robert Elz]

The following reply was made to PR pkg/42278; it has been noted by GNATS.

From: Robert Elz <kre@...>
To: Tim Zingelman <tez@...>
Cc: gnats-bugs@..., gnats-admin@..., pkgsrc-bugs@...
Subject: Re: pkg/42278 (print/acroread8 PLIST problems (file-check test))
Date: Tue, 10 Nov 2009 07:34:56 +0700

     Date:        Mon, 9 Nov 2009 13:18:31 -0600
     From:        Tim Zingelman <tez@...>
     Message-ID:  <f66ce35c0911091118u5f3c5022y87a81c7fee80083d@...=
 =2Ecom>
 
   | I have committed a similar fix.  Please reply if this resolves your
   | issue.
 
 Yes, that way works as well.   Thanks.
 
 kre
 

[dholland]

Synopsis: print/acroread8 PLIST problems (file-check test)

State-Changed-From-To: feedback->closed
State-Changed-By: dholland@...
State-Changed-When: Tue, 10 Nov 2009 06:08:31 +0000
State-Changed-Why:
Fixed, thanks.