I wrote:
> Back on 15 Jul 2007, Klaus Heinz-22 wrote:
>
>> in dvdauthor 0.6.14 src/compat.h contains a macro ICONV_CONV which has
>> no definition anywhere in the code. On the other hand, there is
>> ICONV_CONST in config.h and incidentally ICONV_CONV protects a section
>> about iconv(), so I think the appended little patch is what was
>> originally
>> intended.
>
> I have decided to apply this. Can anybody see a downside?
Actually, both the original code and the patch are wrong. Casting an
actual argument to “const” is pointless. In fact, there is one
compilation warning because a const buffer is being passed to the second
argument of iconv(3), which is not declared as const (src/readxml.c,
line 268).
I have removed all this ICONV_CONST/ICONV_CAST business, and put in one
unconditional cast to fix the above warning.
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.
http://p.sf.net/sfu/bobj-july_______________________________________________
Dvdauthor-developer mailing list
Dvdauthor-developer@...
https://lists.sourceforge.net/lists/listinfo/dvdauthor-developer
