« Return to Thread: solution for UIDs bigger than 2^31

Re: solution for UIDs bigger than 2^31

by Bugzilla from mhlavink@redhat.com :: Rate this Message:

Paul Lesniewski wrote:

> On Tue, Nov 25, 2008 at 5:40 AM, Michal Hlavinka <mhlavink@...> wrote:
>
>> ...
>>
>> solution:
>> In sf tracker (no change for 10 months) is recommended to "cast" input
>> values to strings and change them to zero if input value is not numeric.
>> I was finishing patch for this
>>
>
> I hope against 1.5.2. I'm not sure we want to change this much code
> for 1.4.x. Please send the patch when you are done.
>

In fact it's not so much code. Only replace $a=(int)$b; to
$a=sqrestrict_to_num($b);
sqrestrict_to_int contains only : return (is_numeric($b) ? $b : 0);
Casting not int to int
results to 0, so there is no change.
I was making this patch against 1.4 svn version, but I can make it for
devel version,
that's not a problem.

>> but I've found squirrelmail uses also
>> ++, -- and comparison operators for UIDs (in
>> plugins/delete_move_next/setup.php: 152: delete_move_next_read(...)
>> function). So strings can't be used for this.
>>
>
> I think you are using an outdated version of SM.
>
svn 1.4 is outdated?
(
http://squirrelmail.svn.sourceforge.net/viewvc/squirrelmail/branches/SM-1_4-STABLE/squirrelmail/
)

>> ...
>> What do you think about this? Or, do you think, there is another solution?
>>
>
> I'd vote for the string implementation (in 1.5.2).
>
Yes, but what about that numeric operators? Of course, making functions for
=, !=, <, <=, ++ and -- is not so difficult, but also it's not too nice IMO.

Btw, what is 1.5.2 svn directory?
Is it http://squirrelmail.svn.sourceforge.net/viewvc/squirrelmail/trunk/ ?
It looks it contains some files 7 years old... for example
plugins/delete_move_next/setup.php
from the above looks older than from 1.4

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
-----
squirrelmail-devel mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-devel@...
List archives: http://news.gmane.org/gmane.mail.squirrelmail.devel
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel

« Return to Thread: solution for UIDs bigger than 2^31