Re: svn commit: r40222 - in trunk/subversion: include libsvn_repos

[Arfrever Frehtes Taifersar Arahesis-2]

2009-10-26 09:56:27 Julian Foad napisał(a):

> Author: julianfoad
> Date: Mon Oct 26 01:56:27 2009
> New Revision: 40222
>
> Log:
> Add pre-obliterate and post-obliterate hooks scripts, but don't yet use them.
> Add the code to create templates for them at repository creation time, and
> functions to run them, but no calls to the latter.
>
> * subversion/include/svn_repos.h
>   (svn_repos_pre_obliterate_hook, svn_repos_post_obliterate_hook): New
>     functions.
>
> * subversion/libsvn_repos/hooks.c
>   (check_hook_result): Support the obliterate hooks. (Only pre-xxx hooks are
>     mentioned explicitly in this function.)
>   (svn_repos__hooks_pre_obliterate, svn_repos__hooks_post_obliterate): New
>     functions, modeled on svn_repos__hooks_pre/post-revprop-change().
>
> * subversion/libsvn_repos/repos.c
>   (svn_repos_pre_obliterate_hook, svn_repos_post_obliterate_hook): New
>     functions, modeled on svn_repos_pre/post_revprop_change_hook().
>   (create_hooks): Add sections to generate pre/post-obliterate template
>     scripts.
>
> * subversion/libsvn_repos/repos.h
>   (SVN_REPOS__HOOK_PRE_OBLITERATE, SVN_REPOS__HOOK_POST_OBLITERATE): New.
>   (svn_repos__hooks_pre_obliterate, svn_repos__hooks_post_obliterate): New.
>
> Modified:
>    trunk/subversion/include/svn_repos.h
>    trunk/subversion/libsvn_repos/hooks.c
>    trunk/subversion/libsvn_repos/repos.c
>    trunk/subversion/libsvn_repos/repos.h
>
> Modified: trunk/subversion/include/svn_repos.h
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/include/svn_repos.h?pathrev=40222&r1=40221&r2=40222
> ==============================================================================
> --- trunk/subversion/include/svn_repos.h Mon Oct 26 01:41:52 2009 (r40221)
> +++ trunk/subversion/include/svn_repos.h Mon Oct 26 01:56:27 2009 (r40222)
> @@ -477,6 +477,20 @@ const char *
>  svn_repos_post_revprop_change_hook(svn_repos_t *repos,
>                                     apr_pool_t *pool);
>  
> +/** Return the path to @a repos's pre-obliterate hook, allocated in
> + * @a pool.
> + */
> +const char *
> +svn_repos_pre_obliterate_hook(svn_repos_t *repos,
> +                              apr_pool_t *pool);
> +
> +/** Return the path to @a repos's post-obliterate hook, allocated in
> + * @a pool.
> + */
> +const char *
> +svn_repos_post_obliterate_hook(svn_repos_t *repos,
> +                               apr_pool_t *pool);
> +

You should add '@since New in 1.7.' to doc strings of these functions.

--
Arfrever Frehtes Taifersar Arahesis

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2413166

[Julian Foad]

Arfrever Frehtes Taifersar Arahesis wrote:

> 2009-10-26 09:56:27 Julian Foad napisał(a):
> > +/** Return the path to @a repos's pre-obliterate hook, allocated in
> > + * @a pool.
> > + */
> > +const char *
> > +svn_repos_pre_obliterate_hook(svn_repos_t *repos,
> > +                              apr_pool_t *pool);
> > +
> > +/** Return the path to @a repos's post-obliterate hook, allocated in
> > + * @a pool.
> > + */
> > +const char *
> > +svn_repos_post_obliterate_hook(svn_repos_t *repos,
> > +                               apr_pool_t *pool);
> > +
>
> You should add '@since New in 1.7.' to doc strings of these functions.

Thanks. r40356.

- Julian

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2413880