Re: svn commit: r40340 - trunk/subversion/libsvn_wc

View: New views
3 Messages — Rating Filter:   Alert me  

Parent Message unknown Re: svn commit: r40340 - trunk/subversion/libsvn_wc

by Hyrum K. Wright-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Nov 1, 2009, at 8:27 AM, Bert Huijben wrote:

> Author: rhuijben
> Date: Sun Nov  1 06:27:25 2009
> New Revision: 40340
>
> Log:
> * subversion/libsvn_wc/old-and-busted.c
>  (svn_wc__read_entries_old):
>     Cast format number to integer instead of unrelated type to
>     remove warning.
>
> Modified:
>   trunk/subversion/libsvn_wc/old-and-busted.c
>
> Modified: trunk/subversion/libsvn_wc/old-and-busted.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_wc/old-and-busted.c?pathrev=40340&r1=40339&r2=40340
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- trunk/subversion/libsvn_wc/old-and-busted.c Sun Nov  1 06:12:56  
> 2009 (r40339)
> +++ trunk/subversion/libsvn_wc/old-and-busted.c Sun Nov  1 06:27:25  
> 2009 (r40340)
> @@ -1242,7 +1242,7 @@ svn_wc__read_entries_old(apr_hash_t **en
>          original format pre-upgrade. */
>       SVN_ERR(read_val(&val, &curp, endp));
>       if (val)
> -        entries_format = (apr_off_t)apr_strtoi64(val, NULL, 0);
> +        entries_format = (int)apr_strtoi64(val, NULL, 0);

I know the old code didn't do this, but I think the trend is to use  
space-before-paren for casts.  (But it's part of old-and-busted, so I  
don't really think it matters that much.  Vermillion.)

-Hyrum

>       else
>         return svn_error_createf(SVN_ERR_WC_CORRUPT, NULL,
>                                  _("Invalid version line in entries  
> file "
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=495&dsMessageId=2413440

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2413753

Re: svn commit: r40340 - trunk/subversion/libsvn_wc

by Branko Čibej-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hyrum K. Wright wrote:

> On Nov 1, 2009, at 8:27 AM, Bert Huijben wrote:
>  
>>       if (val)
>> -        entries_format = (apr_off_t)apr_strtoi64(val, NULL, 0);
>> +        entries_format = (int)apr_strtoi64(val, NULL, 0);
>>    
>
> I know the old code didn't do this, but I think the trend is to use  
> space-before-paren for casts.  (But it's part of old-and-busted, so I  
> don't really think it matters that much.  Vermillion.)
>  

Eh, I'm confuse, space before _which_ paren?

-- Brane

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2413793

Re: svn commit: r40340 - trunk/subversion/libsvn_wc

by Hyrum K. Wright-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Nov 2, 2009, at 8:12 AM, Branko Čibej wrote:

> Hyrum K. Wright wrote:
>> On Nov 1, 2009, at 8:27 AM, Bert Huijben wrote:
>>
>>>      if (val)
>>> -        entries_format = (apr_off_t)apr_strtoi64(val, NULL, 0);
>>> +        entries_format = (int)apr_strtoi64(val, NULL, 0);
                                    A
                         space here |

>>>
>>
>> I know the old code didn't do this, but I think the trend is to use
>> space-before-paren for casts.  (But it's part of old-and-busted, so I
>> don't really think it matters that much.  Vermillion.)
>>
>
> Eh, I'm confuse, space before _which_ paren?

Heh, I guess that line does look a bit lispy.

-Hyrum

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2413808