Re: svn commit: r4951 - trunk/cvs2svn_lib/passes.py

[mhagger]

Max Bowsher wrote:

> Author: maxb
> Date: 2009-11-07 07:57:08-0800
> New Revision: 4951
>
> Modified:
>    trunk/cvs2svn_lib/passes.py
>
> Log:
> Stash the PersistenceManager in the Ctx during OutputPass. I have need of
> random access to revisions from the GitOutputOption.
>
> [...]
> +    Ctx().persistence_manager = PersistenceManager(DB_OPEN_READ)

Context.clean() deletes members whose names start with a single "_" and
retains the others from pass to pass.  So I think this member name
should be prefixed with an underscore (even though OutputPass is the
last pass so it will probably make no practical difference).

Michael

------------------------------------------------------
http://cvs2svn.tigris.org/ds/viewMessage.do?dsForumId=1667&dsMessageId=2415512

To unsubscribe from this discussion, e-mail: [dev-unsubscribe@...].

[Max O Bowsher]

Michael Haggerty wrote:

> Max Bowsher wrote:
>> Author: maxb
>> Date: 2009-11-07 07:57:08-0800
>> New Revision: 4951
>>
>> Modified:
>>    trunk/cvs2svn_lib/passes.py
>>
>> Log:
>> Stash the PersistenceManager in the Ctx during OutputPass. I have need of
>> random access to revisions from the GitOutputOption.
>>
>> [...]
>> +    Ctx().persistence_manager = PersistenceManager(DB_OPEN_READ)
>
> Context.clean() deletes members whose names start with a single "_" and
> retains the others from pass to pass.  So I think this member name
> should be prefixed with an underscore (even though OutputPass is the
> last pass so it will probably make no practical difference).

Thanks for the catch, I'm sadly rusty on the wider view of the codebase.

Fixing...

Max.

------------------------------------------------------
http://cvs2svn.tigris.org/ds/viewMessage.do?dsForumId=1667&dsMessageId=2415966

To unsubscribe from this discussion, e-mail: [dev-unsubscribe@...].