« Return to Thread: Re: svn commit: r549064 - /maven/wagon/trunk/wagon-provider-api/src/main/java/org/apache/maven/wagon/AbstractWagon.java

Re: svn commit: r549064 - /maven/wagon/trunk/wagon-provider-api/src/main/java/org/apache/maven/wagon/AbstractWagon.java

by Joakim Erdfelt-2 :: Rate this Message:

Reply to Author | View in Thread

Be sure that this doesn't break forward compatibility too.

That approach would not allow for proper mirroring, authentication
propagation, network proxy usage, and short-circuits the whole wagon
manager approach of wagon 2.x

Direct usage of the wagon, not through the wagon manager, means a lot
less functionality than desired.

- Joakim

kenney@... wrote:

> Author: kenney
> Date: Wed Jun 20 04:06:27 2007
> New Revision: 549064
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=549064
> Log:
> Restore backwards compatibility - fix the deprecated method.
>
> Modified:
>     maven/wagon/trunk/wagon-provider-api/src/main/java/org/apache/maven/wagon/AbstractWagon.java
>
> Modified: maven/wagon/trunk/wagon-provider-api/src/main/java/org/apache/maven/wagon/AbstractWagon.java
> URL: http://svn.apache.org/viewvc/maven/wagon/trunk/wagon-provider-api/src/main/java/org/apache/maven/wagon/AbstractWagon.java?view=diff&rev=549064&r1=549063&r2=549064
> ==============================================================================
> --- maven/wagon/trunk/wagon-provider-api/src/main/java/org/apache/maven/wagon/AbstractWagon.java (original)
> +++ maven/wagon/trunk/wagon-provider-api/src/main/java/org/apache/maven/wagon/AbstractWagon.java Wed Jun 20 04:06:27 2007
> @@ -197,6 +197,9 @@
>      public void connect( Repository repository, AuthenticationInfo authenticationInfo, ProxyInfo proxyInfo )
>          throws ConnectionException, AuthenticationException
>      {
> +        setRepository( repository );
> +        setAuthenticationInfo( authenticationInfo );
> +        setProxyInfo( proxyInfo );
>          connect();
>      }
>  
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: wagon-commits-unsubscribe@...
> For additional commands, e-mail: wagon-commits-help@...
>
>  


--
- Joakim Erdfelt
  joakim@...
  Open Source Software (OSS) Developer


---------------------------------------------------------------------
To unsubscribe, e-mail: wagon-dev-unsubscribe@...
For additional commands, e-mail: wagon-dev-help@...

 « Return to Thread: Re: svn commit: r549064 - /maven/wagon/trunk/wagon-provider-api/src/main/java/org/apache/maven/wagon/AbstractWagon.java