Re: svn commit: r549064 - /maven/wagon/trunk/wagon-provider-api/src/main/java/org/apache/maven/wagon/AbstractWagon.java

by Jason van Zyl-2 :: Rate this Message:

On 20 Jun 07, at 10:13 AM 20 Jun 07, Joakim Erdfelt wrote:

> Be sure that this doesn't break forward compatibility too.
>
> That approach would not allow for proper mirroring, authentication
> propagation, network proxy usage, and short-circuits the whole
> wagon manager approach of wagon 2.x
>

Why is there any concept of mirroring in Wagon.

You are basically deciding all this stuff on your own and making
changes based on what you need in Archiva.

There's pretty much zero discussion surrounding all the changes you
are making and if you expect that to be absorbed into Maven you're
going to have a hard sell after what happened the last time it was
attempted. If the APIs are not compatible while the code is improved
I will be -1 on its inclusion in any version of Maven. There is no
reason the changes cannot be more gradual, and made to work with 1.x,
2.0.x, 2.1.x.

I'm honestly not in favor of using something so divergent as it's
being driven by the use of one application, we'll have a hard time
getting it to work right in Maven and we're going to very much screw
Maven 1.x because we're yet again going to change/fix everything on
something completely different then what they using. This is
especially important now that Maven 1.1 is imminent.

> Direct usage of the wagon, not through the wagon manager, means a
> lot less functionality than desired.
>

This is what Wagon was made for which is why the WagonManager was
always in Maven itself. The manager capability is nice, I agree, but
is not of prime importance in Wagon. The prime important is a simple
API for transport that works well for each of the providers. I fear
the API is going to get out of control like many of our other APIs
because the complexity of having this to work in something like
Archiva is going to pull in another kitchen sink.

> - Joakim
>
> kenney@... wrote:
>> Author: kenney
>> Date: Wed Jun 20 04:06:27 2007
>> New Revision: 549064
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=549064
>> Log:
>> Restore backwards compatibility - fix the deprecated method.
>>
>> Modified:
>> maven/wagon/trunk/wagon-provider-api/src/main/java/org/apache/
>> maven/wagon/AbstractWagon.java
>>
>> Modified: maven/wagon/trunk/wagon-provider-api/src/main/java/org/
>> apache/maven/wagon/AbstractWagon.java
>> URL: http://svn.apache.org/viewvc/maven/wagon/trunk/wagon-provider-
>> api/src/main/java/org/apache/maven/wagon/AbstractWagon.java?
>> view=diff&rev=549064&r1=549063&r2=549064
>> =====================================================================
>> =========
>> --- maven/wagon/trunk/wagon-provider-api/src/main/java/org/apache/
>> maven/wagon/AbstractWagon.java (original)
>> +++ maven/wagon/trunk/wagon-provider-api/src/main/java/org/apache/
>> maven/wagon/AbstractWagon.java Wed Jun 20 04:06:27 2007
>> @@ -197,6 +197,9 @@
>> public void connect( Repository repository,
>> AuthenticationInfo authenticationInfo, ProxyInfo proxyInfo )
>> throws ConnectionException, AuthenticationException
>> {
>> + setRepository( repository );
>> + setAuthenticationInfo( authenticationInfo );
>> + setProxyInfo( proxyInfo );
>> connect();
>> }
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: wagon-commits-unsubscribe@...
>> For additional commands, e-mail: wagon-commits-help@...
>>
>>
>
>
> --
> - Joakim Erdfelt
> joakim@...
> Open Source Software (OSS) Developer
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: wagon-dev-unsubscribe@...
> For additional commands, e-mail: wagon-dev-help@...
>
>

Thanks,

Jason

----------------------------------------------------------
Jason van Zyl
Founder and PMC Chair, Apache Maven
jason at sonatype dot com
----------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: wagon-dev-unsubscribe@...
For additional commands, e-mail: wagon-dev-help@...

« Return to Thread: Re: svn commit: r549064 - /maven/wagon/trunk/wagon-provider-api/src/main/java/org/apache/maven/wagon/AbstractWagon.java