Re: svn commit: r731213 - in /maven/wagon/trunk/wagon-providers: wagon-ftp/src/main/java/org/apache/maven/wagon/providers/ftp/FtpWagon.java wagon-ssh-common/src/main/java/org/apache/maven/wagon/providers/ssh/ScpHelper.java

[brettporter]

Is that consistent with the behaviour of the other providers as well?  
Can you add tests to ensure it is applied consistently?

Thanks,
Brett

On 04/01/2009, at 8:54 PM, dantran@... wrote:

> Author: dantran
> Date: Sun Jan  4 01:54:21 2009
> New Revision: 731213
>
> URL: http://svn.apache.org/viewvc?rev=731213&view=rev
> Log:
> WAGON-245:throw ResourceDoesNotExistException for a couple of cornor  
> cases
>
> Modified:
>    maven/wagon/trunk/wagon-providers/wagon-ftp/src/main/java/org/
> apache/maven/wagon/providers/ftp/FtpWagon.java
>    maven/wagon/trunk/wagon-providers/wagon-ssh-common/src/main/java/
> org/apache/maven/wagon/providers/ssh/ScpHelper.java
>
> Modified: maven/wagon/trunk/wagon-providers/wagon-ftp/src/main/java/
> org/apache/maven/wagon/providers/ftp/FtpWagon.java
> URL: http://svn.apache.org/viewvc/maven/wagon/trunk/wagon-providers/wagon-ftp/src/main/java/org/apache/maven/wagon/providers/ftp/FtpWagon.java?rev=731213&r1=731212&r2=731213&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- maven/wagon/trunk/wagon-providers/wagon-ftp/src/main/java/org/
> apache/maven/wagon/providers/ftp/FtpWagon.java (original)
> +++ maven/wagon/trunk/wagon-providers/wagon-ftp/src/main/java/org/
> apache/maven/wagon/providers/ftp/FtpWagon.java Sun Jan  4 01:54:21  
> 2009
> @@ -373,7 +373,7 @@
>     {
>         if ( !
> ftp.changeWorkingDirectory( getRepository().getBasedir() ) )
>         {
> -            throw new TransferFailedException(
> +            throw new ResourceDoesNotExistException(
>                 "Required directory: '" +  
> getRepository().getBasedir() + "' " + "is missing" );
>         }
>
>
> Modified: maven/wagon/trunk/wagon-providers/wagon-ssh-common/src/
> main/java/org/apache/maven/wagon/providers/ssh/ScpHelper.java
> URL: http://svn.apache.org/viewvc/maven/wagon/trunk/wagon-providers/wagon-ssh-common/src/main/java/org/apache/maven/wagon/providers/ssh/ScpHelper.java?rev=731213&r1=731212&r2=731213&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- maven/wagon/trunk/wagon-providers/wagon-ssh-common/src/main/java/
> org/apache/maven/wagon/providers/ssh/ScpHelper.java (original)
> +++ maven/wagon/trunk/wagon-providers/wagon-ssh-common/src/main/java/
> org/apache/maven/wagon/providers/ssh/ScpHelper.java Sun Jan  4  
> 01:54:21 2009
> @@ -289,6 +289,10 @@
>             {
>                 throw new  
> ResourceDoesNotExistException( e.getMessage().trim() );
>             }
> +            else if ( e.getMessage().trim().endsWith( "Not a  
> directory" ) )
> +            {
> +                throw new  
> ResourceDoesNotExistException( e.getMessage().trim() );
> +            }
>             else
>             {
>                 throw new TransferFailedException( "Error performing  
> file listing.", e );
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: wagon-commits-unsubscribe@...
> For additional commands, e-mail: wagon-commits-help@...
>

--
Brett Porter
brett@...
http://blogs.exist.com/bporter/


---------------------------------------------------------------------
To unsubscribe, e-mail: wagon-dev-unsubscribe@...
For additional commands, e-mail: wagon-dev-help@...

[Dan Tran]

Hi Brett,

will add more tests

Sorry about delay, I did not subscribe to wagon dev list until today

-D

brettporter wrote:

Is that consistent with the behaviour of the other providers as well?  
Can you add tests to ensure it is applied consistently?

Thanks,
Brett

On 04/01/2009, at 8:54 PM, [e-mail] wrote:

> Author: dantran
> Date: Sun Jan  4 01:54:21 2009
> New Revision: 731213
>
> URL: http://svn.apache.org/viewvc?rev=731213&view=rev
> Log:
> WAGON-245:throw ResourceDoesNotExistException for a couple of cornor  
> cases
>
> Modified:
>    maven/wagon/trunk/wagon-providers/wagon-ftp/src/main/java/org/
> apache/maven/wagon/providers/ftp/FtpWagon.java
>    maven/wagon/trunk/wagon-providers/wagon-ssh-common/src/main/java/
> org/apache/maven/wagon/providers/ssh/ScpHelper.java
>
> Modified: maven/wagon/trunk/wagon-providers/wagon-ftp/src/main/java/
> org/apache/maven/wagon/providers/ftp/FtpWagon.java
> URL: http://svn.apache.org/viewvc/maven/wagon/trunk/wagon-providers/wagon-ftp/src/main/java/org/apache/maven/wagon/providers/ftp/FtpWagon.java?rev=731213&r1=731212&r2=731213&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- maven/wagon/trunk/wagon-providers/wagon-ftp/src/main/java/org/
> apache/maven/wagon/providers/ftp/FtpWagon.java (original)
> +++ maven/wagon/trunk/wagon-providers/wagon-ftp/src/main/java/org/
> apache/maven/wagon/providers/ftp/FtpWagon.java Sun Jan  4 01:54:21  
> 2009
> @@ -373,7 +373,7 @@
>     {
>         if ( !
> ftp.changeWorkingDirectory( getRepository().getBasedir() ) )
>         {
> -            throw new TransferFailedException(
> +            throw new ResourceDoesNotExistException(
>                 "Required directory: '" +  
> getRepository().getBasedir() + "' " + "is missing" );
>         }
>
>
> Modified: maven/wagon/trunk/wagon-providers/wagon-ssh-common/src/
> main/java/org/apache/maven/wagon/providers/ssh/ScpHelper.java
> URL: http://svn.apache.org/viewvc/maven/wagon/trunk/wagon-providers/wagon-ssh-common/src/main/java/org/apache/maven/wagon/providers/ssh/ScpHelper.java?rev=731213&r1=731212&r2=731213&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- maven/wagon/trunk/wagon-providers/wagon-ssh-common/src/main/java/
> org/apache/maven/wagon/providers/ssh/ScpHelper.java (original)
> +++ maven/wagon/trunk/wagon-providers/wagon-ssh-common/src/main/java/
> org/apache/maven/wagon/providers/ssh/ScpHelper.java Sun Jan  4  
> 01:54:21 2009
> @@ -289,6 +289,10 @@
>             {
>                 throw new  
> ResourceDoesNotExistException( e.getMessage().trim() );
>             }
> +            else if ( e.getMessage().trim().endsWith( "Not a  
> directory" ) )
> +            {
> +                throw new  
> ResourceDoesNotExistException( e.getMessage().trim() );
> +            }
>             else
>             {
>                 throw new TransferFailedException( "Error performing  
> file listing.", e );
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [e-mail]
> For additional commands, e-mail: [e-mail]
>

--
Brett Porter
[e-mail]
http://blogs.exist.com/bporter/


---------------------------------------------------------------------
To unsubscribe, e-mail: [e-mail]
For additional commands, e-mail: [e-mail]