Re: svn commit: r784555 - /maven/components/branches/maven-2.1.x/maven-core/pom.xml

[brettporter]

Hi Benjamin,
Unfortunately this broke the build on my machine (maybe because of a
difference in working copy version?).

Also, it doesn't appear to have been merged to the other branches.

I think perhaps we should change the activation so that this is only
included on release, or if requested (say, from
CI) - that way it won't affect most users but will be ensured to be
present on release. WDYT?

- Brett

2009/6/14 <bentmann@...>

> Author: bentmann
> Date: Sun Jun 14 13:44:41 2009
> New Revision: 784555
>
> URL: http://svn.apache.org/viewvc?rev=784555&view=rev
> Log:
> [MNG-4200] Build fails on system without svn client
>
> Modified:
>    maven/components/branches/maven-2.1.x/maven-core/pom.xml
>
> Modified: maven/components/branches/maven-2.1.x/maven-core/pom.xml
> URL:
> http://svn.apache.org/viewvc/maven/components/branches/maven-2.1.x/maven-core/pom.xml?rev=784555&r1=784554&r2=784555&view=diff
>
> ==============================================================================
> --- maven/components/branches/maven-2.1.x/maven-core/pom.xml (original)
> +++ maven/components/branches/maven-2.1.x/maven-core/pom.xml Sun Jun 14
> 13:44:41 2009
> @@ -250,7 +250,7 @@
>           <plugin>
>             <groupId>org.codehaus.mojo</groupId>
>             <artifactId>buildnumber-maven-plugin</artifactId>
> -            <version>1.0-beta-1</version>
> +            <version>1.0-beta-3</version>
>             <executions>
>               <execution>
>                 <phase>generate-resources</phase>
> @@ -262,6 +262,9 @@
>             <configuration>
>               <doCheck>false</doCheck>
>               <doUpdate>false</doUpdate>
> +              <providerImplementations>
> +                <svn>javasvn</svn>
> +              </providerImplementations>
>             </configuration>
>           </plugin>
>         </plugins>
> @@ -279,7 +282,7 @@
>           <plugin>
>             <groupId>org.codehaus.mojo</groupId>
>             <artifactId>buildnumber-maven-plugin</artifactId>
> -            <version>1.0-beta-1</version>
> +            <version>1.0-beta-3</version>
>             <executions>
>               <execution>
>                 <phase>generate-resources</phase>
>
>
>

--
Brett Porter
http://blogs.exist.com/bporter/

[Benjamin Bentmann]

Hi Brett,

> Unfortunately this broke the build on my machine (maybe because of a
> difference in working copy version?).

Hm, can you provide some more details on the failure? I only tested with
WinXP and Ubuntu and don't have a Mac at hand, so can't reproduce
easily. No idea whether I just misconfigured something or whether you
revealed an issue in the svnjava provider itself.

> Also, it doesn't appear to have been merged to the other branches.

Right, I would have liked some feedback from the reporter before I merge
this over and close the issue. But after two weeks of no response,
feedback seems unlikely. So I will merge this around once we figured
your issue out and have this working on all platforms.

> I think perhaps we should change the activation so that this is only
> included on release, or if requested (say, from
> CI) - that way it won't affect most users but will be ensured to be
> present on release. WDYT?

I'm not religous about this particular build step so sounds OK to me as
long as it kicks in automatically during a release.


Benjamin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

[brettporter]

On 30/06/2009, at 5:45 AM, Benjamin Bentmann wrote:

> Hi Brett,
>
>> Unfortunately this broke the build on my machine (maybe because of a
>> difference in working copy version?).
>
> Hm, can you provide some more details on the failure? I only tested  
> with WinXP and Ubuntu and don't have a Mac at hand, so can't  
> reproduce easily. No idea whether I just misconfigured something or  
> whether you revealed an issue in the svnjava provider itself.

[INFO] Cannot get the revision information from the scm repository :
Exception while executing SCM command.

svn: '/Users/brett/scm/maven/maven-2.1.x/maven-core' is not a working  
copy

However:

$ svn info

Path: .
URL: https://svn.apache.org/repos/asf/maven/components/branches/maven-2.1.x/maven-core
...

>
> I'm not religous about this particular build step so sounds OK to me  
> as long as it kicks in automatically during a release.
>

Yeah, I think that's my preference and we can use the "non-canonical"  
version that is there for personal builds.

- Brett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

[Benjamin Bentmann]

Brett Porter wrote:

> [INFO] Cannot get the revision information from the scm repository :
> Exception while executing SCM command.
>
> svn: '/Users/brett/scm/maven/maven-2.1.x/maven-core' is not a working copy

OK, as the javasvn provider seems not to work as reliable as the regular
svn provider, I reverted my change.

Independently from the updates we discussed here, I suggest you fill an
issue at the javasvn project.


Benjamin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

[brettporter]

On 01/07/2009, at 4:53 AM, Benjamin Bentmann wrote:

> Brett Porter wrote:
>
>> [INFO] Cannot get the revision information from the scm repository :
>> Exception while executing SCM command.
>> svn: '/Users/brett/scm/maven/maven-2.1.x/maven-core' is not a  
>> working copy
>
> OK, as the javasvn provider seems not to work as reliable as the  
> regular svn provider, I reverted my change.
>
> Independently from the updates we discussed here, I suggest you fill  
> an issue at the javasvn project.

http://code.google.com/p/maven-scm-provider-svnjava/issues/detail?id=4

>
>
> Benjamin
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@...
> For additional commands, e-mail: dev-help@...
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

[Olivier Lamy]

Hi,
I think the only committer will have a look at this :-)
But the main issue will be to have the svnkit version available in central repo.

Thanks,
--
Olivier

2009/7/1 Brett Porter <brett@...>:

>
> On 01/07/2009, at 4:53 AM, Benjamin Bentmann wrote:
>
>> Brett Porter wrote:
>>
>>> [INFO] Cannot get the revision information from the scm repository :
>>> Exception while executing SCM command.
>>> svn: '/Users/brett/scm/maven/maven-2.1.x/maven-core' is not a working
>>> copy
>>
>> OK, as the javasvn provider seems not to work as reliable as the regular
>> svn provider, I reverted my change.
>>
>> Independently from the updates we discussed here, I suggest you fill an
>> issue at the javasvn project.
>
> http://code.google.com/p/maven-scm-provider-svnjava/issues/detail?id=4
>
>>
>>
>> Benjamin
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@...
>> For additional commands, e-mail: dev-help@...
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@...
> For additional commands, e-mail: dev-help@...
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

[struberg]

> to have the svnkit version
> available in central repo.

afaik there is a problem with the svnkit license [1] which seems not compatible to ASL because it requires loyalties if used commercially (even if not used directly but as part of e.g. maven).

So there is no legal way to switch to svnkit as a default implementation not to put it on repo.apache.org.

LieGrue,
strub

[1] http://svnkit.com/licensing.html


--- Olivier Lamy <olamy@...> schrieb am Mi, 1.7.2009:

> Von: Olivier Lamy <olamy@...>
> Betreff: Re: svn commit: r784555 - /maven/components/branches/maven-2.1.x/maven-core/pom.xml
> An: "Maven Developers List" <dev@...>
> Datum: Mittwoch, 1. Juli 2009, 8:58
> Hi,
> I think the only committer will have a look at this :-)
> But the main issue will be to have the svnkit version
> available in central repo.
>
> Thanks,
> --
> Olivier
>
> 2009/7/1 Brett Porter <brett@...>:
> >
> > On 01/07/2009, at 4:53 AM, Benjamin Bentmann wrote:
> >
> >> Brett Porter wrote:
> >>
> >>> [INFO] Cannot get the revision information
> from the scm repository :
> >>> Exception while executing SCM command.
> >>> svn:
> '/Users/brett/scm/maven/maven-2.1.x/maven-core' is not a
> working
> >>> copy
> >>
> >> OK, as the javasvn provider seems not to work as
> reliable as the regular
> >> svn provider, I reverted my change.
> >>
> >> Independently from the updates we discussed here,
> I suggest you fill an
> >> issue at the javasvn project.
> >
> > http://code.google.com/p/maven-scm-provider-svnjava/issues/detail?id=4
> >
> >>
> >>
> >> Benjamin
> >>
> >>
> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@...
> >> For additional commands, e-mail: dev-help@...
> >>
> >
> >
> >
> ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@...
> > For additional commands, e-mail: dev-help@...
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@...
> For additional commands, e-mail: dev-help@...
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...