Re: svn commit: r802678

View: New views

4 Messages — Rating Filter: Alert me

	Re: svn commit: r802678 by brettporter :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message On 10/08/2009, at 3:43 AM, ctan@... wrote: > Author: ctan > Date: Mon Aug 10 07:43:31 2009 > New Revision: 802678 > > URL: http://svn.apache.org/viewvc?rev=802678&view=rev > Log: > added unit test for PrepareBuildProjectsTaskExecutor The license headers in this commit are incorrect. - Brett
	Re: svn commit: r802678 by Marica Tan-2 :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message On Sat, Aug 22, 2009 at 8:29 PM, Brett Porter <brett@...> wrote: > > On 10/08/2009, at 3:43 AM, ctan@... wrote: > > Author: ctan >> Date: Mon Aug 10 07:43:31 2009 >> New Revision: 802678 >> >> URL: http://svn.apache.org/viewvc?rev=802678&view=rev >> Log: >> added unit test for PrepareBuildProjectsTaskExecutor >> > > The license headers in this commit are incorrect. > What should be the license headers? > > - Brett > >
	Re: svn commit: r802678 by brettporter :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message On 23/08/2009, at 7:21 PM, Marica Tan wrote: > On Sat, Aug 22, 2009 at 8:29 PM, Brett Porter <brett@...> > wrote: > >> >> On 10/08/2009, at 3:43 AM, ctan@... wrote: >> >> Author: ctan >>> Date: Mon Aug 10 07:43:31 2009 >>> New Revision: 802678 >>> >>> URL: http://svn.apache.org/viewvc?rev=802678&view=rev >>> Log: >>> added unit test for PrepareBuildProjectsTaskExecutor >>> >> >> The license headers in this commit are incorrect. >> > > What should be the license headers? While normally if they are copied from an existing source the license headers need to be retained, I know the existing licenses can be removed :) We always need to add the ASF license header in addition to others that are in the files though. - Brett
	Re: svn commit: r802678 by Marica Tan-2 :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message Sorry I didn't see that... I thought I was using the ASF license header :( On Mon, Aug 24, 2009 at 8:29 AM, Brett Porter <brett@...> wrote: > > On 23/08/2009, at 7:21 PM, Marica Tan wrote: > > On Sat, Aug 22, 2009 at 8:29 PM, Brett Porter <brett@...> wrote: >> >> >>> On 10/08/2009, at 3:43 AM, ctan@... wrote: >>> >>> Author: ctan >>> >>>> Date: Mon Aug 10 07:43:31 2009 >>>> New Revision: 802678 >>>> >>>> URL: http://svn.apache.org/viewvc?rev=802678&view=rev >>>> Log: >>>> added unit test for PrepareBuildProjectsTaskExecutor >>>> >>>> >>> The license headers in this commit are incorrect. >>> >>> >> What should be the license headers? >> > > While normally if they are copied from an existing source the license > headers need to be retained, I know the existing licenses can be removed :) > > We always need to add the ASF license header in addition to others that are > in the files though. > > - Brett >

	Re: svn commit: r802678 by brettporter :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message On 10/08/2009, at 3:43 AM, ctan@... wrote: > Author: ctan > Date: Mon Aug 10 07:43:31 2009 > New Revision: 802678 > > URL: http://svn.apache.org/viewvc?rev=802678&view=rev > Log: > added unit test for PrepareBuildProjectsTaskExecutor The license headers in this commit are incorrect. - Brett
	Re: svn commit: r802678 by Marica Tan-2 :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message On Sat, Aug 22, 2009 at 8:29 PM, Brett Porter <brett@...> wrote: > > On 10/08/2009, at 3:43 AM, ctan@... wrote: > > Author: ctan >> Date: Mon Aug 10 07:43:31 2009 >> New Revision: 802678 >> >> URL: http://svn.apache.org/viewvc?rev=802678&view=rev >> Log: >> added unit test for PrepareBuildProjectsTaskExecutor >> > > The license headers in this commit are incorrect. > What should be the license headers? > > - Brett > >
	Re: svn commit: r802678 by brettporter :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message On 23/08/2009, at 7:21 PM, Marica Tan wrote: > On Sat, Aug 22, 2009 at 8:29 PM, Brett Porter <brett@...> > wrote: > >> >> On 10/08/2009, at 3:43 AM, ctan@... wrote: >> >> Author: ctan >>> Date: Mon Aug 10 07:43:31 2009 >>> New Revision: 802678 >>> >>> URL: http://svn.apache.org/viewvc?rev=802678&view=rev >>> Log: >>> added unit test for PrepareBuildProjectsTaskExecutor >>> >> >> The license headers in this commit are incorrect. >> > > What should be the license headers? While normally if they are copied from an existing source the license headers need to be retained, I know the existing licenses can be removed :) We always need to add the ASF license header in addition to others that are in the files though. - Brett
	Re: svn commit: r802678 by Marica Tan-2 :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message Sorry I didn't see that... I thought I was using the ASF license header :( On Mon, Aug 24, 2009 at 8:29 AM, Brett Porter <brett@...> wrote: > > On 23/08/2009, at 7:21 PM, Marica Tan wrote: > > On Sat, Aug 22, 2009 at 8:29 PM, Brett Porter <brett@...> wrote: >> >> >>> On 10/08/2009, at 3:43 AM, ctan@... wrote: >>> >>> Author: ctan >>> >>>> Date: Mon Aug 10 07:43:31 2009 >>>> New Revision: 802678 >>>> >>>> URL: http://svn.apache.org/viewvc?rev=802678&view=rev >>>> Log: >>>> added unit test for PrepareBuildProjectsTaskExecutor >>>> >>>> >>> The license headers in this commit are incorrect. >>> >>> >> What should be the license headers? >> > > While normally if they are copied from an existing source the license > headers need to be retained, I know the existing licenses can be removed :) > > We always need to add the ASF license header in addition to others that are > in the files though. > > - Brett >