Re: svn commit: r809963 - in /continuum/branches/continuum-1.3.x/continuum-webapp/src: main/java/org/apache/maven/continuum/web/action/AddProjectAction.java test/java/org/apache/maven/continuum/web/action/AddProjectActionTest.java

[brettporter]

I know this commit is super old, but I haven't got around to reviewing  
some lately...

On 01/09/2009, at 8:47 PM, jzurbano@... wrote:

> Author: jzurbano
> Date: Tue Sep  1 10:47:21 2009
> New Revision: 809963
>
> URL: http://svn.apache.org/viewvc?rev=809963&view=rev
> Log:
> [CONTINUUM-2347] - "Project Group is required and all projects must  
> be in a project group" is displayed when adding Ant/Shell Projects
>
>
> Modified: continuum/branches/continuum-1.3.x/continuum-webapp/src/
> main/java/org/apache/maven/continuum/web/action/AddProjectAction.java
> URL: http://svn.apache.org/viewvc/continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/AddProjectAction.java?rev=809963&r1=809962&r2=809963&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- continuum/branches/continuum-1.3.x/continuum-webapp/src/main/
> java/org/apache/maven/continuum/web/action/AddProjectAction.java  
> (original)
> +++ continuum/branches/continuum-1.3.x/continuum-webapp/src/main/
> java/org/apache/maven/continuum/web/action/AddProjectAction.java Tue  
> Sep  1 10:47:21 2009
> @@ -66,7 +66,7 @@
>
>     private Collection<ProjectGroup> projectGroups;
>
> -    private int selectedProjectGroup;
> +    private static int selectedProjectGroup;

Why is this static?

- Brett

[Jevica Arianne Zurbano]

On Tue, Oct 13, 2009 at 8:25 AM, Brett Porter <brett@...> wrote:

> I know this commit is super old, but I haven't got around to reviewing some
> lately...
>
> On 01/09/2009, at 8:47 PM, jzurbano@... wrote:
>
>  Author: jzurbano
>> Date: Tue Sep  1 10:47:21 2009
>> New Revision: 809963
>>
>> URL: http://svn.apache.org/viewvc?rev=809963&view=rev
>> Log:
>> [CONTINUUM-2347] - "Project Group is required and all projects must be in
>> a project group" is displayed when adding Ant/Shell Projects
>>
>>
>> Modified:
>> continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/AddProjectAction.java
>> URL:
>> http://svn.apache.org/viewvc/continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/AddProjectAction.java?rev=809963&r1=809962&r2=809963&view=diff
>>
>> ==============================================================================
>> ---
>> continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/AddProjectAction.java
>> (original)
>> +++
>> continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/AddProjectAction.java
>> Tue Sep  1 10:47:21 2009
>> @@ -66,7 +66,7 @@
>>
>>    private Collection<ProjectGroup> projectGroups;
>>
>> -    private int selectedProjectGroup;
>> +    private static int selectedProjectGroup;
>>
>
> Why is this static?
>

I made this one static so that when the project is added, it will still have
the value of the project group
and will not return to the page with the error.


> - Brett
>
>

[Jevica Arianne Zurbano]

 I have reverted the changes made:
- branch: 824635 (reverts r809963)
- trunk: 824636 (reverts r809964)

I also could not replicate the issue, so I removed the fix for version in
the ticket too.

Thanks Brett for pointing that out :)

[brettporter]

shouldn't it be "cannot reproduce" instead of "fixed" then?

On 13/10/2009, at 7:55 PM, Jevica Arianne Zurbano wrote:

> I have reverted the changes made:
> - branch: 824635 (reverts r809963)
> - trunk: 824636 (reverts r809964)
>
> I also could not replicate the issue, so I removed the fix for  
> version in
> the ticket too.
>
> Thanks Brett for pointing that out :)