Re: svn commit: r820144 - /continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/continuum/web/action/admin/BuildAgentAction.java

[brettporter]

On 30/09/2009, at 11:39 AM, ctan@... wrote:

> Author: ctan
> Date: Wed Sep 30 01:39:27 2009
> New Revision: 820144
>
> URL: http://svn.apache.org/viewvc?rev=820144&view=rev
> Log:
> [CONTINUUM-2377] store configuration changes of build agent in  
> continuum.xml

Is there a way to unit test this?

- Brett

[Marica Tan-2]

There's already a unit test in
org.apache.maven.continuum.configuration.ConfigurationServiceTest.java for
adding/removing build agents in continuum.xml.


On Wed, Sep 30, 2009 at 1:58 PM, Brett Porter <brett@...> wrote:

>
> On 30/09/2009, at 11:39 AM, ctan@... wrote:
>
>  Author: ctan
>> Date: Wed Sep 30 01:39:27 2009
>> New Revision: 820144
>>
>> URL: http://svn.apache.org/viewvc?rev=820144&view=rev
>> Log:
>> [CONTINUUM-2377] store configuration changes of build agent in
>> continuum.xml
>>
>
> Is there a way to unit test this?
>
> - Brett
>
>

[brettporter]

Right, but does it test the specific problem you fixed here?

On 01/10/2009, at 9:43 AM, Marica Tan wrote:

> There's already a unit test in
> org.apache.maven.continuum.configuration.ConfigurationServiceTest.java
>  for
> adding/removing build agents in continuum.xml.
>
>
> On Wed, Sep 30, 2009 at 1:58 PM, Brett Porter <brett@...>  
> wrote:
>
>>
>> On 30/09/2009, at 11:39 AM, ctan@... wrote:
>>
>> Author: ctan
>>> Date: Wed Sep 30 01:39:27 2009
>>> New Revision: 820144
>>>
>>> URL: http://svn.apache.org/viewvc?rev=820144&view=rev
>>> Log:
>>> [CONTINUUM-2377] store configuration changes of build agent in
>>> continuum.xml
>>>
>>
>> Is there a way to unit test this?
>>
>> - Brett
>>
>>

[Marica Tan-2]

I'll create one :)

Thanks
--
Marica

On Thu, Oct 1, 2009 at 8:25 AM, Brett Porter <brett@...> wrote:

> Right, but does it test the specific problem you fixed here?
>
>
> On 01/10/2009, at 9:43 AM, Marica Tan wrote:
>
>  There's already a unit test in
>> org.apache.maven.continuum.configuration.ConfigurationServiceTest.java
>>  for
>> adding/removing build agents in continuum.xml.
>>
>>
>> On Wed, Sep 30, 2009 at 1:58 PM, Brett Porter <brett@...> wrote:
>>
>>
>>> On 30/09/2009, at 11:39 AM, ctan@... wrote:
>>>
>>> Author: ctan
>>>
>>>> Date: Wed Sep 30 01:39:27 2009
>>>> New Revision: 820144
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=820144&view=rev
>>>> Log:
>>>> [CONTINUUM-2377] store configuration changes of build agent in
>>>> continuum.xml
>>>>
>>>>
>>> Is there a way to unit test this?
>>>
>>> - Brett
>>>
>>>
>>>
>