|
»
»
Re: svn propchange: r751668 - svn:log
|
View:
New views
6 Messages
—
Rating Filter:
Alert me
|
 |
|
|
|
Re: svn propchange: r751668 - svn:log
by brettporter
::
Rate this Message:
yep, I guessed it's part of it :)
I think all of ArchivaXworkUser can be removed if that property is not being used any more? - Brett On 10/03/2009, at 12:12 AM, Emmanuel Venisse wrote: > Not exactly, but can be a part of it. > > On Mon, Mar 9, 2009 at 2:09 PM, <brett@...> wrote: > >> Author: brett >> Revision: 751668 >> Modified property: svn:log >> >> Modified: svn:log at Mon Mar 9 13:09:05 2009 >> >> ------------------------------------------------------------------------------ >> --- svn:log (original) >> +++ svn:log Mon Mar 9 13:09:05 2009 >> @@ -1 +1 @@ >> -Remove old/unused property >> +[MRM-938] Remove old/unused property >> >> -- Brett Porter brett@... http://blogs.exist.com/bporter/ |
|
|
Re: svn propchange: r751668 - svn:log
by Emmanuel Venisse-2
::
Rate this Message:
Actually, in Archiva, we have lot of harcoded "guest" string and call
to "redback.default.guest" property. They must be removed and replaced by UserManager.getGuestUser() It isn't really a problem to let them in the code (except the calls to the property) because it works fine with them because Redback use "guest" to for the guest account, it's just not clean. I'm not sure I'll can work on it this week On Mon, Mar 9, 2009 at 2:12 PM, Emmanuel Venisse <emmanuel.venisse@... > wrote: > Not exactly, but can be a part of it. > > > On Mon, Mar 9, 2009 at 2:09 PM, <brett@...> wrote: > >> Author: brett >> Revision: 751668 >> Modified property: svn:log >> >> Modified: svn:log at Mon Mar 9 13:09:05 2009 >> >> ------------------------------------------------------------------------------ >> --- svn:log (original) >> +++ svn:log Mon Mar 9 13:09:05 2009 >> @@ -1 +1 @@ >> -Remove old/unused property >> +[MRM-938] Remove old/unused property >> >> > |
|
|
Re: svn propchange: r751668 - svn:log
by Emmanuel Venisse-2
::
Rate this Message:
Yes
On Mon, Mar 9, 2009 at 2:15 PM, Brett Porter <brett@...> wrote: > yep, I guessed it's part of it :) > > I think all of ArchivaXworkUser can be removed if that property is not > being used any more? > > - Brett > > > On 10/03/2009, at 12:12 AM, Emmanuel Venisse wrote: > > Not exactly, but can be a part of it. >> >> On Mon, Mar 9, 2009 at 2:09 PM, <brett@...> wrote: >> >> Author: brett >>> Revision: 751668 >>> Modified property: svn:log >>> >>> Modified: svn:log at Mon Mar 9 13:09:05 2009 >>> >>> >>> ------------------------------------------------------------------------------ >>> --- svn:log (original) >>> +++ svn:log Mon Mar 9 13:09:05 2009 >>> @@ -1 +1 @@ >>> -Remove old/unused property >>> +[MRM-938] Remove old/unused property >>> >>> >>> > -- > Brett Porter > brett@... > http://blogs.exist.com/bporter/ > > |
|
|
Re: svn propchange: r751668 - svn:log
by Emmanuel Venisse-2
::
Rate this Message:
When it will be remove and all hardcoded "guest" string too, MRM-938 will
can be closed. On Mon, Mar 9, 2009 at 2:17 PM, Emmanuel Venisse <emmanuel.venisse@... > wrote: > Yes > > > On Mon, Mar 9, 2009 at 2:15 PM, Brett Porter <brett@...> wrote: > >> yep, I guessed it's part of it :) >> >> I think all of ArchivaXworkUser can be removed if that property is not >> being used any more? >> >> - Brett >> >> >> On 10/03/2009, at 12:12 AM, Emmanuel Venisse wrote: >> >> Not exactly, but can be a part of it. >>> >>> On Mon, Mar 9, 2009 at 2:09 PM, <brett@...> wrote: >>> >>> Author: brett >>>> Revision: 751668 >>>> Modified property: svn:log >>>> >>>> Modified: svn:log at Mon Mar 9 13:09:05 2009 >>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> --- svn:log (original) >>>> +++ svn:log Mon Mar 9 13:09:05 2009 >>>> @@ -1 +1 @@ >>>> -Remove old/unused property >>>> +[MRM-938] Remove old/unused property >>>> >>>> >>>> >> -- >> Brett Porter >> brett@... >> http://blogs.exist.com/bporter/ >> >> > |
|
|
Re: svn propchange: r751668 - svn:log
by brettporter
::
Rate this Message:
Ok that makes sense now - I saw that class, but I wasn't sure if it
was right because it also used "guest". I'll add a note to the issue - I'm sure someone will be able to pick it up if you don't have time. Cheers, Brett On 10/03/2009, at 12:17 AM, Emmanuel Venisse wrote: > Actually, in Archiva, we have lot of harcoded "guest" string and call > to "redback.default.guest" > property. > They must be removed and replaced by UserManager.getGuestUser() > It isn't really a problem to let them in the code (except the calls > to the > property) because it works fine with them because Redback use > "guest" to for > the guest account, it's just not clean. > I'm not sure I'll can work on it this week > > On Mon, Mar 9, 2009 at 2:12 PM, Emmanuel Venisse <emmanuel.venisse@... >> wrote: > >> Not exactly, but can be a part of it. >> >> >> On Mon, Mar 9, 2009 at 2:09 PM, <brett@...> wrote: >> >>> Author: brett >>> Revision: 751668 >>> Modified property: svn:log >>> >>> Modified: svn:log at Mon Mar 9 13:09:05 2009 >>> >>> ------------------------------------------------------------------------------ >>> --- svn:log (original) >>> +++ svn:log Mon Mar 9 13:09:05 2009 >>> @@ -1 +1 @@ >>> -Remove old/unused property >>> +[MRM-938] Remove old/unused property >>> >>> >> -- Brett Porter brett@... http://blogs.exist.com/bporter/ |
| Free embeddable forum powered by Nabble | Forum Help |
