« Return to Thread: testdwr.war vs test-dwr.war

Re: testdwr.war vs test-dwr.war

by davidmarginian :: Rate this Message:

Reply to Author | View in Thread

Do you have the latest build.xml file for each project?  I am pretty
sure I updated both of them.  I changed the name per Joe's
recommendation.  A number of tests were failing due to:

 public Verify checkContext()
    {
        ServerContext serverContext = ServerContextFactory.get();
        Container container = serverContext.getContainer();
        Verify verify = new Verify();

        verify.equals("ContextPath", "/test-dwr",
serverContext.getContextPath());
        verify.equals("Version", VersionUtil.getVersion(),
serverContext.getVersion());
        verify.equals("Container.class",
DefaultContainer.class.getName(), container.getClass().getName());
        verify.equals("Container.getBean", "DwrServlet",
container.getBean("ContainerType"));

        return verify;
    }

Virtually every test class has this path hardcoded.  Perhaps we should
revert my change and change the checkContext method to check for testdwr
not test-dwr.  I agree that semantically that would be more proper.  
Thoughts?

Thanks
David



Mike Wilson wrote:

> David,
>
> I saw that you renamed testdwr.war to test-dwr.war in dwr's build.xml.
> This needs to be in sync with testdwr:build.xml, and as the mentioned
> war file is the main artifact of the testdwr project I would suggest
> to keep SVN base directory, project name, and this filename the same.
> Probably that means that we should go back to testdwr.war.
>
> Best regards
> Mike
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@...
> For additional commands, e-mail: dev-help@...
>
>
>  


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

 « Return to Thread: testdwr.war vs test-dwr.war