Re: testdwr.war vs test-dwr.war

> David Marginian wrote on den 7 april 2009 14:00:
>  
>> Do you have the latest build.xml file for each project?  I am pretty
>> sure I updated both of them.  
>>    
>
> Ah, right... :-), I hadn't updated my testdwr project. Sorry.
>
>  
>> A number of tests were failing due to:
>>
>>  public Verify checkContext()
>>     {
>>         ServerContext serverContext = ServerContextFactory.get();
>>         Container container = serverContext.getContainer();
>>         Verify verify = new Verify();
>>
>>         verify.equals("ContextPath", "/test-dwr",
>>    
>
> Ah yes, now I remember seeing this (and reacting on the name syntax)
> some time ago.
>
>  
>> Perhaps we should
>> revert my change and change the checkContext method to check
>> for testdwr
>> not test-dwr.  I agree that semantically that would be more proper.  
>> Thoughts?
>>    
>
> I think virtually every person that pops testdwr.war into an app
> server will be surprised that it fails when mounted on the default
> context path (== war-filename excl extension).
>
> I don't have a strong opinion on whether the name should have a dash
> or not, but I would like the following artifacts and configurations
> to use the same string:
> - svn base directory
> - eclipse project name
> - main artifact filename
> - expected context path (do we really need to test against this?)
>
> This means we either need to change expected context path and war
> filename, or svn base dir and eclipse project name.
>
> Best regards
> Mike
>
>  
>> Thanks
>> David
>>
>>
>>
>> Mike Wilson wrote:
>>    
>>> David,
>>>
>>> I saw that you renamed testdwr.war to test-dwr.war in dwr's
>>>      
>> build.xml.
>>    
>>> This needs to be in sync with testdwr:build.xml, and as the
>>>      
>> mentioned
>>    
>>> war file is the main artifact of the testdwr project I would suggest
>>> to keep SVN base directory, project name, and this filename
>>>      
>> the same.
>>    
>>> Probably that means that we should go back to testdwr.war.
>>>
>>> Best regards
>>> Mike
>>>
>>>
>>>      
>> ---------------------------------------------------------------------
>>    
>>> To unsubscribe, e-mail: dev-unsubscribe@...
>>> For additional commands, e-mail: dev-help@...
>>>
>>>
>>>  
>>>      
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@...
>> For additional commands, e-mail: dev-help@...
>>
>>    
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@...
> For additional commands, e-mail: dev-help@...
>
>
>