Red Hat Bugzilla #492788: need some help

[Debarshi Ray]

This concerns Glade 3.4.x, which I know is way too old to be supported
upstream. However we are shipping it as part of both Fedora 9 and
Fedora 10, and I am trying to fix the problem by carrying a downstream
patch. It is not present in Glade 3.6.x and I have not yet checked
Glade 3.5.x.

Here is the bug: https://bugzilla.redhat.com/492788

Problem is that I am not very familiar with Glade3's source code. I
have been looking at the code surrounding the "selection-changed"
signal in gladeui/glade-inspector.c and src/glade-window.c, but it
seems that I am barking up the wrong tree. Any pointers would be very
helpful.

Happy hacking,
Debarshi
--
One reason that life is complex is that it has a real part and an
imaginary part.
    -- Andrew Koenig
_______________________________________________
Glade-devel maillist  -  Glade-devel@...
http://lists.ximian.com/mailman/listinfo/glade-devel

[Tristan Van Berkom-2]

On Mon, Apr 13, 2009 at 3:24 AM, Debarshi Ray <debarshi.ray@...> wrote:

> This concerns Glade 3.4.x, which I know is way too old to be supported
> upstream. However we are shipping it as part of both Fedora 9 and
> Fedora 10, and I am trying to fix the problem by carrying a downstream
> patch. It is not present in Glade 3.6.x and I have not yet checked
> Glade 3.5.x.
>
> Here is the bug: https://bugzilla.redhat.com/492788
>
> Problem is that I am not very familiar with Glade3's source code. I
> have been looking at the code surrounding the "selection-changed"
> signal in gladeui/glade-inspector.c and src/glade-window.c, but it
> seems that I am barking up the wrong tree. Any pointers would be very
> helpful.
>

Hi,
   In Glade 3.4.x you can display any toplevel window by double
clicking on the said toplevel - this was done intentionally at the
time to dissociate navigation and widget selection, anyway after
that experiment it seems more logical to always keep selected
widgets shown in the workspace, the added search entry makes
navigation in large projects simpler anyway.

Cheers,
         -Tristan
_______________________________________________
Glade-devel maillist  -  Glade-devel@...
http://lists.ximian.com/mailman/listinfo/glade-devel

[Debarshi Ray]

>   In Glade 3.4.x you can display any toplevel window by double
> clicking on the said toplevel - this was done intentionally at the
> time to dissociate navigation and widget selection, anyway after
> that experiment it seems more logical to always keep selected
> widgets shown in the workspace,

I see.

> the added search entry makes
> navigation in large projects simpler anyway.

The search entry is only present in 3.6.x. Backporting it to 3.4.x
might be a bit too much, but is it possible to patch 3.4.x so that
selected widgets are always shown? I am not asking you to make a new
3.4.x release, but just that I was trying to do it downstream for
Fedora. Or would you say it is way too much trouble and the user is
better off upgrading.

Thanks,
Debarshi
--
One reason that life is complex is that it has a real part and an
imaginary part.
    -- Andrew Koenig
_______________________________________________
Glade-devel maillist  -  Glade-devel@...
http://lists.ximian.com/mailman/listinfo/glade-devel

[Tristan Van Berkom-2]

On Mon, Apr 13, 2009 at 10:00 PM, Debarshi Ray <debarshi.ray@...> wrote:
[...]
> The search entry is only present in 3.6.x. Backporting it to 3.4.x
> might be a bit too much, but is it possible to patch 3.4.x so that
> selected widgets are always shown? I am not asking you to make a new
> 3.4.x release, but just that I was trying to do it downstream for
> Fedora. Or would you say it is way too much trouble and the user is
> better off upgrading.

In case I made the wrong impression, I do not feel strongly about
having the workspace update on double-click in 3.4, it was my
original intention but I think most will agree the direct selection
update is better, regardless of the presence of the search entry.

I really dont have time to help you maintain a downstream patch,
honestly because I have hardly enough time to keep up with 3.6
(I barely pushed out 3.6.1 and still have one or two serious bugs
to fix), but the backporting should be a simple matter of calling
glade_widget_show() from glade-inspector.c, but you may
have some hoops to jump through (not sure, the cases in glade_widget_show()
have changed a few times...)

Cheers,
                   -Tristan
_______________________________________________
Glade-devel maillist  -  Glade-devel@...
http://lists.ximian.com/mailman/listinfo/glade-devel