Regression fix committed to svn

View: New views
4 Messages — Rating Filter:   Alert me  

Regression fix committed to svn

by colding :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi Gustavo and Michael,

I've convinced myself that I should commit as trunk+patch is much better
than what is in trunk right now.

[Gustavo] I would like to suggest a new release (2.14.9?) if your test
boxes are happy with revision 2011.


Thanks,
  jules

_______________________________________________
orbit-list mailing list
orbit-list@...
http://mail.gnome.org/mailman/listinfo/orbit-list

Re: Regression fix committed to svn

by Gustavo J. A. M. Carneiro :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


On Qua, 2007-07-25 at 14:38 +0200, Jules Colding wrote:
> Hi Gustavo and Michael,
>
> I've convinced myself that I should commit as trunk+patch is much better
> than what is in trunk right now.
>
> [Gustavo] I would like to suggest a new release (2.14.9?) if your test
> boxes are happy with revision 2011.

 I was just testing this.  Before your today's commits, the test still
fails:

Running timeout server...
Running timeout client...
=======================================================================
                ***  Starting GIOP timeout tests  ***                  
=======================================================================
Provoking timeout exception... Timeout_ping():
IDL:omg.org/CORBA/COMM_FAILURE:1.0
Shutting down GIOP timeout tests... CORBA_Object_release():
IDL:omg.org/CORBA/COMM_FAILURE:1.0
=======================================================================
             ***  Some GIOP timeout tests failed  ***                  
=======================================================================
FAIL: timeout.sh


After your commits it works OK:

Running timeout server...
Running timeout client...
=======================================================================
                ***  Starting GIOP timeout tests  ***                  
=======================================================================
Provoking timeout exception... OK
Testing reacquired connection with no server delay... OK
Testing with small server delay... OK
Provoking timeout exception... OK
Testing reacquired connection with no server delay... OK
Shutting down GIOP timeout tests... OK
=======================================================================
            ***  All GIOP timeout tests successful  ***                
=======================================================================
PASS: timeout.sh


Whatever you did, goo work.  I'm pretty happy with it now :)  Although
it would be better to get rid of the "Starting GIOP timeout test"
messages; no reason why these particular unit tests need more prominence
than any other unit tests :)

I'll make a release as soon as I get a free slot of hacking time; maybe
tonight.

Thanks a lot.

--
Gustavo J. A. M. Carneiro
<gjc@...> <gustavo@...>
"The universe is always one step beyond logic" -- Frank Herbert

_______________________________________________
orbit-list mailing list
orbit-list@...
http://mail.gnome.org/mailman/listinfo/orbit-list

Re: Regression fix committed to svn

by colding :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Wed, 2007-07-25 at 13:54 +0100, Gustavo J. A. M. Carneiro wrote:

> On Qua, 2007-07-25 at 14:38 +0200, Jules Colding wrote:
> > Hi Gustavo and Michael,
> >
> > I've convinced myself that I should commit as trunk+patch is much better
> > than what is in trunk right now.
> >
> > [Gustavo] I would like to suggest a new release (2.14.9?) if your test
> > boxes are happy with revision 2011.
>
>  I was just testing this.  Before your today's commits, the test still
> fails:
>
> Running timeout server...
> Running timeout client...
> =======================================================================
>                 ***  Starting GIOP timeout tests  ***                  
> =======================================================================
> Provoking timeout exception... Timeout_ping():
> IDL:omg.org/CORBA/COMM_FAILURE:1.0
> Shutting down GIOP timeout tests... CORBA_Object_release():
> IDL:omg.org/CORBA/COMM_FAILURE:1.0
> =======================================================================
>              ***  Some GIOP timeout tests failed  ***                  
> =======================================================================
> FAIL: timeout.sh
>
>
> After your commits it works OK:
>
> Running timeout server...
> Running timeout client...
> =======================================================================
>                 ***  Starting GIOP timeout tests  ***                  
> =======================================================================
> Provoking timeout exception... OK
> Testing reacquired connection with no server delay... OK
> Testing with small server delay... OK
> Provoking timeout exception... OK
> Testing reacquired connection with no server delay... OK
> Shutting down GIOP timeout tests... OK
> =======================================================================
>             ***  All GIOP timeout tests successful  ***                
> =======================================================================
> PASS: timeout.sh
>
>
> Whatever you did, goo work.  I'm pretty happy with it now :)  

Thanks a lot. I'm happy that it works ;-)


> Although
> it would be better to get rid of the "Starting GIOP timeout test"
> messages; no reason why these particular unit tests need more prominence
> than any other unit tests :)

Yes, no more need to make this particular test case stand out. Fix
committed (rev 2012).


> I'll make a release as soon as I get a free slot of hacking time; maybe
> tonight.

Great, thanks a lot!

Best regards,
  jules


_______________________________________________
orbit-list mailing list
orbit-list@...
http://mail.gnome.org/mailman/listinfo/orbit-list

Re: Regression fix committed to svn

by Gustavo J. A. M. Carneiro :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

  New ORBit2 released.

On Qua, 2007-07-25 at 15:23 +0200, Jules Colding wrote:

> On Wed, 2007-07-25 at 13:54 +0100, Gustavo J. A. M. Carneiro wrote:
> > On Qua, 2007-07-25 at 14:38 +0200, Jules Colding wrote:
> > > Hi Gustavo and Michael,
> > >
> > > I've convinced myself that I should commit as trunk+patch is much better
> > > than what is in trunk right now.
> > >
> > > [Gustavo] I would like to suggest a new release (2.14.9?) if your test
> > > boxes are happy with revision 2011.
> >
> >  I was just testing this.  Before your today's commits, the test still
> > fails:
> >
> > Running timeout server...
> > Running timeout client...
> > =======================================================================
> >                 ***  Starting GIOP timeout tests  ***                  
> > =======================================================================
> > Provoking timeout exception... Timeout_ping():
> > IDL:omg.org/CORBA/COMM_FAILURE:1.0
> > Shutting down GIOP timeout tests... CORBA_Object_release():
> > IDL:omg.org/CORBA/COMM_FAILURE:1.0
> > =======================================================================
> >              ***  Some GIOP timeout tests failed  ***                  
> > =======================================================================
> > FAIL: timeout.sh
> >
> >
> > After your commits it works OK:
> >
> > Running timeout server...
> > Running timeout client...
> > =======================================================================
> >                 ***  Starting GIOP timeout tests  ***                  
> > =======================================================================
> > Provoking timeout exception... OK
> > Testing reacquired connection with no server delay... OK
> > Testing with small server delay... OK
> > Provoking timeout exception... OK
> > Testing reacquired connection with no server delay... OK
> > Shutting down GIOP timeout tests... OK
> > =======================================================================
> >             ***  All GIOP timeout tests successful  ***                
> > =======================================================================
> > PASS: timeout.sh
> >
> >
> > Whatever you did, goo work.  I'm pretty happy with it now :)  
>
> Thanks a lot. I'm happy that it works ;-)
>
>
> > Although
> > it would be better to get rid of the "Starting GIOP timeout test"
> > messages; no reason why these particular unit tests need more prominence
> > than any other unit tests :)
>
> Yes, no more need to make this particular test case stand out. Fix
> committed (rev 2012).
>
>
> > I'll make a release as soon as I get a free slot of hacking time; maybe
> > tonight.
>
> Great, thanks a lot!
>
> Best regards,
>   jules
>
>
--
Gustavo J. A. M. Carneiro
<gjc@...> <gustavo@...>
"The universe is always one step beyond logic" -- Frank Herbert

_______________________________________________
orbit-list mailing list
orbit-list@...
http://mail.gnome.org/mailman/listinfo/orbit-list