Nabble - ReiserFS - General

Re: reiser4: newbie help needed?

2009-12-04T11:34:45Z

Johannes Buchner wrote:
> On Wed, 02 Dec 2009 10:21:18 +0100
> Edward Shishkin <edward.shishkin@...> wrote:
>
>
>> Johannes Buchner wrote:
>>

Hello.

>>> I took a look at the TODO lists, are there any simple tasks to
>>> do for newbies?
>>>
>> If you mean the "todo for inclusion", then no.
>>
>> Reiser4 has only one technical issue. It can
>> be resolved only by very experienced people.
>>
>
> Thanks for replying. I did not have to the inclusion of
> reiser4 in mind specifically.
>
>
>>> I also believe that on 'sync', reiser4 currently does absolutely
>>> nothing.
>>>
>> this is not good: a file system should respond on sync (1).
>>
>>
>>> The comment in reiser4_sync_inodes says reiser4 does its own
>>> flush elsewhere. Should this be different?
>>>
>>>
>> you might want to ask such question _before_ sending patches to akpm.
>>
>
> I was under the believe that I did not change the behaviour. I see my
> mistake now, I was looking at the wrong if-branch.
>

Nop. You've lost the whole point of using of ->sync_inodes(), which is
responsible for reiser4 background (and non-background) writeback,
and now it is not involved by any path.

Here is a good explanation why we need this additional super operation:
http://kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc3/2.6.21-rc3-mm1/broken-out/reiser4-sb_sync_inodes.patch

> I tried now to come up with a correct version for some hours, but I keep
> having NULL problems. Maybe a writeback_control object has to be
> created, possibly even in fs/fs-writeback.c:sync_inodes_sb, as
> write_inode_now does below. I tried that too, but it gave me a
> recursion.

It may happens because of missed checks that a process is of pdflush-style.
Perhaps, we need to rename the current_is_pdflush() and get it back.

Thanks,
Edward.

> I'm not sure what the rationale was for introducing a call
> with NULL here. Sorry I can't correct this.
>
> Looking forward to your review.
>
> Best wishes,
> Johannes
>
>

--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@...
More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: reiser4: newbie help needed?

2009-12-03T12:25:27Z

On Wed, 02 Dec 2009 10:21:18 +0100
Edward Shishkin <edward.shishkin@...> wrote:

> Johannes Buchner wrote:
> > I took a look at the TODO lists, are there any simple tasks to
> > do for newbies?
>
> If you mean the "todo for inclusion", then no.
>
> Reiser4 has only one technical issue. It can
> be resolved only by very experienced people.

Thanks for replying. I did not have to the inclusion of
reiser4 in mind specifically.

> > I also believe that on 'sync', reiser4 currently does absolutely
> > nothing.
>
> this is not good: a file system should respond on sync (1).
>
> > The comment in reiser4_sync_inodes says reiser4 does its own
> > flush elsewhere. Should this be different?
> >
>
> you might want to ask such question _before_ sending patches to akpm.

I was under the believe that I did not change the behaviour. I see my
mistake now, I was looking at the wrong if-branch.

I tried now to come up with a correct version for some hours, but I keep
having NULL problems. Maybe a writeback_control object has to be
created, possibly even in fs/fs-writeback.c:sync_inodes_sb, as
write_inode_now does below. I tried that too, but it gave me a
recursion. I'm not sure what the rationale was for introducing a call
with NULL here. Sorry I can't correct this.

Looking forward to your review.

Best wishes,
Johannes

--
Emails können geändert, gefälscht und eingesehen werden. Signiere oder
verschüssele deine Mails mit GPG.

attachment0 (205 bytes) Download Attachment

Re: Cryptocompress

2009-12-03T01:51:52Z

Jonáš Vidra wrote:
> Dne Thu, 03 Dec 2009 02:27:32 +0100 drwowe <drwowe@...> wrote:
>
>>
>> hello,
>> What is the status of the cryptcompress feature? Is it stable enough
>> for
>> desktop use, or only for experimentation?
>
> Compression works and is stable,

The last complaint was on fsck ~1 yeah ago. Fixed.

> encryption is not implemented and it seems it never will be.

Actually it is implemented on a low level. Moreover,
long time ago I got a reiser4 partition transparently
compressed and ciphered by aes ecb. The problem
was that Linux didn't have a good key manager. Now
I believe that the situation is improved, so in order to
announce encryption we need:

1. a fast iv-generator stable to watermark attack for
cbc encryption mode;
2. to adjust any convenient key manager to perform
encryption per file/directory/volume.

I estimate the complexity of this task as 2 of 5.

Thanks,
Edward.

>
>
>
>> Also, is there any documentation that explains how to use the
>> feature? I
>> seem to recall there was a mount options that turns it on, but also
>> to use
>> it I need to know how to do key management for encrypting files which I
>> haven't found.
>
> For compression, just format the FS with -o create=ccreg40.
> I also recommend setting hash to tea, since r5 hashing usually generates
> collisions for me, especially when compiling big stuff like GCC or
> OO.org,
> leading to minor corruptions requiring an offline fsck.
>

--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@...
More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Cryptocompress

2009-12-02T21:36:12Z

Dne Thu, 03 Dec 2009 02:27:32 +0100 drwowe <drwowe@...> wrote:

>
> hello,
> What is the status of the cryptcompress feature? Is it stable enough for
> desktop use, or only for experimentation?

Compression works and is stable, encryption is not implemented and it
seems it never will be.

> Also, is there any documentation that explains how to use the feature? I
> seem to recall there was a mount options that turns it on, but also to
> use
> it I need to know how to do key management for encrypting files which I
> haven't found.

For compression, just format the FS with -o create=ccreg40.
I also recommend setting hash to tea, since r5 hashing usually generates
collisions for me, especially when compiling big stuff like GCC or OO.org,
leading to minor corruptions requiring an offline fsck.

--
JonÃ¡Å¡ Vidra, vidra.jonas@...
--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@...
More majordomo info at http://vger.kernel.org/majordomo-info.html

Cryptocompress

2009-12-02T17:27:32Z

hello,
What is the status of the cryptcompress feature? Is it stable enough for desktop use, or only for experimentation?
Also, is there any documentation that explains how to use the feature? I seem to recall there was a mount options that turns it on, but also to use it I need to know how to do key management for encrypting files which I haven't found.

Re: reiser4 for 2.6.33?

2009-12-02T17:22:20Z

Edward Shishkin-2 wrote:

Actually there is no hurry. Taking into account common situation
with file systems, I am not afraid that reiser4 will get obsolete.

This is a very interesting comment.
Can you explain what you mean?

Re: reiser4: newbie help needed?

2009-12-02T01:21:18Z

Johannes Buchner wrote:
> Hi!
>
> I am possibly interested in helping out. Who is currently working on
> reiser4?

Nobody.
Because there is no bugreports.

> I took a look at the TODO lists, are there any simple tasks to
> do for newbies?
>

If you mean the "todo for inclusion", then no.

Reiser4 has only one technical issue. It can
be resolved only by very experienced people.

> Also, where is the latest code development going on?
>

in -mm

> I also believe that on 'sync', reiser4 currently does absolutely
> nothing.

this is not good: a file system should respond on sync (1).

> The comment in reiser4_sync_inodes says reiser4 does its own
> flush elsewhere. Should this be different?
>

you might want to ask such question _before_ sending patches to akpm.

BTW excellent comment, what is not clear?

/**
* reiser4_sync_inodes - sync_inodes of super operations
* @super:
* @wbc:
*
* This method is called by background and non-backgound writeback.
Reiser4's
* implementation uses generic_sync_sb_inodes to call reiser4_writepages for
* each of dirty inodes. Reiser4_writepages handles pages dirtied via shared
* mapping - dirty pages get into atoms. Writeout is called to flush some
* atoms.
*/

Edward.
--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@...
More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: + reiser4-generic_sync_sb_inodes-doesnt-exist-anymore.patch added to -mm tree

2009-12-02T00:47:44Z

I am not sure if it works correctly (still don't have
a time to adjust reiser4 for the per-bdi stuff).

Well, let it be, I'll ack or make corrections later..

Thanks,
Edward.

akpm@... wrote:

> The patch titled
> reiser4: generic_sync_sb_inodes doesn't exist anymore
> has been added to the -mm tree. Its filename is
> reiser4-generic_sync_sb_inodes-doesnt-exist-anymore.patch
>
> Before you just go and hit "reply", please:
> a) Consider who else should be cc'ed
> b) Prefer to cc a suitable mailing list as well
> c) Ideally: find the original patch on the mailing list and do a
> reply-to-all to that, adding suitable additional cc's
>
> *** Remember to use Documentation/SubmitChecklist when testing your code ***
>
> See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
> out what to do about this
>
> The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
>
> ------------------------------------------------------
> Subject: reiser4: generic_sync_sb_inodes doesn't exist anymore
> From: Johannes Buchner <buchner.johannes@...>
>
>
>> generic_sync_sb_inodes was removed in d8a8559cd7a9cc,
>> writeback_inodes_sb and sync_inodes_sb should replace them.
>>
> Second version, now also fixes the last comments relating to
> generic_sync_sb_inodes.
>
> Cc: Edward Shishkin <edward.shishkin@...>
> Signed-off-by: Andrew Morton <akpm@...>
> ---
>
> fs/reiser4/context.h | 2 +-
> fs/reiser4/entd.c | 4 +++-
> fs/reiser4/super_ops.c | 6 ++++--
> 3 files changed, 8 insertions(+), 4 deletions(-)
>
> diff -puN fs/reiser4/context.h~reiser4-generic_sync_sb_inodes-doesnt-exist-anymore fs/reiser4/context.h
> --- a/fs/reiser4/context.h~reiser4-generic_sync_sb_inodes-doesnt-exist-anymore
> +++ a/fs/reiser4/context.h
> @@ -66,7 +66,7 @@ struct reiser4_context {
> /* count non-trivial jnode_set_dirty() calls */
> unsigned long nr_marked_dirty;
>
> - /* reiser4_sync_inodes calls (via generic_sync_sb_inodes)
> + /* reiser4_sync_inodes calls (via writeback/sync_inodes_sb)
> * reiser4_writepages for each of dirty inodes. Reiser4_writepages
> * captures pages. When number of pages captured in one
> * reiser4_sync_inodes reaches some threshold - some atoms get
> diff -puN fs/reiser4/entd.c~reiser4-generic_sync_sb_inodes-doesnt-exist-anymore fs/reiser4/entd.c
> --- a/fs/reiser4/entd.c~reiser4-generic_sync_sb_inodes-doesnt-exist-anymore
> +++ a/fs/reiser4/entd.c
> @@ -241,7 +241,9 @@ static void entd_flush(struct super_bloc
> if (rq->wbc->nr_to_write > 0) {
> rq->wbc->range_start = 0;
> rq->wbc->range_end = LLONG_MAX;
> - generic_sync_sb_inodes(rq->wbc);
> + writeback_inodes_sb(super);
> + if (rq->wbc->sync_mode == WB_SYNC_ALL)
> + sync_inodes_sb(super);
> }
> rq->wbc->nr_to_write = ENTD_CAPTURE_APAGE_BURST;
> reiser4_writeout(super, rq->wbc);
> diff -puN fs/reiser4/super_ops.c~reiser4-generic_sync_sb_inodes-doesnt-exist-anymore fs/reiser4/super_ops.c
> --- a/fs/reiser4/super_ops.c~reiser4-generic_sync_sb_inodes-doesnt-exist-anymore
> +++ a/fs/reiser4/super_ops.c
> @@ -384,7 +384,7 @@ static void reiser4_clear_inode(struct i
> * @wbc:
> *
> * This method is called by background and non-backgound writeback. Reiser4's
> - * implementation uses generic_sync_sb_inodes to call reiser4_writepages for
> + * implementation uses writeback/sync_inodes_sb to call reiser4_writepages for
> * each of dirty inodes. Reiser4_writepages handles pages dirtied via shared
> * mapping - dirty pages get into atoms. Writeout is called to flush some
> * atoms.
> @@ -412,7 +412,9 @@ static void reiser4_sync_inodes(struct s
> * call reiser4_writepages for each of dirty inodes to turn dirty pages
> * into transactions if they were not yet.
> */
> - generic_sync_sb_inodes(wbc);
> + writeback_inodes_sb(super);
> + if (wbc->sync_mode == WB_SYNC_ALL)
> + sync_inodes_sb(super);
>
> /* flush goes here */
> wbc->nr_to_write = to_write;
> _
>
> Patches currently in -mm which might be from buchner.johannes@... are
>
> reiser4-some-changes-from-reiser4-2631-patch.patch
> reiser4-some-comments-were-still-mentioning-pdflush.patch
> reiser4-generic_sync_sb_inodes-doesnt-exist-anymore.patch
> reiser4-fixed-null-pointer-dereference.patch
>
>
>

--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@...
More majordomo info at http://vger.kernel.org/majordomo-info.html

reiser4: newbie help needed?

2009-12-01T22:21:43Z

Hi!

I am possibly interested in helping out. Who is currently working on
reiser4? I took a look at the TODO lists, are there any simple tasks to
do for newbies?
Also, where is the latest code development going on?

I also believe that on 'sync', reiser4 currently does absolutely
nothing. The comment in reiser4_sync_inodes says reiser4 does its own
flush elsewhere. Should this be different?

Cheers,
Johannes

--
Emails können geändert, gefälscht und eingesehen werden. Signiere oder
verschüssele deine Mails mit GPG.

attachment0 (205 bytes) Download Attachment

Re: Fw: reiser4 git repo

2009-11-29T13:44:24Z

On Fri, Nov 27, 2009 at 8:14 PM, Johannes Buchner
<buchner.johannes@...> wrote:
> Hi,
>

Hello

> I had some issues with the reiser4 patch series from -mm.
> First of all, I'm not sure what release they are based on. I used
> a8a8a669e from Linus' git repository. I applied all reiser4 patches
> (except reiser4-disable of course) from
> http://userweb.kernel.org/~akpm/mmotm/, which worked fine.
>
> I think these patches are based on the reiser4-2.6.30 patch.
> I also compared them to the reiser4-2.6.31 patch, which adds some
> missing pieces ([1] reiser4-from-2.6.31-patch.patch).
>
> Additionally, some recent commits demand some changes, especially
> since current_is_pdflush and generic_sync_sb_inodes are not available
> any more (d8a8559cd7a9cc).
> [2] reiser4-pdflush-comments.patch only fixes some comments which still
> mention pdflush.
> In [3] reiser4-generic_sync_sb_inodes.patch I tried to
> replace generic_sync_sb_inodes. I am not 100% sure that this is
> correct, but that is what I understood from the commit diff+message of
> d8a8559cd7a9cc.
>
> The original patch
> 'reiser4-vfs-add-super_operationssync_inodes' introduced the call from
> sync_inodes_sb to the super operation sync_inodes(sb, NULL). This NULL
> pointer is dereferenced in reiser4_sync_inodes, which is fixed by
> [4] reiser4-sync_inodes-null-dereference.patch.
>
> All 4 additional patches are attached. I can only say that it works on
> my machine, before I had compilation issues and freezes on 'sync'.
>
> Cheers,
> Johannes
>
> PS: The git repo mentioned in
> http://userweb.kernel.org/~akpm/mmotm/mmotm-readme.txt is not available.
>

Yeah, you can find it now at git.zen-kernel.org. They had to switch the adress.

Have fun

Dushan

> On Fri, 27 Nov 2009 04:00:51 +0100
> Frederic Weisbecker <fweisbec@...> wrote:
>
>> On Fri, Nov 27, 2009 at 03:51:48PM +1300, Johannes Buchner wrote:
>> > [ I sent this 2 days ago to linux-fsdevel@..., maybe
>> > I'll get more responses in here. ]
>> >
>> > Hi!
>> >
>> > I would like to keep a git repo up to date with current kernel
>> > development, with reiser4 patched in. I am having trouble finding a
>> > repo that provides reiser4. Is there one?
>> >
>> > Some people may have noticed the last patch doesn't apply cleanly
>> > anymore. I made a few lines of modifications in my local repo. Maybe
>> > that repo would be interesting for others too*.
>> >
>> > I plan to catch up with changes from kernel development on a
>> > daily/weekly basis; my /home partition is reiser4, so I am fairly
>> > serious about it.
>> >
>> > At the moment, I fetch from torvalds/linux-2.6.git and
>> > stable/linux-2.6.31.y.git. Am I missing any other repositories that
>> > I should try to keep up with? (A fs subsystem maintainer repo?)
>> > next/linux-next.git is probably moving too fast for me.
>>
>>
>> You can try the -mm tree, the reiser 4 patches can be found inside:
>>
>> http://userweb.kernel.org/~akpm/mmotm/
>
> --
> Emails können geändert, gefälscht und eingesehen werden. Signiere oder
> verschüssele deine Mails mit GPG.
> http://web.student.tuwien.ac.at/~e0625457/pgp.html
>
>
>

--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@...
More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/4] reiser4: generic_sync_sb_inodes doesn't exist anymore

2009-11-29T03:28:33Z

> generic_sync_sb_inodes was removed in d8a8559cd7a9cc,
> writeback_inodes_sb and sync_inodes_sb should replace them.
Second version, now also fixes the last comments relating to
generic_sync_sb_inodes.

---
fs/reiser4/context.h | 2 +-
fs/reiser4/entd.c | 4 +++-
fs/reiser4/super_ops.c | 6 ++++--
3 files changed, 8 insertions(+), 4 deletions(-)

Index: linux/fs/reiser4/entd.c
===================================================================
--- linux.orig/fs/reiser4/entd.c
+++ linux/fs/reiser4/entd.c
@@ -241,7 +241,9 @@ static void entd_flush(struct super_bloc
if (rq->wbc->nr_to_write > 0) {
rq->wbc->range_start = 0;
rq->wbc->range_end = LLONG_MAX;
- generic_sync_sb_inodes(rq->wbc);
+ writeback_inodes_sb(super);
+ if (rq->wbc->sync_mode == WB_SYNC_ALL)
+ sync_inodes_sb(super);
}
rq->wbc->nr_to_write = ENTD_CAPTURE_APAGE_BURST;
reiser4_writeout(super, rq->wbc);
Index: linux/fs/reiser4/super_ops.c
===================================================================
--- linux.orig/fs/reiser4/super_ops.c
+++ linux/fs/reiser4/super_ops.c
@@ -384,7 +384,7 @@ static void reiser4_clear_inode(struct i
* @wbc:
*
* This method is called by background and non-backgound writeback. Reiser4's
- * implementation uses generic_sync_sb_inodes to call reiser4_writepages for
+ * implementation uses writeback/sync_inodes_sb to call reiser4_writepages for
* each of dirty inodes. Reiser4_writepages handles pages dirtied via shared
* mapping - dirty pages get into atoms. Writeout is called to flush some
* atoms.
@@ -412,7 +412,9 @@ static void reiser4_sync_inodes(struct s
* call reiser4_writepages for each of dirty inodes to turn dirty pages
* into transactions if they were not yet.
*/
- generic_sync_sb_inodes(wbc);
+ writeback_inodes_sb(super);
+ if (wbc->sync_mode == WB_SYNC_ALL)
+ sync_inodes_sb(super);

/* flush goes here */
wbc->nr_to_write = to_write;
Index: linux/fs/reiser4/context.h
===================================================================
--- linux.orig/fs/reiser4/context.h
+++ linux/fs/reiser4/context.h
@@ -66,7 +66,7 @@ struct reiser4_context {
/* count non-trivial jnode_set_dirty() calls */
unsigned long nr_marked_dirty;

- /* reiser4_sync_inodes calls (via generic_sync_sb_inodes)
+ /* reiser4_sync_inodes calls (via writeback/sync_inodes_sb)
* reiser4_writepages for each of dirty inodes. Reiser4_writepages
* captures pages. When number of pages captured in one
* reiser4_sync_inodes reaches some threshold - some atoms get
--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@...
More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/4] reiser4: some changes from reiser4-2.6.31 patch

2009-11-29T03:28:31Z

> from
> http://www.kernel.org/pub/linux/kernel/people/edward/reiser4/reiser4-for-2.6/
I'm sorry, I did not see half of this is already covered by
vfs-take-2add-set_page_dirty_notag.patch. With that part removed,
this patch is only cosmetics now.

---
fs/reiser4/carry.c | 2 +-
fs/reiser4/carry_ops.c | 2 +-
fs/reiser4/znode.h | 1 -
mm/filemap.c | 2 +-
4 files changed, 3 insertions(+), 4 deletions(-)

Index: linux/fs/reiser4/carry.c
===================================================================
--- linux.orig/fs/reiser4/carry.c
+++ linux/fs/reiser4/carry.c
@@ -1095,7 +1095,7 @@ static void fatal_carry_error(carry_leve
*
* This function itself only manages changes in carry structures and delegates
* all hard work (allocation of znode for new root, changes of parent and
- * sibling pointers to the reiser4_add_tree_root().
+ * sibling pointers) to the reiser4_add_tree_root().
*
* Locking: old tree root is locked by carry at this point. Fake znode is also
* locked.
Index: linux/fs/reiser4/carry_ops.c
===================================================================
--- linux.orig/fs/reiser4/carry_ops.c
+++ linux/fs/reiser4/carry_ops.c
@@ -2015,7 +2015,7 @@ static int carry_estimate_bitmaps(void)
int bytes;

bytes = capped_height() * (0 + /* bnode should be added, but
- * its is private to bitmap.c,
+ * it is private to bitmap.c,
* skip for now. */
2 * sizeof(jnode));
/* working and commit jnodes */
Index: linux/fs/reiser4/znode.h
===================================================================
--- linux.orig/fs/reiser4/znode.h
+++ linux/fs/reiser4/znode.h
@@ -18,7 +18,6 @@

#include <linux/types.h>
#include <linux/spinlock.h>
-#include <linux/semaphore.h>
#include <linux/pagemap.h> /* for PAGE_CACHE_SIZE */
#include <asm/atomic.h>

Index: linux/mm/filemap.c
===================================================================
--- linux.orig/mm/filemap.c
+++ linux/mm/filemap.c
@@ -800,7 +802,6 @@ repeat:
rcu_read_unlock();
return ret;
}
-EXPORT_SYMBOL(find_get_pages);

/**
* find_get_pages_contig - gang contiguous pagecache lookup
@@ -970,6 +971,7 @@ static void shrink_readahead_size_eio(st
{
ra->ra_pages /= 4;
}
+EXPORT_SYMBOL(find_get_pages);

/**
* do_generic_file_read - generic file read routine
--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@...
More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 4/4] reiser4: fixed null pointer dereference

2009-11-27T22:28:04Z

The parameter wbc=NULL caused a NULL pointer dereference in
reiser4_sync_inodes.
This issue was introduced in patch reiser4-vfs-add-super_operationssync_inodes
---
fs/reiser4/super_ops.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/reiser4/super_ops.c b/fs/reiser4/super_ops.c
index 0c09e3e..f72d42a 100644
--- a/fs/reiser4/super_ops.c
+++ b/fs/reiser4/super_ops.c
@@ -395,7 +395,7 @@ static void reiser4_sync_inodes(struct super_block *super,
reiser4_context *ctx;
long to_write;

- if (wbc->for_kupdate)
+ if (wbc == NULL || wbc->for_kupdate)
/* reiser4 has its own means of periodical write-out */
return;

--
1.6.4.4

--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@...
More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 3/4] reiser4: generic_sync_sb_inodes doesn't exist anymore

2009-11-27T22:28:03Z

generic_sync_sb_inodes was removed in d8a8559cd7a9cc, writeback_inodes_sb
and sync_inodes_sb should replace them.
---
fs/reiser4/entd.c | 4 +++-
fs/reiser4/super_ops.c | 4 +++-
2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/fs/reiser4/entd.c b/fs/reiser4/entd.c
index f41f62d..3a26451 100644
--- a/fs/reiser4/entd.c
+++ b/fs/reiser4/entd.c
@@ -241,7 +241,9 @@ static void entd_flush(struct super_block *super, struct wbq *rq)
if (rq->wbc->nr_to_write > 0) {
rq->wbc->range_start = 0;
rq->wbc->range_end = LLONG_MAX;
- generic_sync_sb_inodes(super, rq->wbc);
+ writeback_inodes_sb(super);
+ if (rq->wbc->sync_mode == WB_SYNC_ALL)
+ sync_inodes_sb(super);
}
rq->wbc->nr_to_write = ENTD_CAPTURE_APAGE_BURST;
reiser4_writeout(super, rq->wbc);
diff --git a/fs/reiser4/super_ops.c b/fs/reiser4/super_ops.c
index 85e6841..0c09e3e 100644
--- a/fs/reiser4/super_ops.c
+++ b/fs/reiser4/super_ops.c
@@ -412,7 +412,9 @@ static void reiser4_sync_inodes(struct super_block *super,
* call reiser4_writepages for each of dirty inodes to turn dirty pages
* into transactions if they were not yet.
*/
- generic_sync_sb_inodes(super, wbc);
+ writeback_inodes_sb(super);
+ if (wbc->sync_mode == WB_SYNC_ALL)
+ sync_inodes_sb(super);

/* flush goes here */
wbc->nr_to_write = to_write;
--
1.6.4.4

--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@...
More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 2/4] reiser4: some comments were still mentioning pdflush

2009-11-27T22:28:02Z

---
fs/reiser4/context.c | 2 +-
fs/reiser4/txnmgr.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/reiser4/context.c b/fs/reiser4/context.c
index eed3efa..248a21f 100644
--- a/fs/reiser4/context.c
+++ b/fs/reiser4/context.c
@@ -147,7 +147,7 @@ static void reiser4_throttle_write_at(reiser4_context *context)
* call balance_dirty_pages_ratelimited() to process formatted nodes
* dirtied during this system call. Do that only if we are not in mount
* and there were nodes dirtied in this context and we are not in
- * writepage (to avoid deadlock) and not in pdflush
+ * writepage (to avoid deadlock)
*/
if (sbinfo != NULL && sbinfo->fake != NULL &&
context->nr_marked_dirty != 0 &&
diff --git a/fs/reiser4/txnmgr.c b/fs/reiser4/txnmgr.c
index 74b49f2..844d19e 100644
--- a/fs/reiser4/txnmgr.c
+++ b/fs/reiser4/txnmgr.c
@@ -1360,7 +1360,7 @@ static int txn_try_to_fuse_small_atom(txn_mgr * tmgr, txn_atom * atom)
code tries to flush current atom.

flush_some_atom() is called as part of memory clearing process. It is
- invoked from balance_dirty_pages(), pdflushd, and entd.
+ invoked from balance_dirty_pages() and entd.

If we can flush no nodes, atom is committed, because this frees memory.

@@ -1469,7 +1469,7 @@ flush_some_atom(jnode * start, long *nr_submitted, const struct writeback_contro
* or atom is too old/large,
* we force current atom to commit */
/* wait for commit completion but only if this
- * wouldn't stall pdflushd and ent thread. */
+ * wouldn't stall ent thread. */
if (!wbc->nonblocking && !ctx->entd)
txnh->flags |= TXNH_WAIT_COMMIT;
atom->flags |= ATOM_FORCE_COMMIT;
--
1.6.4.4

--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@...
More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/4] reiser4: some changes from reiser4-2.6.31 patch

2009-11-27T22:28:01Z

from
http://www.kernel.org/pub/linux/kernel/people/edward/reiser4/reiser4-for-2.6/
---
fs/reiser4/carry.c | 2 +-
fs/reiser4/carry_ops.c | 2 +-
fs/reiser4/coord.c | 8 ++++----
fs/reiser4/entd.c | 2 +-
fs/reiser4/super_ops.c | 2 +-
fs/reiser4/znode.h | 1 -
include/linux/mm.h | 1 +
mm/filemap.c | 4 +++-
mm/page-writeback.c | 26 ++++++++++++++++++++++++++
9 files changed, 38 insertions(+), 10 deletions(-)

diff --git a/fs/reiser4/carry.c b/fs/reiser4/carry.c
index f2f1422..13a03f4 100644
--- a/fs/reiser4/carry.c
+++ b/fs/reiser4/carry.c
@@ -1095,7 +1095,7 @@ static void fatal_carry_error(carry_level * doing UNUSED_ARG /* carry level
*
* This function itself only manages changes in carry structures and delegates
* all hard work (allocation of znode for new root, changes of parent and
- * sibling pointers to the reiser4_add_tree_root().
+ * sibling pointers) to the reiser4_add_tree_root().
*
* Locking: old tree root is locked by carry at this point. Fake znode is also
* locked.
diff --git a/fs/reiser4/carry_ops.c b/fs/reiser4/carry_ops.c
index 0906dbd..4fe0e6e 100644
--- a/fs/reiser4/carry_ops.c
+++ b/fs/reiser4/carry_ops.c
@@ -2015,7 +2015,7 @@ static int carry_estimate_bitmaps(void)
int bytes;

bytes = capped_height() * (0 + /* bnode should be added, but
- * its is private to bitmap.c,
+ * it is private to bitmap.c,
* skip for now. */
2 * sizeof(jnode));
/* working and commit jnodes */
diff --git a/fs/reiser4/coord.c b/fs/reiser4/coord.c
index e37e2f9..5c34e0a 100644
--- a/fs/reiser4/coord.c
+++ b/fs/reiser4/coord.c
@@ -36,12 +36,12 @@ void coord_normalize(coord_t *coord)

coord_clear_iplug(coord);

- if (node_is_empty(node))
+ if (node_is_empty(node)) {
coord_init_first_unit(coord, node);
- else if ((coord->between == AFTER_ITEM)
- || (coord->between == AFTER_UNIT))
+ } else if ((coord->between == AFTER_ITEM)
+ || (coord->between == AFTER_UNIT)) {
return;
- else if (coord->item_pos == coord_num_items(coord)
+ } else if (coord->item_pos == coord_num_items(coord)
&& coord->between == BEFORE_ITEM) {
coord_dec_item_pos(coord);
coord->between = AFTER_ITEM;
diff --git a/fs/reiser4/entd.c b/fs/reiser4/entd.c
index 4ea64a8..f41f62d 100644
--- a/fs/reiser4/entd.c
+++ b/fs/reiser4/entd.c
@@ -241,7 +241,7 @@ static void entd_flush(struct super_block *super, struct wbq *rq)
if (rq->wbc->nr_to_write > 0) {
rq->wbc->range_start = 0;
rq->wbc->range_end = LLONG_MAX;
- generic_sync_sb_inodes(rq->wbc);
+ generic_sync_sb_inodes(super, rq->wbc);
}
rq->wbc->nr_to_write = ENTD_CAPTURE_APAGE_BURST;
reiser4_writeout(super, rq->wbc);
diff --git a/fs/reiser4/super_ops.c b/fs/reiser4/super_ops.c
index efc2d7b..85e6841 100644
--- a/fs/reiser4/super_ops.c
+++ b/fs/reiser4/super_ops.c
@@ -412,7 +412,7 @@ static void reiser4_sync_inodes(struct super_block *super,
* call reiser4_writepages for each of dirty inodes to turn dirty pages
* into transactions if they were not yet.
*/
- generic_sync_sb_inodes(wbc);
+ generic_sync_sb_inodes(super, wbc);

/* flush goes here */
wbc->nr_to_write = to_write;
diff --git a/fs/reiser4/znode.h b/fs/reiser4/znode.h
index 4894e92..7e84371 100644
--- a/fs/reiser4/znode.h
+++ b/fs/reiser4/znode.h
@@ -18,7 +18,6 @@

#include <linux/types.h>
#include <linux/spinlock.h>
-#include <linux/semaphore.h>
#include <linux/pagemap.h> /* for PAGE_CACHE_SIZE */
#include <asm/atomic.h>

diff --git a/include/linux/mm.h b/include/linux/mm.h
index e935946..f185d15 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -836,6 +836,7 @@ int redirty_page_for_writepage(struct writeback_control *wbc,
void account_page_dirtied(struct page *page, struct address_space *mapping);
int set_page_dirty(struct page *page);
int set_page_dirty_lock(struct page *page);
+int set_page_dirty_notag(struct page *page);
int clear_page_dirty_for_io(struct page *page);

extern unsigned long move_page_tables(struct vm_area_struct *vma,
diff --git a/mm/filemap.c b/mm/filemap.c
index 429489b..e7c57d5 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -139,6 +139,7 @@ void __remove_from_page_cache(struct page *page)
dec_bdi_stat(mapping->backing_dev_info, BDI_RECLAIMABLE);
}
}
+EXPORT_SYMBOL(__remove_from_page_cache);

void remove_from_page_cache(struct page *page)
{
@@ -151,6 +152,7 @@ void remove_from_page_cache(struct page *page)
spin_unlock_irq(&mapping->tree_lock);
mem_cgroup_uncharge_cache_page(page);
}
+EXPORT_SYMBOL(remove_from_page_cache);

static int sync_page(void *word)
{
@@ -800,7 +802,6 @@ repeat:
rcu_read_unlock();
return ret;
}
-EXPORT_SYMBOL(find_get_pages);

/**
* find_get_pages_contig - gang contiguous pagecache lookup
@@ -970,6 +971,7 @@ static void shrink_readahead_size_eio(struct file *filp,
{
ra->ra_pages /= 4;
}
+EXPORT_SYMBOL(find_get_pages);

/**
* do_generic_file_read - generic file read routine
diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index 6d5d74f..8cfd5f0 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -1143,6 +1143,32 @@ int __set_page_dirty_nobuffers(struct page *page)
EXPORT_SYMBOL(__set_page_dirty_nobuffers);

/*
+ * set_page_dirty_notag() -- similar to __set_page_dirty_nobuffers()
+ * except it doesn't tag the page dirty in the page-cache radix tree.
+ * This means that the address space using this cannot use the regular
+ * filemap ->writepages() helpers and must provide its own means of
+ * tracking and finding non-tagged dirty pages.
+ *
+ * NOTE: furthermore, this version also doesn't handle truncate races.
+ */
+int set_page_dirty_notag(struct page *page)
+{
+ struct address_space *mapping = page->mapping;
+
+ if (!TestSetPageDirty(page)) {
+ unsigned long flags;
+ WARN_ON_ONCE(!PagePrivate(page) && !PageUptodate(page));
+ local_irq_save(flags);
+ account_page_dirtied(page, mapping);
+ local_irq_restore(flags);
+ __mark_inode_dirty(mapping->host, I_DIRTY_PAGES);
+ return 1;
+ }
+ return 0;
+}
+EXPORT_SYMBOL(set_page_dirty_notag);
+
+/*
* When a writepage implementation decides that it doesn't want to write this
* page for some reason, it should redirty the locked page via
* redirty_page_for_writepage() and it should then unlock the page and return 0
--
1.6.4.4

--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@...
More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 0/4] reiser4 fixes for -mm

2009-11-27T22:28:00Z

These are the same patches as a previous email with the subject
'Re: Fw: reiser4 git repo', but without MIME.

The content of my previous mail:

> I had some issues with the reiser4 patch series from -mm.
> First of all, I'm not sure what release they are based on. I used
> a8a8a669e from Linus' git repository. I applied all reiser4 patches
> (except reiser4-disable of course) from
> http://userweb.kernel.org/~akpm/mmotm/, which worked fine.
>
> I think these patches are based on the reiser4-2.6.30 patch.
> I also compared them to the reiser4-2.6.31 patch, which adds some
> missing pieces ([1] reiser4-from-2.6.31-patch.patch).
>
> Additionally, some recent commits demand some changes, especially
> since current_is_pdflush and generic_sync_sb_inodes are not available
> any more (d8a8559cd7a9cc).
> [2] reiser4-pdflush-comments.patch only fixes some comments which
> still mention pdflush.
> In [3] reiser4-generic_sync_sb_inodes.patch I tried to
> replace generic_sync_sb_inodes. I am not 100% sure that this is
> correct, but that is what I understood from the commit diff+message of
> d8a8559cd7a9cc.
>
> The original patch
> 'reiser4-vfs-add-super_operationssync_inodes' introduced the call from
> sync_inodes_sb to the super operation sync_inodes(sb, NULL). This NULL
> pointer is dereferenced in reiser4_sync_inodes, which is fixed by
> [4] reiser4-sync_inodes-null-dereference.patch.
>
> All 4 additional patches are attached. I can only say that it works on
> my machine, before I had compilation issues and freezes on 'sync'.
>
> Cheers,
> Johannes
>
> PS: The git repo mentioned in
> http://userweb.kernel.org/~akpm/mmotm/mmotm-readme.txt is not
> available.

Johannes Buchner (4):
reiser4: some changes from reiser4-2.6.31 patch
reiser4: some comments were still mentioning pdflush
reiser4: generic_sync_sb_inodes doesn't exist anymore
reiser4: fixed null pointer dereference

fs/reiser4/carry.c | 2 +-
fs/reiser4/carry_ops.c | 2 +-
fs/reiser4/context.c | 2 +-
fs/reiser4/coord.c | 8 ++++----
fs/reiser4/entd.c | 4 +++-
fs/reiser4/super_ops.c | 6 ++++--
fs/reiser4/txnmgr.c | 4 ++--
fs/reiser4/znode.h | 1 -
include/linux/mm.h | 1 +
mm/filemap.c | 4 +++-
mm/page-writeback.c | 26 ++++++++++++++++++++++++++
11 files changed, 46 insertions(+), 14 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@...
More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Fw: reiser4 git repo

2009-11-27T11:14:40Z

Hi,

I had some issues with the reiser4 patch series from -mm.
First of all, I'm not sure what release they are based on. I used
a8a8a669e from Linus' git repository. I applied all reiser4 patches
(except reiser4-disable of course) from
http://userweb.kernel.org/~akpm/mmotm/, which worked fine.

I think these patches are based on the reiser4-2.6.30 patch.
I also compared them to the reiser4-2.6.31 patch, which adds some
missing pieces ([1] reiser4-from-2.6.31-patch.patch).

Additionally, some recent commits demand some changes, especially
since current_is_pdflush and generic_sync_sb_inodes are not available
any more (d8a8559cd7a9cc).
[2] reiser4-pdflush-comments.patch only fixes some comments which still
mention pdflush.
In [3] reiser4-generic_sync_sb_inodes.patch I tried to
replace generic_sync_sb_inodes. I am not 100% sure that this is
correct, but that is what I understood from the commit diff+message of
d8a8559cd7a9cc.

The original patch
'reiser4-vfs-add-super_operationssync_inodes' introduced the call from
sync_inodes_sb to the super operation sync_inodes(sb, NULL). This NULL
pointer is dereferenced in reiser4_sync_inodes, which is fixed by
[4] reiser4-sync_inodes-null-dereference.patch.

All 4 additional patches are attached. I can only say that it works on
my machine, before I had compilation issues and freezes on 'sync'.

Cheers,
Johannes

PS: The git repo mentioned in
http://userweb.kernel.org/~akpm/mmotm/mmotm-readme.txt is not available.

On Fri, 27 Nov 2009 04:00:51 +0100
Frederic Weisbecker <fweisbec@...> wrote:

> On Fri, Nov 27, 2009 at 03:51:48PM +1300, Johannes Buchner wrote:
> > [ I sent this 2 days ago to linux-fsdevel@..., maybe
> > I'll get more responses in here. ]
> >
> > Hi!
> >
> > I would like to keep a git repo up to date with current kernel
> > development, with reiser4 patched in. I am having trouble finding a
> > repo that provides reiser4. Is there one?
> >
> > Some people may have noticed the last patch doesn't apply cleanly
> > anymore. I made a few lines of modifications in my local repo. Maybe
> > that repo would be interesting for others too*.
> >
> > I plan to catch up with changes from kernel development on a
> > daily/weekly basis; my /home partition is reiser4, so I am fairly
> > serious about it.
> >
> > At the moment, I fetch from torvalds/linux-2.6.git and
> > stable/linux-2.6.31.y.git. Am I missing any other repositories that
> > I should try to keep up with? (A fs subsystem maintainer repo?)
> > next/linux-next.git is probably moving too fast for me.
>
>
> You can try the -mm tree, the reiser 4 patches can be found inside:
>
> http://userweb.kernel.org/~akpm/mmotm/

--
Emails können geändert, gefälscht und eingesehen werden. Signiere oder
verschüssele deine Mails mit GPG.
http://web.student.tuwien.ac.at/~e0625457/pgp.html

[reiser4-from-2.6.31-patch.patch]

From: Johannes Buchner <buchner.johannes@...> some changes from reiser4-2.6.31 patch from http://www.kernel.org/pub/linux/kernel/people/edward/reiser4/reiser4-for-2.6/ Index: linux/fs/reiser4/carry.c =================================================================== --- linux.orig/fs/reiser4/carry.c +++ linux/fs/reiser4/carry.c @@ -1095,7 +1095,7 @@ static void fatal_carry_error(carry_leve * * This function itself only manages changes in carry structures and delegates * all hard work (allocation of znode for new root, changes of parent and - * sibling pointers to the reiser4_add_tree_root(). + * sibling pointers) to the reiser4_add_tree_root(). * * Locking: old tree root is locked by carry at this point. Fake znode is also * locked. Index: linux/fs/reiser4/carry_ops.c =================================================================== --- linux.orig/fs/reiser4/carry_ops.c +++ linux/fs/reiser4/carry_ops.c @@ -2015,7 +2015,7 @@ static int carry_estimate_bitmaps(void) int bytes; bytes = capped_height() * (0 + /* bnode should be added, but - * its is private to bitmap.c, + * it is private to bitmap.c, * skip for now. */ 2 * sizeof(jnode)); /* working and commit jnodes */ Index: linux/fs/reiser4/coord.c =================================================================== --- linux.orig/fs/reiser4/coord.c +++ linux/fs/reiser4/coord.c @@ -36,12 +36,12 @@ void coord_normalize(coord_t *coord) coord_clear_iplug(coord); - if (node_is_empty(node)) + if (node_is_empty(node)) { coord_init_first_unit(coord, node); - else if ((coord->between == AFTER_ITEM) - || (coord->between == AFTER_UNIT)) + } else if ((coord->between == AFTER_ITEM) + || (coord->between == AFTER_UNIT)) { return; - else if (coord->item_pos == coord_num_items(coord) + } else if (coord->item_pos == coord_num_items(coord) && coord->between == BEFORE_ITEM) { coord_dec_item_pos(coord); coord->between = AFTER_ITEM; Index: linux/fs/reiser4/entd.c =================================================================== --- linux.orig/fs/reiser4/entd.c +++ linux/fs/reiser4/entd.c @@ -241,7 +241,7 @@ static void entd_flush(struct super_bloc if (rq->wbc->nr_to_write > 0) { rq->wbc->range_start = 0; rq->wbc->range_end = LLONG_MAX; - generic_sync_sb_inodes(rq->wbc); + generic_sync_sb_inodes(super, rq->wbc); } rq->wbc->nr_to_write = ENTD_CAPTURE_APAGE_BURST; reiser4_writeout(super, rq->wbc); Index: linux/fs/reiser4/super_ops.c =================================================================== --- linux.orig/fs/reiser4/super_ops.c +++ linux/fs/reiser4/super_ops.c @@ -412,7 +412,7 @@ static void reiser4_sync_inodes(struct s * call reiser4_writepages for each of dirty inodes to turn dirty pages * into transactions if they were not yet. */ - generic_sync_sb_inodes(wbc); + generic_sync_sb_inodes(super, wbc); /* flush goes here */ wbc->nr_to_write = to_write; Index: linux/fs/reiser4/znode.h =================================================================== --- linux.orig/fs/reiser4/znode.h +++ linux/fs/reiser4/znode.h @@ -18,7 +18,6 @@ #include <linux/types.h> #include <linux/spinlock.h> -#include <linux/semaphore.h> #include <linux/pagemap.h> /* for PAGE_CACHE_SIZE */ #include <asm/atomic.h> Index: linux/include/linux/mm.h =================================================================== --- linux.orig/include/linux/mm.h +++ linux/include/linux/mm.h @@ -836,6 +836,7 @@ int redirty_page_for_writepage(struct wr void account_page_dirtied(struct page *page, struct address_space *mapping); int set_page_dirty(struct page *page); int set_page_dirty_lock(struct page *page); +int set_page_dirty_notag(struct page *page); int clear_page_dirty_for_io(struct page *page); extern unsigned long move_page_tables(struct vm_area_struct *vma, Index: linux/mm/filemap.c =================================================================== --- linux.orig/mm/filemap.c +++ linux/mm/filemap.c @@ -139,6 +139,7 @@ void __remove_from_page_cache(struct pag dec_bdi_stat(mapping->backing_dev_info, BDI_RECLAIMABLE); } } +EXPORT_SYMBOL(__remove_from_page_cache); void remove_from_page_cache(struct page *page) { @@ -151,6 +152,7 @@ void remove_from_page_cache(struct page spin_unlock_irq(&mapping->tree_lock); mem_cgroup_uncharge_cache_page(page); } +EXPORT_SYMBOL(remove_from_page_cache); static int sync_page(void *word) { @@ -800,7 +802,6 @@ repeat: rcu_read_unlock(); return ret; } -EXPORT_SYMBOL(find_get_pages); /** * find_get_pages_contig - gang contiguous pagecache lookup @@ -970,6 +971,7 @@ static void shrink_readahead_size_eio(st { ra->ra_pages /= 4; } +EXPORT_SYMBOL(find_get_pages); /** * do_generic_file_read - generic file read routine Index: linux/mm/page-writeback.c =================================================================== --- linux.orig/mm/page-writeback.c +++ linux/mm/page-writeback.c @@ -1143,6 +1143,32 @@ int __set_page_dirty_nobuffers(struct pa EXPORT_SYMBOL(__set_page_dirty_nobuffers); /* + * set_page_dirty_notag() -- similar to __set_page_dirty_nobuffers() + * except it doesn't tag the page dirty in the page-cache radix tree. + * This means that the address space using this cannot use the regular + * filemap ->writepages() helpers and must provide its own means of + * tracking and finding non-tagged dirty pages. + * + * NOTE: furthermore, this version also doesn't handle truncate races. + */ +int set_page_dirty_notag(struct page *page) +{ + struct address_space *mapping = page->mapping; + + if (!TestSetPageDirty(page)) { + unsigned long flags; + WARN_ON_ONCE(!PagePrivate(page) && !PageUptodate(page)); + local_irq_save(flags); + account_page_dirtied(page, mapping); + local_irq_restore(flags); + __mark_inode_dirty(mapping->host, I_DIRTY_PAGES); + return 1; + } + return 0; +} +EXPORT_SYMBOL(set_page_dirty_notag); + +/* * When a writepage implementation decides that it doesn't want to write this * page for some reason, it should redirty the locked page via * redirty_page_for_writepage() and it should then unlock the page and return 0

[reiser4-pdflush-comments.patch]

From: Johannes Buchner <buchner.johannes@...> some comments were still mentioning pdflush diff --git a/fs/reiser4/context.c b/fs/reiser4/context.c index eed3efa..f80ae13 100644 --- a/fs/reiser4/context.c +++ b/fs/reiser4/context.c @@ -147,7 +147,7 @@ static void reiser4_throttle_write_at(reiser4_context *context) * call balance_dirty_pages_ratelimited() to process formatted nodes * dirtied during this system call. Do that only if we are not in mount * and there were nodes dirtied in this context and we are not in - * writepage (to avoid deadlock) and not in pdflush + * writepage (to avoid deadlock) */ if (sbinfo != NULL && sbinfo->fake != NULL && context->nr_marked_dirty != 0 && diff --git a/fs/reiser4/txnmgr.c b/fs/reiser4/txnmgr.c index 74b49f2..844d19e 100644 --- a/fs/reiser4/txnmgr.c +++ b/fs/reiser4/txnmgr.c @@ -1360,7 +1360,7 @@ static int txn_try_to_fuse_small_atom(txn_mgr * tmgr, txn_atom * atom) code tries to flush current atom. flush_some_atom() is called as part of memory clearing process. It is - invoked from balance_dirty_pages(), pdflushd, and entd. + invoked from balance_dirty_pages() and entd. If we can flush no nodes, atom is committed, because this frees memory. @@ -1469,7 +1469,7 @@ flush_some_atom(jnode * start, long *nr_submitted, const struct writeback_contro * or atom is too old/large, * we force current atom to commit */ /* wait for commit completion but only if this - * wouldn't stall pdflushd and ent thread. */ + * wouldn't stall ent thread. */ if (!wbc->nonblocking && !ctx->entd) txnh->flags |= TXNH_WAIT_COMMIT; atom->flags |= ATOM_FORCE_COMMIT;

[reiser4-generic_sync_sb_inodes.patch]

From: Johannes Buchner <buchner.johannes@...> generic_sync_sb_inodes doesn't exist anymore Index: linux/fs/reiser4/entd.c =================================================================== --- linux.orig/fs/reiser4/entd.c +++ linux/fs/reiser4/entd.c @@ -241,7 +241,9 @@ static void entd_flush(struct super_bloc if (rq->wbc->nr_to_write > 0) { rq->wbc->range_start = 0; rq->wbc->range_end = LLONG_MAX; - generic_sync_sb_inodes(super, rq->wbc); + writeback_inodes_sb(super); + if (rq->wbc->sync_mode == WB_SYNC_ALL) + sync_inodes_sb(super); } rq->wbc->nr_to_write = ENTD_CAPTURE_APAGE_BURST; reiser4_writeout(super, rq->wbc); Index: linux/fs/reiser4/super_ops.c =================================================================== --- linux.orig/fs/reiser4/super_ops.c +++ linux/fs/reiser4/super_ops.c @@ -412,7 +412,9 @@ static void reiser4_sync_inodes(struct s * call reiser4_writepages for each of dirty inodes to turn dirty pages * into transactions if they were not yet. */ - generic_sync_sb_inodes(super, wbc); + writeback_inodes_sb(super); + if (wbc->sync_mode == WB_SYNC_ALL) + sync_inodes_sb(super); /* flush goes here */ wbc->nr_to_write = to_write;

[reiser4-sync_inodes-null-dereference.patch]

From: Johannes Buchner <buchner.johannes@...> the parameter wbc=NULL caused a NULL pointer dereference in reiser4_sync_inodes. introduced in patch reiser4-vfs-add-super_operationssync_inodes Index: linux/fs/reiser4/super_ops.c =================================================================== --- linux.orig/fs/reiser4/super_ops.c +++ linux/fs/reiser4/super_ops.c @@ -395,7 +395,7 @@ static void reiser4_sync_inodes(struct s reiser4_context *ctx; long to_write; - if (wbc->for_kupdate) + if (wbc == NULL || wbc->for_kupdate) /* reiser4 has its own means of periodical write-out */ return;

series (1K) Download Attachment
attachment1 (205 bytes) Download Attachment

Re: Fw: reiser4 git repo

2009-11-26T19:00:51Z

On Fri, Nov 27, 2009 at 03:51:48PM +1300, Johannes Buchner wrote:

> [ I sent this 2 days ago to linux-fsdevel@..., maybe I'll
> get more responses in here. ]
>
> Hi!
>
> I would like to keep a git repo up to date with current kernel
> development, with reiser4 patched in. I am having trouble finding a
> repo that provides reiser4. Is there one?
>
> Some people may have noticed the last patch doesn't apply cleanly
> anymore. I made a few lines of modifications in my local repo. Maybe
> that repo would be interesting for others too*.
>
> I plan to catch up with changes from kernel development on a
> daily/weekly basis; my /home partition is reiser4, so I am fairly
> serious about it.
>
> At the moment, I fetch from torvalds/linux-2.6.git and
> stable/linux-2.6.31.y.git. Am I missing any other repositories that I
> should try to keep up with? (A fs subsystem maintainer repo?)
> next/linux-next.git is probably moving too fast for me.

You can try the -mm tree, the reiser 4 patches can be found inside:

http://userweb.kernel.org/~akpm/mmotm/

--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@...
More majordomo info at http://vger.kernel.org/majordomo-info.html

Fw: reiser4 git repo

2009-11-26T18:51:48Z

[ I sent this 2 days ago to linux-fsdevel@..., maybe I'll
get more responses in here. ]

Hi!

I would like to keep a git repo up to date with current kernel
development, with reiser4 patched in. I am having trouble finding a
repo that provides reiser4. Is there one?

Some people may have noticed the last patch doesn't apply cleanly
anymore. I made a few lines of modifications in my local repo. Maybe
that repo would be interesting for others too*.

I plan to catch up with changes from kernel development on a
daily/weekly basis; my /home partition is reiser4, so I am fairly
serious about it.

At the moment, I fetch from torvalds/linux-2.6.git and
stable/linux-2.6.31.y.git. Am I missing any other repositories that I
should try to keep up with? (A fs subsystem maintainer repo?)
next/linux-next.git is probably moving too fast for me.

Cheers,
Johannes

* How hard is it to get a git.kernel.org repo?
--
http://jakeapp.com/ http://johannes.jakeapp.com/blog/

--
Emails können geändert, gefälscht und eingesehen werden. Signiere oder
verschüssele deine Mails mit GPG.
http://web.student.tuwien.ac.at/~e0625457/pgp.html

attachment0 (205 bytes) Download Attachment

Re: Fyi - reiser4-for-opensuse-11-2 modules

2009-11-24T17:40:43Z

On 11/23/2009 07:39 AM, doiggl@... wrote:
> Fyi
> May be of interest.
> http://lizards.opensuse.org/2009/11/15/reiser4-for-opensuse-11-2/

Any reason you didn't create a submitreq for the updated packages to be
included in the official 11.2 release?

It's pretty easy to do: just create a branch of the drivers:filesystems
reiser4-kmp package, do your changes, and then do "osc sr" for it to
create a submitreq.

I'm glad someone is stepping up to do this since I haven't had a lot of
time to track reiser4.

-Jeff

--
Jeff Mahoney
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@...
More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Fyi - reiser4-for-opensuse-11-2 modules

2009-11-23T10:47:12Z

Aloha Glenn;
> Fyi
> May be of interest.
> http://lizards.opensuse.org/2009/11/15/reiser4-for-opensuse-11-2/
>
Yes it is. Thank you for the notice.
Do you were part of the party?

And do you know why Dmitry is too shy to send an e-mail?

As always: Have fun
Christian *<:o) O>-< -(D)>-<

--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@...
More majordomo info at http://vger.kernel.org/majordomo-info.html

Fyi - reiser4-for-opensuse-11-2 modules

2009-11-23T04:39:51Z

Fyi
May be of interest.
http://lizards.opensuse.org/2009/11/15/reiser4-for-opensuse-11-2/

--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@...
More majordomo info at http://vger.kernel.org/majordomo-info.html

[Bug 13876] [x86_32, 2.6.30, reiserfs, reiser3, bug, regression] kernel oopsed while Sarg was running

2009-11-23T01:45:03Z

http://bugzilla.kernel.org/show_bug.cgi?id=13876

Igor M Podlesny <for.poige+bugzilla.kernel.org@...> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |CODE_FIX

--- Comment #9 from Igor M Podlesny <for.poige+bugzilla.kernel.org@...> 2009-11-23 09:44:59 ---
> Igor, can you try latest kernel

Roland, that comp. isn't mine; it has been running 2.6.27.something happily for
quite a long time now and its users are careless. I don't think it'd be a good
idea to tell'em "guys, kernel devs would like to give your box another crash
test, wouldn't ya mind, ugh?". :-)

P. S. I tried reproducing this problem inside VirtualBox but failed -- 2.6.30
inside it runs just ok. In case I'll have a chance to meet that bug I'll do my
best reporting it. Let me mark this ticket as resolved.

--
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@...
More majordomo info at http://vger.kernel.org/majordomo-info.html

[Bug #14656] Oops at __rmqueue+0x98 with 2.6.32-rc6

2009-11-21T06:51:33Z

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.31. Please verify if it still should be listed and let me know
(either way).

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14656
Subject : Oops at __rmqueue+0x98 with 2.6.32-rc6
Submitter : Lucas C. Villa Real <lucasvr@...>
Date : 2009-11-19 3:48 (3 days old)
References : http://marc.info/?l=linux-kernel&m=125860255229092&w=4

--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@...
More majordomo info at http://vger.kernel.org/majordomo-info.html

[Bug 14656] New: Oops at __rmqueue+0x98 with 2.6.32-rc6

2009-11-21T06:42:42Z

http://bugzilla.kernel.org/show_bug.cgi?id=14656

Summary: Oops at __rmqueue+0x98 with 2.6.32-rc6
Product: File System
Version: 2.5
Kernel Version: 2.6.32-rc6
Platform: All
OS/Version: Linux
Tree: Mainline
Status: NEW
Severity: normal
Priority: P1
Component: ReiserFS
AssignedTo: reiserfs-devel@...
ReportedBy: rjw@...
Blocks: 14230
Regression: Yes

Subject : Oops with 2.6.32-rc6
Submitter : "Lucas C. Villa Real" <lucasvr@...>
Date : 2009-11-19 3:48
References : http://marc.info/?l=linux-kernel&m=125860255229092&w=4
Notify-Also : reiserfs-devel@...

This entry is being used for tracking a regression from 2.6.31. Please don't
close it until the problem is fixed in the mainline.

--
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@...
More majordomo info at http://vger.kernel.org/majordomo-info.html

[Bug 13876] [x86_32, 2.6.30, reiserfs, reiser3, bug, regression] kernel oopsed while Sarg was running

2009-11-20T16:06:47Z

http://bugzilla.kernel.org/show_bug.cgi?id=13876

--- Comment #8 from Roland Kletzing <devzero@...> 2009-11-21 00:06:46 ---
Igor, can you try latest kernel and give some feedback as this ticket would be
closed due to missing response?

i'm quite sure this/your bug is fixed.

if your bug is different, then it`s the last chance to tell about that.

--
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@...
More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: reiser4 for 2.6.33?

2009-11-18T11:12:12Z

On Wed, 18 Nov 2009 at 14:50, Edward Shishkin wrote:
> (a) plugin design document;
> (b) full description of what is going on in respond to memory
> pressure notifications;
>
> The (a) is not yet ready and I don't have a time to explain
> personally to everyone why the plugin stuff is not crappy.

Is this still a must-have? I.e. are there still strong objections against
the plugin design? And even if so, most of this happens in fs/reiser4
anyway I suppose, so the "evil" plugins are well contained :)

As for (b), can't this be documented at a later point as well?

What about the technical issues, mentioned in the latest TODO list[0]
earlier this year? Are there any real show-stoppers left?
Andrew (Cc'ed) had this in -mm for a longer time now, maybe he can
comment (once again) what's left to do from his POV?

Thanks,
Christian.

[0] http://marc.info/?l=reiserfs-devel&m=124069989217533&w=2
--
BOFH excuse #323:

Your processor has processed too many instructions. Turn it off immediately, do not type any commands!!
--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@...
More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: reiser4 for 2.6.33?

2009-11-18T05:50:17Z

As I told already for reiser4 inclusion we need the following:

(a) plugin design document;
(b) full description of what is going on in respond to memory
pressure notifications;

The (a) is not yet ready and I don't have a time to explain
personally to everyone why the plugin stuff is not crappy. It will
be posted in a magazine with proper background, because all
Namesys projects traditionally have academic sources. So wait...

Actually there is no hurry. Taking into account common situation
with file systems, I am not afraid that reiser4 will get obsolete.

Thanks,
Edward.

Christian Kujau wrote:

> It's autumn[0] already and even with 2.6.32 not quite ready yet, let me
> be the one asking the inevitable question:
> What are the plans for reiser4 being included in 2.6.33? The
> diffstat for the 2.6.31 patch looks rather promising, at least to me:
>
> $ diffstat reiser4-for-2.6.31.patch | grep -v fs/reiser4
> Documentation/Changes | 12
> Documentation/filesystems/reiser4.txt | 75
> fs/Kconfig | 1
> fs/Makefile | 1
> fs/fs-writeback.c | 5
> include/linux/fs.h | 3
> include/linux/mm.h | 1
> mm/filemap.c | 3
> mm/page-writeback.c | 26
> 170 files changed, 77581 insertions(+), 1 deletion(-)
>
> Or maybe it can find a place in -staging if there are still strong
> objections against a general inclusion?
>
> Thanks,
> Christian.
>
> [0] http://marc.info/?l=reiserfs-devel&m=124904274311847&w=2
>

--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@...
More majordomo info at http://vger.kernel.org/majordomo-info.html

reiser4 for 2.6.33?

2009-11-17T14:29:05Z

It's autumn[0] already and even with 2.6.32 not quite ready yet, let me
be the one asking the inevitable question:
What are the plans for reiser4 being included in 2.6.33? The
diffstat for the 2.6.31 patch looks rather promising, at least to me:

$ diffstat reiser4-for-2.6.31.patch | grep -v fs/reiser4
Documentation/Changes | 12
Documentation/filesystems/reiser4.txt | 75
fs/Kconfig | 1
fs/Makefile | 1
fs/fs-writeback.c | 5
include/linux/fs.h | 3
include/linux/mm.h | 1
mm/filemap.c | 3
mm/page-writeback.c | 26
170 files changed, 77581 insertions(+), 1 deletion(-)

Or maybe it can find a place in -staging if there are still strong
objections against a general inclusion?

Thanks,
Christian.

[0] http://marc.info/?l=reiserfs-devel&m=124904274311847&w=2
--
BOFH excuse #70:

nesting roaches shorted out the ether cable
--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@...
More majordomo info at http://vger.kernel.org/majordomo-info.html

List of small to medium sized companies for America

2009-11-15T09:20:35Z

This list has phone, fax, email, contact name and 10 more fields

2,000,000 total records all with emails

Reduced to only: $291 - for this week

Email us at: Consuelo@...

Send email to exit@... for deleted status

--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@...
More majordomo info at http://vger.kernel.org/majordomo-info.html

[Bug 14055] crash on NFS umount

2009-11-12T02:19:51Z

http://bugzilla.kernel.org/show_bug.cgi?id=14055

Harald Dunkel <harald.dunkel@...> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |harald.dunkel@...

--
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@...
More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: BUG? a suspected race bug at check_journal_end()

2009-11-03T05:27:42Z

On (11/03/09 22:08), 홍신 shin hong wrote:

> Hello. I am reporting atomic instructions usages
> which are suspected to be misused in reiserfs/journal.c
> of Linux 2.6.31
>
> I do not have much background on reiserfs
> so that I am not certain whether it is correct or not.
> But I hope this report is helpful. Please examine the code.
>
> In check_journal_end(), there are following codes:
>
> if (atomic_read(&(journal->j_wcount)) > 0) {
> atomic_dec(&(journal->j_wcount)) ;
>
>
> It first checks journal->j_wcount and then increments its value by one.
>
> If a function which changes journal->j_wcount executes concurrently
> for the same journal->j_wcount, race condition might be possible.
>
> I think it would be better to combine two atomic operations
> into one atomic operation (e.g. atomic_dec_and_test)
>

Hello,
Isn't it performed on locked journal?

journal.c:3973:
lock_journal(sb);
...

Sergey

signature.asc (324 bytes) Download Attachment

BUG? a suspected race bug at check_journal_end()

2009-11-03T05:08:07Z

Hello. I am reporting atomic instructions usages
which are suspected to be misused in reiserfs/journal.c
of Linux 2.6.31

I do not have much background on reiserfs
so that I am not certain whether it is correct or not.
But I hope this report is helpful. Please examine the code.

In check_journal_end(), there are following codes:

if (atomic_read(&(journal->j_wcount)) > 0) {
atomic_dec(&(journal->j_wcount)) ;

It first checks journal->j_wcount and then increments its value by one.

If a function which changes journal->j_wcount executes concurrently
for the same journal->j_wcount, race condition might be possible.

I think it would be better to combine two atomic operations
into one atomic operation (e.g. atomic_dec_and_test)

Thank you.

Sincerely
Shin Hong
--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@...
More majordomo info at http://vger.kernel.org/majordomo-info.html

Fill up your xxx life with bright colours

2009-10-28T17:50:28Z

You can cut the knot of man's problems in bed in a day!
http://luz.medicineonline321.com/

--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@...
More majordomo info at http://vger.kernel.org/majordomo-info.html