Rejecting known crashers

[Olav Vitters]

I want to reject known (FIXED!) crashers like bug 153888
(nautilus_directory_are_all_files_seen) in Halloween. That is the part
that reads the bug-buddy reports. I'd expect that would avoid most of
the dupes.

When it sees a new bugreport from a fixed crasher, Halloween should
reject the bugreport. The reject message should include the bugreport
with the fix (bug 153888) and some statement that the user should
upgrade to a newer version.

I don't want it to automatically determine the stacktraces to reject.
I'd like that part to be handled manually. As it would reside in
Halloween it wouldn't be able to connect to bugzilla anyway
(theoretically it could, but isn't wanted).

I'm thinking of a list like program-map.txt, see
http://cvs.gnome.org/viewcvs/*checkout*/halloween/bugzilla.gnome.org/program-map.txt

There are some possible problems I can think of when automatically
rejecting bugreports:
1. Regressions aren't seen. Eg, problem appears in GNOME 2.8; reappears
in 2.16 and nobody notices.
2. Rejects the wrong bugreport.

Solutions I can think of:
1. I believe the list should have a regexp of the version the
stacktrace has been fixed in. This regexp should be for the GNOME part
(because the real version field isn't always correct). I want it to be
a regexp so that 2.12 is not thought of as older than 2.8.
2. This is why the stacktraces must be added manually

The list would have for example (all on one line):
153888 /^GNOME2\.8\./  nautilus_directory_are_all_files_seen
nautilus_directory_add_file nautilus_desktop_icon_file_new
nautilus_desktop_link_get_type nautilus_desktop_link_new_from_volume

I'll steal the stacktrace fetching from dupfinder.

One thing that might be handy is an extra field specifying a custom
error message. Eg, after the regexp either '-' for the default error
message or a filename for a custom one.

Ideally I'd want something like this to work for open bugreports, but
this will have to do for now.


Thoughts?


--
Regards,
Olav
_______________________________________________
bugzilla-devel-list mailing list
bugzilla-devel-list@...
http://mail.gnome.org/mailman/listinfo/bugzilla-devel-list

[Olav Vitters]

On Fri, Jun 10, 2005 at 10:51:53PM +0200, Olav Vitters wrote:
> I want to reject known (FIXED!) crashers like bug 153888
> (nautilus_directory_are_all_files_seen) in Halloween. That is the part
> that reads the bug-buddy reports. I'd expect that would avoid most of
> the dupes.

Clarifying:
I mean the dupes for known crashers like bug 153888 as not many of the
known crashers are filed via the webinterface. I do not mean dupes in
general.

--
Regards,
Olav
_______________________________________________
bugzilla-devel-list mailing list
bugzilla-devel-list@...
http://mail.gnome.org/mailman/listinfo/bugzilla-devel-list

[Olav Vitters]

On Fri, Jun 10, 2005 at 10:51:53PM +0200, Olav Vitters wrote:
> I want to reject known (FIXED!) crashers like bug 153888
> (nautilus_directory_are_all_files_seen) in Halloween. That is the part
> that reads the bug-buddy reports. I'd expect that would avoid most of
> the dupes.
[..]

It is finished. See attachment for the current rejection message. This
was actually emailed to me after I've submitted a bug 153888 crasher.

Currently it only rejects bug 153888 crashers. Feel free to add others.
The file to modify is halloween/bugzilla.gnome.org/crashers-map.txt.
What to add is explained in the file. The file is automatically
checkout out of CVS every hour.

I'll write a message to the mailing lists tomorrow explaining this and
some of the other new stuff.

> One thing that might be handy is an extra field specifying a custom
> error message. Eg, after the regexp either '-' for the default error
> message or a filename for a custom one.

Haven't done that.

Another thought was having a special keyword that could be added to a
bug. Then every day retrieve these bugs, fetch the stack traces, and
put the functions in the database (new table).
Then the code would be removed from Halloween and added to
bug-buddy-import.pl. This would also allow bug-buddy-import.pl to
handle the open bugs. Open bugs should either have a new comment, be
cc'ed or new bug that is automatically duped.

I'd want the keyword because it is way simpler for maintainers +
doesn't require CVS access. Also because putting this stuff in a
database is way better than having a huge list in a flat file.

--
Regards,
Olav


Thanks for the bug report. We are glad to report this bug has already
been fixed. Please upgrade to the latest packages available. These
should be available from your vendor (Red Hat, SuSE, Novell, Mandriva,
etc).

The bug report with the fix can be found here:
http://bugzilla.gnome.org/show_bug.cgi?id=153888

Note that it can take a while for new packages to be available.

Thank you-
The GNOME Bugmasters



_______________________________________________
bugzilla-devel-list mailing list
bugzilla-devel-list@...
http://mail.gnome.org/mailman/listinfo/bugzilla-devel-list

[Olav Vitters]

On Sun, Jun 12, 2005 at 01:56:50AM +0200, Olav Vitters wrote:
> It is finished. See attachment for the current rejection message. This
> was actually emailed to me after I've submitted a bug 153888 crasher.

PS: Feel free to commit or suggest changes to that message. It is in the
halloween module, bugzilla.gnome.org/reject-fixed-crasher.txt.

--
Regards,
Olav
_______________________________________________
bugzilla-devel-list mailing list
bugzilla-devel-list@...
http://mail.gnome.org/mailman/listinfo/bugzilla-devel-list

[Vincent Untz]

Le dimanche 12 juin 2005 à 01:56 +0200, Olav Vitters a écrit :

> On Fri, Jun 10, 2005 at 10:51:53PM +0200, Olav Vitters wrote:
> > I want to reject known (FIXED!) crashers like bug 153888
> > (nautilus_directory_are_all_files_seen) in Halloween. That is the part
> > that reads the bug-buddy reports. I'd expect that would avoid most of
> > the dupes.
> [..]
>
> It is finished. See attachment for the current rejection message. This
> was actually emailed to me after I've submitted a bug 153888 crasher.
>
> Currently it only rejects bug 153888 crashers. Feel free to add others.
> The file to modify is halloween/bugzilla.gnome.org/crashers-map.txt.
> What to add is explained in the file. The file is automatically
> checkout out of CVS every hour.

How does it work for bug where there are multiple stack traces?

Vincent

--
Les gens heureux ne sont pas pressés.

_______________________________________________
bugzilla-devel-list mailing list
bugzilla-devel-list@...
http://mail.gnome.org/mailman/listinfo/bugzilla-devel-list

[Vincent Untz]

Le dimanche 12 juin 2005 à 09:11 +0200, Vincent Untz a écrit :

> Le dimanche 12 juin 2005 à 01:56 +0200, Olav Vitters a écrit :
> > On Fri, Jun 10, 2005 at 10:51:53PM +0200, Olav Vitters wrote:
> > > I want to reject known (FIXED!) crashers like bug 153888
> > > (nautilus_directory_are_all_files_seen) in Halloween. That is the part
> > > that reads the bug-buddy reports. I'd expect that would avoid most of
> > > the dupes.
> > [..]
> >
> > It is finished. See attachment for the current rejection message. This
> > was actually emailed to me after I've submitted a bug 153888 crasher.
> >
> > Currently it only rejects bug 153888 crashers. Feel free to add others.
> > The file to modify is halloween/bugzilla.gnome.org/crashers-map.txt.
> > What to add is explained in the file. The file is automatically
> > checkout out of CVS every hour.
>
> How does it work for bug where there are multiple stack traces?

Ah, we specify the stack trace in crasher-map.txt. Ignore me :-)

Vincent

--
Les gens heureux ne sont pas pressés.

_______________________________________________
bugzilla-devel-list mailing list
bugzilla-devel-list@...
http://mail.gnome.org/mailman/listinfo/bugzilla-devel-list