Removing breada() and bdirty()

View: New views

2 Messages — Rating Filter: Alert me

Removing breada() and bdirty()

by rmind :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hello,

I would like to remove unused breada() and bdirty():

http://www.netbsd.org/~rmind/bcache.diff

Concerns?

--
Mindaugas

Re: Removing breada() and bdirty()

by David Holland-6 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Sat, Nov 07, 2009 at 07:08:34PM +0000, Mindaugas Rasiukevicius wrote:
> I would like to remove unused breada() and bdirty():

If nothing is using breada() any more it should definitely go away.

I'm not so sure about bdirty(); it seems like there are legitimate
cases where a FS might want to mark a buffer dirty without releasing
it yet, even if we don't currently have any such cases in the tree.
But I don't really have a strong opinion and we could always bring it
back later.

--
David A. Holland
dholland@...