Reports problem with investment accounts

Hi,

I just noticed a discrepancy between the value of one of my investment
accounts as displayed in the accounts view and the value displayed on the Net
Worth Today Report. It looks like a rounding problem in reports. I have found
that the value displayed in reports is affected by the fraction specified for
the stock within the investment account. Here is an example.

I have a stock within an investment account with the fraction set to 1/1. This
is reasonable because I cannot hold fractions of this stock, only whole
numbers. In this case I see a value for the stock of 1972.81 in the accounts
view which is correct. On the Net Worth Today report the value is shown as
1973.00. When I change the fraction to 1/10 the report value changes to
1972.80. When I change the fraction to 1/100 the report value changes to
1972.81. I don't see why changing the fraction should change the report value
like this.

This problem also affects the values on the various investment reports and the
stock prices shown on those reports.

Regards,
Dave.

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
KMyMoney2-developer mailing list
KMyMoney2-developer@...
https://lists.sourceforge.net/lists/listinfo/kmymoney2-developer

[Alvaro Soliverez]

Hello Dave,
There may be differences because of the way the reports do the sum up. Specifically, the reports round up the numbers to prevent an overflow, where the accounts total do that only once.

But I think we may have a deeper problem, because internally, the fraction is used to set the rounding of the value. Perhaps we should be using price precision instead?

Regards,
Alvaro

On Sat, Oct 17, 2009 at 9:12 AM, David Houlden <djhoulden@...> wrote:

Hi,

I just noticed a discrepancy between the value of one of my investment
accounts as displayed in the accounts view and the value displayed on the Net
Worth Today Report. It looks like a rounding problem in reports. I have found
that the value displayed in reports is affected by the fraction specified for
the stock within the investment account. Here is an example.

I have a stock within an investment account with the fraction set to 1/1. This
is reasonable because I cannot hold fractions of this stock, only whole
numbers. In this case I see a value for the stock of 1972.81 in the accounts
view which is correct. On the Net Worth Today report the value is shown as
1973.00. When I change the fraction to 1/10 the report value changes to
1972.80. When I change the fraction to 1/100 the report value changes to
1972.81. I don't see why changing the fraction should change the report value
like this.

This problem also affects the values on the various investment reports and the
stock prices shown on those reports.

Regards,
Dave.

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
KMyMoney2-developer mailing list
KMyMoney2-developer@...
https://lists.sourceforge.net/lists/listinfo/kmymoney2-developer

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
KMyMoney2-developer mailing list
KMyMoney2-developer@...
https://lists.sourceforge.net/lists/listinfo/kmymoney2-developer

[Thomas Baumgart]

Hi,

on Saturday 17 October 2009 Alvaro Soliverez wrote:


> Hello Dave,
> There may be differences because of the way the reports do the sum up.
> Specifically, the reports round up the numbers to prevent an overflow,
>  where the accounts total do that only once.
>
> But I think we may have a deeper problem, because internally, the fraction
> is used to set the rounding of the value. Perhaps we should be using price
> precision instead?

I think we need to use the precision of the trading currency in this case, not
the security. Using the price precision when summing up transactions in a
specific currency would cause more rounding problems than we solve.

> On Sat, Oct 17, 2009 at 9:12 AM, David Houlden <djhoulden@...> wrote:
> > Hi,
> >
> > I just noticed a discrepancy between the value of one of my investment
> > accounts as displayed in the accounts view and the value displayed on the
> > Net
> > Worth Today Report. It looks like a rounding problem in reports. I have
> > found
> > that the value displayed in reports is affected by the fraction specified
> > for
> > the stock within the investment account. Here is an example.
> >
> > I have a stock within an investment account with the fraction set to 1/1.
> > This
> > is reasonable because I cannot hold fractions of this stock, only whole
> > numbers. In this case I see a value for the stock of 1972.81 in the
> > accounts
> > view which is correct. On the Net Worth Today report the value is shown
> > as 1973.00. When I change the fraction to 1/10 the report value changes
> > to 1972.80. When I change the fraction to 1/100 the report value changes
> > to 1972.81. I don't see why changing the fraction should change the
> > report value
> > like this.
> >
> > This problem also affects the values on the various investment reports
> > and the
> > stock prices shown on those reports.
> >
> > Regards,
> > Dave.
> >
> >
> > -------------------------------------------------------------------------
> >----- Come build with us! The BlackBerry(R) Developer Conference in SF, CA
> > is the only developer event you need to attend this year. Jumpstart your
> > developing skills, take BlackBerry mobile applications to market and stay
> > ahead of the curve. Join us from November 9 - 12, 2009. Register now!
> > http://p.sf.net/sfu/devconference
> > _______________________________________________
> > KMyMoney2-developer mailing list
> > KMyMoney2-developer@...
> > https://lists.sourceforge.net/lists/listinfo/kmymoney2-developer
>

--


Regards

Thomas Baumgart

GPG-FP: E55E D592 F45F 116B 8429   4F99 9C59 DB40 B75D D3BA
-------------------------------------------------------------
Two of the most famous products of Berkeley are LSD and UNIX.
I don't think that this is a coincidence. (anonymous)
-------------------------------------------------------------


------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
KMyMoney2-developer mailing list
KMyMoney2-developer@...
https://lists.sourceforge.net/lists/listinfo/kmymoney2-developer

On Saturday 17 October 2009 Thomas Baumgart wrote:
> Hi,
>
> on Saturday 17 October 2009 Alvaro Soliverez wrote:
> > Hello Dave,
> > There may be differences because of the way the reports do the sum up.
> > Specifically, the reports round up the numbers to prevent an overflow,
> >  where the accounts total do that only once.
> >
Hmm. I haven't seen any evidence of that problem in my investigations so far.
Maybe I just haven't got the right data to show it. But, shouldn't all
elements (account screen, home page summary, reports) all work the same way
so we don't get two different values displayed for the same thing. I'm not
saying it's a simple change to make but definitely something to aim for long
term.
 
> > But I think we may have a deeper problem, because internally, the
> > fraction is used to set the rounding of the value. Perhaps we should be
> > using price precision instead?
>
> I think we need to use the precision of the trading currency in this case,
> not the security. Using the price precision when summing up transactions in
> a specific currency would cause more rounding problems than we solve.
>
With my very limited knowledge of the program internals, that does sound like
a sensible solution. Maybe the price precision should be used for prices
displayed in reports. As I mentioned, prices are being affected by the
fraction currently.

> > On Sat, Oct 17, 2009 at 9:12 AM, David Houlden <djhoulden@...>
wrote:

> > > Hi,
> > >
> > > I just noticed a discrepancy between the value of one of my investment
> > > accounts as displayed in the accounts view and the value displayed on
> > > the Net
> > > Worth Today Report. It looks like a rounding problem in reports. I have
> > > found
> > > that the value displayed in reports is affected by the fraction
> > > specified for
> > > the stock within the investment account. Here is an example.
> > >
> > > I have a stock within an investment account with the fraction set to
> > > 1/1. This
> > > is reasonable because I cannot hold fractions of this stock, only whole
> > > numbers. In this case I see a value for the stock of 1972.81 in the
> > > accounts
> > > view which is correct. On the Net Worth Today report the value is shown
> > > as 1973.00. When I change the fraction to 1/10 the report value changes
> > > to 1972.80. When I change the fraction to 1/100 the report value
> > > changes to 1972.81. I don't see why changing the fraction should change
> > > the report value
> > > like this.
> > >
> > > This problem also affects the values on the various investment reports
> > > and the
> > > stock prices shown on those reports.
> > >
> > > Regards,
> > > Dave.

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
KMyMoney2-developer mailing list
KMyMoney2-developer@...
https://lists.sourceforge.net/lists/listinfo/kmymoney2-developer

[Alvaro Soliverez]

On Sat, Oct 17, 2009 at 2:52 PM, David Houlden <djhoulden@...> wrote:

On Saturday 17 October 2009 Thomas Baumgart wrote:
> Hi,
>
> on Saturday 17 October 2009 Alvaro Soliverez wrote:
> > Hello Dave,
> > There may be differences because of the way the reports do the sum up.
> > Specifically, the reports round up the numbers to prevent an overflow,
> >  where the accounts total do that only once.
> >

Hmm. I haven't seen any evidence of that problem in my investigations so far.
Maybe I just haven't got the right data to show it.

You probably don't have many accounts in multiple currencies. Check the logs or the list archive and you will find references to this showing up since pre-0.9.2.

 

But, shouldn't all
elements (account screen, home page summary, reports) all work the same way
so we don't get two different values displayed for the same thing. I'm not
saying it's a simple change to make but definitely something to aim for long
term.

Except that you are doing different things.  The account view shows a  balance at a point in time.  The one in reports has  to be summed up over time. Or I can show you the current balance, just like the accounts view does, the numbers will match, and everybody will be happy, not.  ;)

> > But I think we may have a deeper problem, because internally, the
> > fraction is used to set the rounding of the value. Perhaps we should be
> > using price precision instead?
>
> I think we need to use the precision of the trading currency in this case,
> not the security. Using the price precision when summing up transactions in
> a specific currency would cause more rounding problems than we solve.
>

With my very limited knowledge of the program internals, that does sound like
a sensible solution. Maybe the price precision should be used for prices
displayed in reports. As I mentioned, prices are being affected by the
fraction currently.

I will send a patch to Thomas with a fix, because my KDE3 development environment is hosed at the moment and I don't think it will be up anytime soon. You are welcome to review and comment on it.

Regards,

Alvaro

 

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
KMyMoney2-developer mailing list
KMyMoney2-developer@...
https://lists.sourceforge.net/lists/listinfo/kmymoney2-developer

On Saturday 17 October 2009 Alvaro Soliverez wrote:

> On Sat, Oct 17, 2009 at 2:52 PM, David Houlden <djhoulden@...> wrote:
> > But, shouldn't all
> > elements (account screen, home page summary, reports) all work the same
> > way so we don't get two different values displayed for the same thing.
> > I'm not saying it's a simple change to make but definitely something to
> > aim for long
> > term.
>
> Except that you are doing different things.  The account view shows a
>  balance at a point in time.  The one in reports has  to be summed up over
> time. Or I can show you the current balance, just like the accounts view
> does, the numbers will match, and everybody will be happy, not.  ;)
>

OK. I think I understand what you are saying and that may be the way reports
work internally. However, just thinking from the end user viewpoint, I first
noticed this problem on the Net Worth Today report. That report shows a
balance at a point in time (today). Therefore isn't it reasonable to assume
that the balance would be the same as on the other views.
 
> I will send a patch to Thomas with a fix, because my KDE3 development
> environment is hosed at the moment and I don't think it will be up anytime
> soon. You are welcome to review and comment on it.
>
Thanks Alvaro. I'll be very happy to try it out.

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
KMyMoney2-developer mailing list
KMyMoney2-developer@...
https://lists.sourceforge.net/lists/listinfo/kmymoney2-developer

Hi Alvaro,

On Saturday 17 October 2009 David Houlden wrote:
> On Saturday 17 October 2009 Alvaro Soliverez wrote:
> > On Sat, Oct 17, 2009 at 2:52 PM, David Houlden <djhoulden@...>
wrote:

> > > But, shouldn't all
> > > elements (account screen, home page summary, reports) all work the same
> > > way so we don't get two different values displayed for the same thing.
> > > I'm not saying it's a simple change to make but definitely something to
> > > aim for long
> > > term.
> >
> > Except that you are doing different things.  The account view shows a
> >  balance at a point in time.  The one in reports has  to be summed up
> > over time. Or I can show you the current balance, just like the accounts
> > view does, the numbers will match, and everybody will be happy, not.  ;)
>
> OK. I think I understand what you are saying and that may be the way
> reports work internally. However, just thinking from the end user
> viewpoint, I first noticed this problem on the Net Worth Today report. That
> report shows a balance at a point in time (today). Therefore isn't it
> reasonable to assume that the balance would be the same as on the other
> views.
>
> > I will send a patch to Thomas with a fix, because my KDE3 development
> > environment is hosed at the moment and I don't think it will be up
> > anytime soon. You are welcome to review and comment on it.
>
> Thanks Alvaro. I'll be very happy to try it out.
>

I hope I haven't jumped the gun here. Apologies in advance if I have. I  
noticed a change in CVS which appears to be a fix so I compiled and tested.
Here is what I have found.

The Net Worth Today report is fixed I no longer see it being affected by the
fraction. The totals match the account screen and home page summary.

Other reports have not changed. Examples are Account Balances By Institution /
Type and Investment Holding By Account / Type. The price and value columns
are both still being affected by the fraction as I originally described.

Thanks for looking at this.
Dave.

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
KMyMoney2-developer mailing list
KMyMoney2-developer@...
https://lists.sourceforge.net/lists/listinfo/kmymoney2-developer

[Alvaro Soliverez]

On Mon, Oct 19, 2009 at 10:03 AM, David Houlden <djhoulden@...> wrote:

Hi Alvaro,

On Saturday 17 October 2009 David Houlden wrote:
> On Saturday 17 October 2009 Alvaro Soliverez wrote:
> > On Sat, Oct 17, 2009 at 2:52 PM, David Houlden <djhoulden@...>
wrote:
> > > But, shouldn't all
> > > elements (account screen, home page summary, reports) all work the same
> > > way so we don't get two different values displayed for the same thing.
> > > I'm not saying it's a simple change to make but definitely something to
> > > aim for long
> > > term.
> >
> > Except that you are doing different things.  The account view shows a
> >  balance at a point in time.  The one in reports has  to be summed up
> > over time. Or I can show you the current balance, just like the accounts
> > view does, the numbers will match, and everybody will be happy, not.  ;)
>
> OK. I think I understand what you are saying and that may be the way
> reports work internally. However, just thinking from the end user
> viewpoint, I first noticed this problem on the Net Worth Today report. That
> report shows a balance at a point in time (today). Therefore isn't it
> reasonable to assume that the balance would be the same as on the other
> views.
>
> > I will send a patch to Thomas with a fix, because my KDE3 development
> > environment is hosed at the moment and I don't think it will be up
> > anytime soon. You are welcome to review and comment on it.
>
> Thanks Alvaro. I'll be very happy to try it out.
>

I hope I haven't jumped the gun here. Apologies in advance if I have. I
noticed a change in CVS which appears to be a fix so I compiled and tested.
Here is what I have found.

The Net Worth Today report is fixed I no longer see it being affected by the
fraction. The totals match the account screen and home page summary.

Other reports have not changed. Examples are Account Balances By Institution /
Type and Investment Holding By Account / Type. The price and value columns
are both still being affected by the fraction as I originally described.

Thanks for looking at this.
Dave.

I will take a look at this. The Investment reports are mostly a special kind, so they are probably unaffected by the change I made on Saturday.

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
KMyMoney2-developer mailing list
KMyMoney2-developer@...
https://lists.sourceforge.net/lists/listinfo/kmymoney2-developer

[Alvaro Soliverez]

On Mon, Oct 19, 2009 at 11:54 AM, Alvaro Soliverez <asoliverez@...> wrote:

On Mon, Oct 19, 2009 at 10:03 AM, David Houlden <djhoulden@...> wrote:

Hi Alvaro,

On Saturday 17 October 2009 David Houlden wrote:
> On Saturday 17 October 2009 Alvaro Soliverez wrote:
> > On Sat, Oct 17, 2009 at 2:52 PM, David Houlden <djhoulden@...>
wrote:
> > > But, shouldn't all
> > > elements (account screen, home page summary, reports) all work the same
> > > way so we don't get two different values displayed for the same thing.
> > > I'm not saying it's a simple change to make but definitely something to
> > > aim for long
> > > term.
> >
> > Except that you are doing different things.  The account view shows a
> >  balance at a point in time.  The one in reports has  to be summed up
> > over time. Or I can show you the current balance, just like the accounts
> > view does, the numbers will match, and everybody will be happy, not.  ;)
>
> OK. I think I understand what you are saying and that may be the way
> reports work internally. However, just thinking from the end user
> viewpoint, I first noticed this problem on the Net Worth Today report. That
> report shows a balance at a point in time (today). Therefore isn't it
> reasonable to assume that the balance would be the same as on the other
> views.
>
> > I will send a patch to Thomas with a fix, because my KDE3 development
> > environment is hosed at the moment and I don't think it will be up
> > anytime soon. You are welcome to review and comment on it.
>
> Thanks Alvaro. I'll be very happy to try it out.
>

I hope I haven't jumped the gun here. Apologies in advance if I have. I
noticed a change in CVS which appears to be a fix so I compiled and tested.
Here is what I have found.

The Net Worth Today report is fixed I no longer see it being affected by the
fraction. The totals match the account screen and home page summary.

Other reports have not changed. Examples are Account Balances By Institution /
Type and Investment Holding By Account / Type. The price and value columns
are both still being affected by the fraction as I originally described.

Thanks for looking at this.
Dave.

I will take a look at this. The Investment reports are mostly a special kind, so they are probably unaffected by the change I made on Saturday.

Thomas, 

can you check this patch and commit it if it's ok?

This should fix the problem for the remaining reports, I hope.

Regards,

Alvaro

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
KMyMoney2-developer mailing list
KMyMoney2-developer@...
https://lists.sourceforge.net/lists/listinfo/kmymoney2-developer

[Thomas Baumgart]

On Tuesday 20 October 2009 04:36:16 Alvaro Soliverez wrote:
> On Mon, Oct 19, 2009 at 11:54 AM, Alvaro Soliverez
<asoliverez@...>wrote:
> > On Mon, Oct 19, 2009 at 10:03 AM, David Houlden
<djhoulden@...>wrote:

> >> Hi Alvaro,
> >>
> >> On Saturday 17 October 2009 David Houlden wrote:
> >> > On Saturday 17 October 2009 Alvaro Soliverez wrote:
> >> > > On Sat, Oct 17, 2009 at 2:52 PM, David Houlden <djhoulden@...>
> >>
> >> wrote:
> >> > > > But, shouldn't all
> >> > > > elements (account screen, home page summary, reports) all work the
> >>
> >> same
> >>
> >> > > > way so we don't get two different values displayed for the same
> >>
> >> thing.
> >>
> >> > > > I'm not saying it's a simple change to make but definitely
> >> > > > something
> >>
> >> to
> >>
> >> > > > aim for long
> >> > > > term.
> >> > >
> >> > > Except that you are doing different things.  The account view shows
> >> > > a balance at a point in time.  The one in reports has  to be summed
> >> > > up over time. Or I can show you the current balance, just like the
> >>
> >> accounts
> >>
> >> > > view does, the numbers will match, and everybody will be happy, not.
> >>
> >>  ;)
> >>
> >> > OK. I think I understand what you are saying and that may be the way
> >> > reports work internally. However, just thinking from the end user
> >> > viewpoint, I first noticed this problem on the Net Worth Today report.
> >>
> >> That
> >>
> >> > report shows a balance at a point in time (today). Therefore isn't it
> >> > reasonable to assume that the balance would be the same as on the
> >> > other views.
> >> >
> >> > > I will send a patch to Thomas with a fix, because my KDE3
> >> > > development environment is hosed at the moment and I don't think it
> >> > > will be up anytime soon. You are welcome to review and comment on
> >> > > it.
> >> >
> >> > Thanks Alvaro. I'll be very happy to try it out.
> >>
> >> I hope I haven't jumped the gun here. Apologies in advance if I have. I
> >> noticed a change in CVS which appears to be a fix so I compiled and
> >> tested.
> >> Here is what I have found.
> >>
> >> The Net Worth Today report is fixed I no longer see it being affected by
> >> the
> >> fraction. The totals match the account screen and home page summary.
> >>
> >> Other reports have not changed. Examples are Account Balances By
> >> Institution /
> >> Type and Investment Holding By Account / Type. The price and value
> >> columns are both still being affected by the fraction as I originally
> >> described.
> >>
> >> Thanks for looking at this.
> >> Dave.
> >
> > I will take a look at this. The Investment reports are mostly a special
> > kind, so they are probably unaffected by the change I made on Saturday.
>
> Thomas,
> can you check this patch and commit it if it's ok?
> This should fix the problem for the remaining reports, I hope.

Not so sure about it. You use the following construct:

  account.currency().tradingCurrency()

where in the case of account being a stock account, account.currency() should
return the tradingCurrency. Here's the code:

MyMoneySecurity ReportAccount::currency( void ) const
{
  MyMoneyFile* file = MyMoneyFile::instance();

  // First, get the deep currency
  MyMoneySecurity deepcurrency = file->security( currencyId() );
  if ( ! deepcurrency.isCurrency() )
    deepcurrency = file->security( deepcurrency.tradingCurrency() );

  // Return the deep currency's ID
  return deepcurrency;
}

so in case of a stock the initial deepcurrency should return false for
isCurrency() and when the tradingCurrency() is collected. Not sure, why this
isn't working.

Do we have a demo file that shows the problem?

--

Regards

Thomas Baumgart

GPG-FP: E55E D592 F45F 116B 8429   4F99 9C59 DB40 B75D D3BA
-------------------------------------------------------------
An optimist laughs to forget.
A pessimist forgets to laugh.
-------------------------------------------------------------


------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
KMyMoney2-developer mailing list
KMyMoney2-developer@...
https://lists.sourceforge.net/lists/listinfo/kmymoney2-developer

On Tuesday 20 October 2009 Thomas Baumgart wrote:

> On Tuesday 20 October 2009 04:36:16 Alvaro Soliverez wrote:
> > On Mon, Oct 19, 2009 at 11:54 AM, Alvaro Soliverez
>
> <asoliverez@...>wrote:
> > > On Mon, Oct 19, 2009 at 10:03 AM, David Houlden
>
> <djhoulden@...>wrote:
> > >> Hi Alvaro,
> > >>
> > >> On Saturday 17 October 2009 David Houlden wrote:
> > >> > On Saturday 17 October 2009 Alvaro Soliverez wrote:
> > >> > > On Sat, Oct 17, 2009 at 2:52 PM, David Houlden
> > >> > > <djhoulden@...>
> > >>
> > >> wrote:
> > >> > > > But, shouldn't all
> > >> > > > elements (account screen, home page summary, reports) all work
> > >> > > > the
> > >>
> > >> same
> > >>
> > >> > > > way so we don't get two different values displayed for the same
> > >>
> > >> thing.
> > >>
> > >> > > > I'm not saying it's a simple change to make but definitely
> > >> > > > something
> > >>
> > >> to
> > >>
> > >> > > > aim for long
> > >> > > > term.
> > >> > >
> > >> > > Except that you are doing different things.  The account view
> > >> > > shows a balance at a point in time.  The one in reports has  to be
> > >> > > summed up over time. Or I can show you the current balance, just
> > >> > > like the
> > >>
> > >> accounts
> > >>
> > >> > > view does, the numbers will match, and everybody will be happy,
> > >> > > not.
> > >>
> > >>  ;)
> > >>
> > >> > OK. I think I understand what you are saying and that may be the way
> > >> > reports work internally. However, just thinking from the end user
> > >> > viewpoint, I first noticed this problem on the Net Worth Today
> > >> > report.
> > >>
> > >> That
> > >>
> > >> > report shows a balance at a point in time (today). Therefore isn't
> > >> > it reasonable to assume that the balance would be the same as on the
> > >> > other views.
> > >> >
> > >> > > I will send a patch to Thomas with a fix, because my KDE3
> > >> > > development environment is hosed at the moment and I don't think
> > >> > > it will be up anytime soon. You are welcome to review and comment
> > >> > > on it.
> > >> >
> > >> > Thanks Alvaro. I'll be very happy to try it out.
> > >>
> > >> I hope I haven't jumped the gun here. Apologies in advance if I have.
> > >> I noticed a change in CVS which appears to be a fix so I compiled and
> > >> tested.
> > >> Here is what I have found.
> > >>
> > >> The Net Worth Today report is fixed I no longer see it being affected
> > >> by the
> > >> fraction. The totals match the account screen and home page summary.
> > >>
> > >> Other reports have not changed. Examples are Account Balances By
> > >> Institution /
> > >> Type and Investment Holding By Account / Type. The price and value
> > >> columns are both still being affected by the fraction as I originally
> > >> described.
> > >>
> > >> Thanks for looking at this.
> > >> Dave.
> > >
> > > I will take a look at this. The Investment reports are mostly a special
> > > kind, so they are probably unaffected by the change I made on Saturday.
> >
> > Thomas,
> > can you check this patch and commit it if it's ok?
> > This should fix the problem for the remaining reports, I hope.
>
> Not so sure about it. You use the following construct:
>
>   account.currency().tradingCurrency()
>
> where in the case of account being a stock account, account.currency()
> should return the tradingCurrency. Here's the code:
>
> MyMoneySecurity ReportAccount::currency( void ) const
> {
>   MyMoneyFile* file = MyMoneyFile::instance();
>
>   // First, get the deep currency
>   MyMoneySecurity deepcurrency = file->security( currencyId() );
>   if ( ! deepcurrency.isCurrency() )
>     deepcurrency = file->security( deepcurrency.tradingCurrency() );
>
>   // Return the deep currency's ID
>   return deepcurrency;
> }
>
> so in case of a stock the initial deepcurrency should return false for
> isCurrency() and when the tradingCurrency() is collected. Not sure, why
> this isn't working.
>
> Do we have a demo file that shows the problem?

Small demo file attached below.

The test stock value as shown on the home page and account page is 64.63.
Net Worth Today report also shows 64.63 after Alvaro's change on Saturday.
Investment Holdings By Account / Type show a value of 65.00 with a price of
3.00 which should be 2.81.

Hope that helps.
Dave.


------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
KMyMoney2-developer mailing list
KMyMoney2-developer@...
https://lists.sourceforge.net/lists/listinfo/kmymoney2-developer

[Thomas Baumgart]

On Tuesday 20 October 2009 13:08:18 David Houlden wrote:
> On Tuesday 20 October 2009 Thomas Baumgart wrote:

[...]

> > Do we have a demo file that shows the problem?
>
> Small demo file attached below.
>
> The test stock value as shown on the home page and account page is 64.63.
> Net Worth Today report also shows 64.63 after Alvaro's change on Saturday.
> Investment Holdings By Account / Type show a value of 65.00 with a price of
> 3.00 which should be 2.81.
>
> Hope that helps.

Yes, that helped a lot.  I could fix the problem with the following change:

--- querytable.cpp      9 Sep 2009 03:59:21 -0000       1.68
+++ querytable.cpp      21 Oct 2009 09:42:34 -0000
@@ -1098,7 +1098,7 @@
     ReportAccount account = *it_account;

     //get fraction for account
-    int fraction = account.fraction();
+    int fraction = account.currency().smallestAccountFraction();

       //use base currency fraction if not initialized
     if(fraction == -1)


@Alvaro: can you take a look if this could also be used in the other locations
or if there is something I overlook.

--

Regards

Thomas Baumgart

GPG-FP: E55E D592 F45F 116B 8429   4F99 9C59 DB40 B75D D3BA
-------------------------------------------------------------
90 percent of all errors are sitting
60 cm in front of the display.
-------------------------------------------------------------


------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
KMyMoney2-developer mailing list
KMyMoney2-developer@...
https://lists.sourceforge.net/lists/listinfo/kmymoney2-developer

[Alvaro Soliverez]

On Wed, Oct 21, 2009 at 7:45 AM, Thomas Baumgart <thb@...> wrote:

On Tuesday 20 October 2009 13:08:18 David Houlden wrote:
> On Tuesday 20 October 2009 Thomas Baumgart wrote:

[...]

> > Do we have a demo file that shows the problem?
>
> Small demo file attached below.
>
> The test stock value as shown on the home page and account page is 64.63.
> Net Worth Today report also shows 64.63 after Alvaro's change on Saturday.
> Investment Holdings By Account / Type show a value of 65.00 with a price of
> 3.00 which should be 2.81.
>
> Hope that helps.

Yes, that helped a lot.  I could fix the problem with the following change:

--- querytable.cpp      9 Sep 2009 03:59:21 -0000       1.68
+++ querytable.cpp      21 Oct 2009 09:42:34 -0000
@@ -1098,7 +1098,7 @@
    ReportAccount account = *it_account;

    //get fraction for account
-    int fraction = account.fraction();
+    int fraction = account.currency().smallestAccountFraction();

      //use base currency fraction if not initialized
    if(fraction == -1)


@Alvaro: can you take a look if this could also be used in the other locations
or if there is something I overlook.

Yes, that  can replace the other locations. I can prepare a new patch and send it for you to check. 

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
KMyMoney2-developer mailing list
KMyMoney2-developer@...
https://lists.sourceforge.net/lists/listinfo/kmymoney2-developer

[Thomas Baumgart]

On Wednesday 21 October 2009 12:53:24 Alvaro Soliverez wrote:
> On Wed, Oct 21, 2009 at 7:45 AM, Thomas Baumgart <thb@...> wrote:

[...]

> > Yes, that helped a lot.  I could fix the problem with the following
> > change:
> >
> > --- querytable.cpp      9 Sep 2009 03:59:21 -0000       1.68
> > +++ querytable.cpp      21 Oct 2009 09:42:34 -0000
> > @@ -1098,7 +1098,7 @@
> >     ReportAccount account = *it_account;
> >
> >     //get fraction for account
> > -    int fraction = account.fraction();
> > +    int fraction = account.currency().smallestAccountFraction();
> >
> >       //use base currency fraction if not initialized
> >     if(fraction == -1)
> >
> >
> > @Alvaro: can you take a look if this could also be used in the other
> > locations
> > or if there is something I overlook.
>
> Yes, that  can replace the other locations. I can prepare a new patch and
> send it for you to check.

That would be cool.

--

Regards

Thomas Baumgart

GPG-FP: E55E D592 F45F 116B 8429   4F99 9C59 DB40 B75D D3BA
-------------------------------------------------------------
Memory's the second thing to go ... Can't remember the first.
-------------------------------------------------------------


------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
KMyMoney2-developer mailing list
KMyMoney2-developer@...
https://lists.sourceforge.net/lists/listinfo/kmymoney2-developer

[Alvaro Soliverez]

On Wed, Oct 21, 2009 at 9:50 AM, Thomas Baumgart <thb@...> wrote:

On Wednesday 21 October 2009 12:53:24 Alvaro Soliverez wrote:
> On Wed, Oct 21, 2009 at 7:45 AM, Thomas Baumgart <thb@...> wrote:

[...]

> > Yes, that helped a lot.  I could fix the problem with the following
> > change:
> >
> > --- querytable.cpp      9 Sep 2009 03:59:21 -0000       1.68
> > +++ querytable.cpp      21 Oct 2009 09:42:34 -0000
> > @@ -1098,7 +1098,7 @@
> >     ReportAccount account = *it_account;
> >
> >     //get fraction for account
> > -    int fraction = account.fraction();
> > +    int fraction = account.currency().smallestAccountFraction();
> >
> >       //use base currency fraction if not initialized
> >     if(fraction == -1)
> >
> >
> > @Alvaro: can you take a look if this could also be used in the other
> > locations
> > or if there is something I overlook.
>
> Yes, that  can replace the other locations. I can prepare a new patch and
> send it for you to check.

That would be cool.

Here is the patch. Check it out and let me know. 

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
KMyMoney2-developer mailing list
KMyMoney2-developer@...
https://lists.sourceforge.net/lists/listinfo/kmymoney2-developer

On Thursday 22 October 2009 Alvaro Soliverez wrote:

> On Wed, Oct 21, 2009 at 9:50 AM, Thomas Baumgart <thb@...> wrote:
> > On Wednesday 21 October 2009 12:53:24 Alvaro Soliverez wrote:
> > > On Wed, Oct 21, 2009 at 7:45 AM, Thomas Baumgart <thb@...>
> >
> > wrote:
> >
> > [...]
> >
> > > > Yes, that helped a lot.  I could fix the problem with the following
> > > > change:
> > > >
> > > > --- querytable.cpp      9 Sep 2009 03:59:21 -0000       1.68
> > > > +++ querytable.cpp      21 Oct 2009 09:42:34 -0000
> > > > @@ -1098,7 +1098,7 @@
> > > >     ReportAccount account = *it_account;
> > > >
> > > >     //get fraction for account
> > > > -    int fraction = account.fraction();
> > > > +    int fraction = account.currency().smallestAccountFraction();
> > > >
> > > >       //use base currency fraction if not initialized
> > > >     if(fraction == -1)
> > > >
> > > >
> > > > @Alvaro: can you take a look if this could also be used in the other
> > > > locations
> > > > or if there is something I overlook.
> > >
> > > Yes, that  can replace the other locations. I can prepare a new patch
> > > and send it for you to check.
> >
> > That would be cool.
>
> Here is the patch. Check it out and let me know.

Thanks. I patched my source tree and did some testing. As far as I can see,
this fixes all the rounding problems I reported.

There is one remaining problem with the investment reports. The stock prices
are always displayed with 2 decimal places even though I have the price
precision set to 4. I have some stocks which have a price specified to
fractions of a penny. The total value of these stocks is correctly displayed
to 2 decimal places (nearest penny) but I would like the prices displayed
according to the price precision I specified. Is that possible?

As always, thanks Alvaro and Thomas for your work on this and for providing
the patch.

Regards,
Dave.

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
KMyMoney2-developer mailing list
KMyMoney2-developer@...
https://lists.sourceforge.net/lists/listinfo/kmymoney2-developer

[Alvaro Soliverez]

On Sat, Oct 24, 2009 at 9:05 AM, David Houlden <djhoulden@...> wrote:

On Thursday 22 October 2009 Alvaro Soliverez wrote:
> On Wed, Oct 21, 2009 at 9:50 AM, Thomas Baumgart <thb@...> wrote:
> > On Wednesday 21 October 2009 12:53:24 Alvaro Soliverez wrote:
> > > On Wed, Oct 21, 2009 at 7:45 AM, Thomas Baumgart <thb@...>
> >
> > wrote:
> >
> > [...]
> >
> > > > Yes, that helped a lot.  I could fix the problem with the following
> > > > change:
> > > >
> > > > --- querytable.cpp      9 Sep 2009 03:59:21 -0000       1.68
> > > > +++ querytable.cpp      21 Oct 2009 09:42:34 -0000
> > > > @@ -1098,7 +1098,7 @@
> > > >     ReportAccount account = *it_account;
> > > >
> > > >     //get fraction for account
> > > > -    int fraction = account.fraction();
> > > > +    int fraction = account.currency().smallestAccountFraction();
> > > >
> > > >       //use base currency fraction if not initialized
> > > >     if(fraction == -1)
> > > >
> > > >
> > > > @Alvaro: can you take a look if this could also be used in the other
> > > > locations
> > > > or if there is something I overlook.
> > >
> > > Yes, that  can replace the other locations. I can prepare a new patch
> > > and send it for you to check.
> >
> > That would be cool.
>
> Here is the patch. Check it out and let me know.

Thanks. I patched my source tree and did some testing. As far as I can see,
this fixes all the rounding problems I reported.

There is one remaining problem with the investment reports. The stock prices
are always displayed with 2 decimal places even though I have the price
precision set to 4. I have some stocks which have a price specified to
fractions of a penny. The total value of these stocks is correctly displayed
to 2 decimal places (nearest penny) but I would like the prices displayed
according to the price precision I specified. Is that possible?

As always, thanks Alvaro and Thomas for your work on this and for providing
the patch.

If you can provide me the exact names of the report and column, I can take a look at it.
Thanks!

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
KMyMoney2-developer mailing list
KMyMoney2-developer@...
https://lists.sourceforge.net/lists/listinfo/kmymoney2-developer

On Saturday 24 October 2009 Alvaro Soliverez wrote:

> On Sat, Oct 24, 2009 at 9:05 AM, David Houlden <djhoulden@...> wrote:
> > On Thursday 22 October 2009 Alvaro Soliverez wrote:
> > > On Wed, Oct 21, 2009 at 9:50 AM, Thomas Baumgart <thb@...>
> >
> > wrote:
> > > > On Wednesday 21 October 2009 12:53:24 Alvaro Soliverez wrote:
> > > > > On Wed, Oct 21, 2009 at 7:45 AM, Thomas Baumgart
> > > > > <thb@...>
> > > >
> > > > wrote:
> > > >
> > > > [...]
> > > >
> > > > > > Yes, that helped a lot.  I could fix the problem with the
> > > > > > following change:
> > > > > >
> > > > > > --- querytable.cpp      9 Sep 2009 03:59:21 -0000       1.68
> > > > > > +++ querytable.cpp      21 Oct 2009 09:42:34 -0000
> > > > > > @@ -1098,7 +1098,7 @@
> > > > > >     ReportAccount account = *it_account;
> > > > > >
> > > > > >     //get fraction for account
> > > > > > -    int fraction = account.fraction();
> > > > > > +    int fraction = account.currency().smallestAccountFraction();
> > > > > >
> > > > > >       //use base currency fraction if not initialized
> > > > > >     if(fraction == -1)
> > > > > >
> > > > > >
> > > > > > @Alvaro: can you take a look if this could also be used in the
> >
> > other
> >
> > > > > > locations
> > > > > > or if there is something I overlook.
> > > > >
> > > > > Yes, that  can replace the other locations. I can prepare a new
> > > > > patch and send it for you to check.
> > > >
> > > > That would be cool.
> > >
> > > Here is the patch. Check it out and let me know.
> >
> > Thanks. I patched my source tree and did some testing. As far as I can
> > see, this fixes all the rounding problems I reported.
> >
> > There is one remaining problem with the investment reports. The stock
> > prices
> > are always displayed with 2 decimal places even though I have the price
> > precision set to 4. I have some stocks which have a price specified to
> > fractions of a penny. The total value of these stocks is correctly
> > displayed
> > to 2 decimal places (nearest penny) but I would like the prices displayed
> > according to the price precision I specified. Is that possible?
> >
> > As always, thanks Alvaro and Thomas for your work on this and for
> > providing the patch.
> >
> > If you can provide me the exact names of the report and column, I can
> > take
>
> a look at it.
> Thanks!

OK. No problem.

"Investment Transactions" "Price" column.
"Investment holding by account" "Price" column.
"Investment holdings by type" "Price" column.

Then there are the charts which show prices. The prices can optionally be
displayed at the points on the charts and also appear in the popups when
hovering over a point. I have a concern that increasing the decimal places on
charts may make them look too cluttered. I'll list them here anyway and would
welcome other opinions as to whether the charts should be modified. Also,
these charts can be displayed as reports.

Investment Moving Average Price Graph
Investment Price Graph

Thanks,
Dave.

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
KMyMoney2-developer mailing list
KMyMoney2-developer@...
https://lists.sourceforge.net/lists/listinfo/kmymoney2-developer

[Alvaro Soliverez]

On Sat, Oct 24, 2009 at 9:43 AM, David Houlden <djhoulden@...> wrote:

On Saturday 24 October 2009 Alvaro Soliverez wrote:
> On Sat, Oct 24, 2009 at 9:05 AM, David Houlden <djhoulden@...> wrote:
> > On Thursday 22 October 2009 Alvaro Soliverez wrote:
> > > On Wed, Oct 21, 2009 at 9:50 AM, Thomas Baumgart <thb@...>
> >
> > wrote:
> > > > On Wednesday 21 October 2009 12:53:24 Alvaro Soliverez wrote:
> > > > > On Wed, Oct 21, 2009 at 7:45 AM, Thomas Baumgart
> > > > > <thb@...>
> > > >
> > > > wrote:
> > > >
> > > > [...]
> > > >
> > > > > > Yes, that helped a lot.  I could fix the problem with the
> > > > > > following change:
> > > > > >
> > > > > > --- querytable.cpp      9 Sep 2009 03:59:21 -0000       1.68
> > > > > > +++ querytable.cpp      21 Oct 2009 09:42:34 -0000
> > > > > > @@ -1098,7 +1098,7 @@
> > > > > >     ReportAccount account = *it_account;
> > > > > >
> > > > > >     //get fraction for account
> > > > > > -    int fraction = account.fraction();
> > > > > > +    int fraction = account.currency().smallestAccountFraction();
> > > > > >
> > > > > >       //use base currency fraction if not initialized
> > > > > >     if(fraction == -1)
> > > > > >
> > > > > >
> > > > > > @Alvaro: can you take a look if this could also be used in the
> >
> > other
> >
> > > > > > locations
> > > > > > or if there is something I overlook.
> > > > >
> > > > > Yes, that  can replace the other locations. I can prepare a new
> > > > > patch and send it for you to check.
> > > >
> > > > That would be cool.
> > >
> > > Here is the patch. Check it out and let me know.
> >
> > Thanks. I patched my source tree and did some testing. As far as I can
> > see, this fixes all the rounding problems I reported.
> >
> > There is one remaining problem with the investment reports. The stock
> > prices
> > are always displayed with 2 decimal places even though I have the price
> > precision set to 4. I have some stocks which have a price specified to
> > fractions of a penny. The total value of these stocks is correctly
> > displayed
> > to 2 decimal places (nearest penny) but I would like the prices displayed
> > according to the price precision I specified. Is that possible?
> >
> > As always, thanks Alvaro and Thomas for your work on this and for
> > providing the patch.
> >
> > If you can provide me the exact names of the report and column, I can
> > take
>
> a look at it.
> Thanks!

OK. No problem.

"Investment Transactions" "Price" column.
"Investment holding by account" "Price" column.
"Investment holdings by type" "Price" column.

I commited a fix for these reports, let me know how it goes. What I noticed is that only in one case did it really use the fraction of the account. In the others, it would use the price just like it came from the engine.

Then there are the charts which show prices. The prices can optionally be
displayed at the points on the charts and also appear in the popups when
hovering over a point. I have a concern that increasing the decimal places on
charts may make them look too cluttered. I'll list them here anyway and would
welcome other opinions as to whether the charts should be modified. Also,
these charts can be displayed as reports.

Investment Moving Average Price Graph
Investment Price Graph

These reports are a whole different story. For the moment, it is actually showing an account with a balance of 1 share, it's not really showing the price. So, it will stay like it is for the time being, because fixing this requires a big overhaul.

Regards,

Alvaro 

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
KMyMoney2-developer mailing list
KMyMoney2-developer@...
https://lists.sourceforge.net/lists/listinfo/kmymoney2-developer

On Saturday 24 October 2009 Alvaro Soliverez wrote:

> On Sat, Oct 24, 2009 at 9:43 AM, David Houlden <djhoulden@...> wrote:
> > On Saturday 24 October 2009 Alvaro Soliverez wrote:
> > > On Sat, Oct 24, 2009 at 9:05 AM, David Houlden <djhoulden@...>
> >
> > wrote:
> > > > On Thursday 22 October 2009 Alvaro Soliverez wrote:
> > > > > On Wed, Oct 21, 2009 at 9:50 AM, Thomas Baumgart
> > > > > <thb@...>
> > > >
> > > > wrote:
> > > > > > On Wednesday 21 October 2009 12:53:24 Alvaro Soliverez wrote:
> > > > > > > On Wed, Oct 21, 2009 at 7:45 AM, Thomas Baumgart
> > > > > > > <thb@...>
> > > > > >
> > > > > > wrote:
> > > > > >
> > > > > > [...]
> > > > > >
> > > > > > > > Yes, that helped a lot.  I could fix the problem with the
> > > > > > > > following change:
> > > > > > > >
> > > > > > > > --- querytable.cpp      9 Sep 2009 03:59:21 -0000       1.68
> > > > > > > > +++ querytable.cpp      21 Oct 2009 09:42:34 -0000
> > > > > > > > @@ -1098,7 +1098,7 @@
> > > > > > > >     ReportAccount account = *it_account;
> > > > > > > >
> > > > > > > >     //get fraction for account
> > > > > > > > -    int fraction = account.fraction();
> > > > > > > > +    int fraction =
> >
> > account.currency().smallestAccountFraction();
> >
> > > > > > > >       //use base currency fraction if not initialized
> > > > > > > >     if(fraction == -1)
> > > > > > > >
> > > > > > > >
> > > > > > > > @Alvaro: can you take a look if this could also be used in
> > > > > > > > the
> > > >
> > > > other
> > > >
> > > > > > > > locations
> > > > > > > > or if there is something I overlook.
> > > > > > >
> > > > > > > Yes, that  can replace the other locations. I can prepare a new
> > > > > > > patch and send it for you to check.
> > > > > >
> > > > > > That would be cool.
> > > > >
> > > > > Here is the patch. Check it out and let me know.
> > > >
> > > > Thanks. I patched my source tree and did some testing. As far as I
> > > > can see, this fixes all the rounding problems I reported.
> > > >
> > > > There is one remaining problem with the investment reports. The stock
> > > > prices
> > > > are always displayed with 2 decimal places even though I have the
> > > > price precision set to 4. I have some stocks which have a price
> > > > specified to fractions of a penny. The total value of these stocks is
> > > > correctly displayed
> > > > to 2 decimal places (nearest penny) but I would like the prices
> >
> > displayed
> >
> > > > according to the price precision I specified. Is that possible?
> > > >
> > > > As always, thanks Alvaro and Thomas for your work on this and for
> > > > providing the patch.
> > > >
> > > > If you can provide me the exact names of the report and column, I can
> > > > take
> > >
> > > a look at it.
> > > Thanks!
> >
> > OK. No problem.
> >
> > "Investment Transactions" "Price" column.
> > "Investment holding by account" "Price" column.
> > "Investment holdings by type" "Price" column.
>
> I commited a fix for these reports, let me know how it goes. What I noticed
> is that only in one case did it really use the fraction of the account. In
> the others, it would use the price just like it came from the engine.
>

Sorry Alvaro but I updated to latest CVS HEAD and I am not seeing any change.
Price is still only displaying 2 decimal places on these reports.

> > Then there are the charts which show prices. The prices can optionally be
> > displayed at the points on the charts and also appear in the popups when
> > hovering over a point. I have a concern that increasing the decimal
> > places on
> > charts may make them look too cluttered. I'll list them here anyway and
> > would
> > welcome other opinions as to whether the charts should be modified. Also,
> > these charts can be displayed as reports.
> >
> > Investment Moving Average Price Graph
> > Investment Price Graph
>
> These reports are a whole different story. For the moment, it is actually
> showing an account with a balance of 1 share, it's not really showing the
> price. So, it will stay like it is for the time being, because fixing this
> requires a big overhaul.
>

OK. Thanks for looking anyway.

Regards,
Dave.

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
KMyMoney2-developer mailing list
KMyMoney2-developer@...
https://lists.sourceforge.net/lists/listinfo/kmymoney2-developer