Request for backport of garbage collection patch

[Matt Jones-7]

Hi -

I'm working on improving mono-under-wine (on the wine side), and I've
been hitting a bug in the mono garbage collector fixed by commit
#77073 ([1]). The bug in question is a race condition between
GetExitCodeThread and SuspendThread - if a thread terminates between
the two, SuspendThread will fail. The race condition is pretty
reliably triggered by the regression test suite when running under
wine.

The current patch could actually be reduced further (the
GetExitCodeThread block could be fully deleted, as it is rendered
redundant), but it works as is.

Any chance this patch could be applied to the maintenance branch? The
patch applies cleanly to 1.13.8.2.

Thank you very much,
-Matt Jones

[1] http://anonsvn.mono-project.com/viewcvs/trunk/mono/libgc/win32_threads.c?rev=77073&view=log
_______________________________________________
Mono-gc-list maillist  -  Mono-gc-list@...
http://lists.ximian.com/mailman/listinfo/mono-gc-list

[Paolo Molaro-2]

On 07/17/07 Matt Jones wrote:
> I'm working on improving mono-under-wine (on the wine side), and I've
[...]
> Any chance this patch could be applied to the maintenance branch? The
> patch applies cleanly to 1.13.8.2.

I really hope you're not basing your improvements on mono 1.13.x: it
is a really old release which nobody should use at this time
(especially not to build something new like wine support upon it).
Use mono version 1.2.4 (or the upcoming 1.2.5).

lupus

--
-----------------------------------------------------------------
lupus@...                                     debian/rules
lupus@...                             Monkeys do it better
_______________________________________________
Mono-gc-list maillist  -  Mono-gc-list@...
http://lists.ximian.com/mailman/listinfo/mono-gc-list

[Matt Jones-7]

On 7/26/07, Paolo Molaro <lupus@...> wrote:

> On 07/17/07 Matt Jones wrote:
> > I'm working on improving mono-under-wine (on the wine side), and I've
> [...]
> > Any chance this patch could be applied to the maintenance branch? The
> > patch applies cleanly to 1.13.8.2.
>
> I really hope you're not basing your improvements on mono 1.13.x: it
> is a really old release which nobody should use at this time
> (especially not to build something new like wine support upon it).
> Use mono version 1.2.4 (or the upcoming 1.2.5).

Right. The problem is that mono 1.2 fails horribly under wine, whereas
mono 1.1 works pretty well. I'm working on getting mono 1.2 to run
under wine, but having a fully-functional 1.1 runtime would help.

The intention is not to stick with 1.1.*, but use it until wine can
successfully host a 1.2 runtime.

matt
_______________________________________________
Mono-gc-list maillist  -  Mono-gc-list@...
http://lists.ximian.com/mailman/listinfo/mono-gc-list

[Miguel de Icaza-2]

> Right. The problem is that mono 1.2 fails horribly under wine, whereas
> mono 1.1 works pretty well. I'm working on getting mono 1.2 to run
> under wine, but having a fully-functional 1.1 runtime would help.

It would be interesting to know how Mono 1.2 fails with Wine, there is
not much in this email that we can act on.

> The intention is not to stick with 1.1.*, but use it until wine can
> successfully host a 1.2 runtime.
>
> matt
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list@...
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
_______________________________________________
Mono-gc-list maillist  -  Mono-gc-list@...
http://lists.ximian.com/mailman/listinfo/mono-gc-list